diff options
author | Jesper Juhl <jesper.juhl@gmail.com> | 2005-11-07 04:01:30 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-07 10:54:03 -0500 |
commit | 17fd682e544556a2a829e94383239c029bb21c5e (patch) | |
tree | 4b78bdd36efdbf9fb2c4c11382ed88898ceec48c /drivers/s390/cio | |
parent | 3c7208f253571ee5f157b98f0e315b5172afe092 (diff) |
[PATCH] kfree cleanup: drivers/s390
This is the drivers/s390/ part of the big kfree cleanup patch.
Remove pointless checks for NULL prior to calling kfree() in drivers/s390/.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Cornelia Huck <cohuck@de.ibm.com>
Acked-by: Stefan Bader <Stefan.Bader@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/s390/cio')
-rw-r--r-- | drivers/s390/cio/cmf.c | 3 | ||||
-rw-r--r-- | drivers/s390/cio/device_ops.c | 6 | ||||
-rw-r--r-- | drivers/s390/cio/qdio.c | 9 |
3 files changed, 6 insertions, 12 deletions
diff --git a/drivers/s390/cio/cmf.c b/drivers/s390/cio/cmf.c index c05b069c2996..b978f7fe8327 100644 --- a/drivers/s390/cio/cmf.c +++ b/drivers/s390/cio/cmf.c | |||
@@ -642,8 +642,7 @@ static void | |||
642 | free_cmbe (struct ccw_device *cdev) | 642 | free_cmbe (struct ccw_device *cdev) |
643 | { | 643 | { |
644 | spin_lock_irq(cdev->ccwlock); | 644 | spin_lock_irq(cdev->ccwlock); |
645 | if (cdev->private->cmb) | 645 | kfree(cdev->private->cmb); |
646 | kfree(cdev->private->cmb); | ||
647 | cdev->private->cmb = NULL; | 646 | cdev->private->cmb = NULL; |
648 | spin_unlock_irq(cdev->ccwlock); | 647 | spin_unlock_irq(cdev->ccwlock); |
649 | 648 | ||
diff --git a/drivers/s390/cio/device_ops.c b/drivers/s390/cio/device_ops.c index ad3fe5aeb663..85a3026e6900 100644 --- a/drivers/s390/cio/device_ops.c +++ b/drivers/s390/cio/device_ops.c | |||
@@ -550,10 +550,8 @@ ccw_device_stlck(struct ccw_device *cdev) | |||
550 | /* Clear irb. */ | 550 | /* Clear irb. */ |
551 | memset(&cdev->private->irb, 0, sizeof(struct irb)); | 551 | memset(&cdev->private->irb, 0, sizeof(struct irb)); |
552 | out_unlock: | 552 | out_unlock: |
553 | if (buf) | 553 | kfree(buf); |
554 | kfree(buf); | 554 | kfree(buf2); |
555 | if (buf2) | ||
556 | kfree(buf2); | ||
557 | spin_unlock_irqrestore(&sch->lock, flags); | 555 | spin_unlock_irqrestore(&sch->lock, flags); |
558 | return ret; | 556 | return ret; |
559 | } | 557 | } |
diff --git a/drivers/s390/cio/qdio.c b/drivers/s390/cio/qdio.c index ef5cd07011bb..eb39218b925e 100644 --- a/drivers/s390/cio/qdio.c +++ b/drivers/s390/cio/qdio.c | |||
@@ -1338,16 +1338,14 @@ qdio_release_irq_memory(struct qdio_irq *irq_ptr) | |||
1338 | if (!irq_ptr->input_qs[i]) | 1338 | if (!irq_ptr->input_qs[i]) |
1339 | goto next; | 1339 | goto next; |
1340 | 1340 | ||
1341 | if (irq_ptr->input_qs[i]->slib) | 1341 | kfree(irq_ptr->input_qs[i]->slib); |
1342 | kfree(irq_ptr->input_qs[i]->slib); | ||
1343 | kfree(irq_ptr->input_qs[i]); | 1342 | kfree(irq_ptr->input_qs[i]); |
1344 | 1343 | ||
1345 | next: | 1344 | next: |
1346 | if (!irq_ptr->output_qs[i]) | 1345 | if (!irq_ptr->output_qs[i]) |
1347 | continue; | 1346 | continue; |
1348 | 1347 | ||
1349 | if (irq_ptr->output_qs[i]->slib) | 1348 | kfree(irq_ptr->output_qs[i]->slib); |
1350 | kfree(irq_ptr->output_qs[i]->slib); | ||
1351 | kfree(irq_ptr->output_qs[i]); | 1349 | kfree(irq_ptr->output_qs[i]); |
1352 | 1350 | ||
1353 | } | 1351 | } |
@@ -3315,8 +3313,7 @@ qdio_get_qdio_memory(void) | |||
3315 | static void | 3313 | static void |
3316 | qdio_release_qdio_memory(void) | 3314 | qdio_release_qdio_memory(void) |
3317 | { | 3315 | { |
3318 | if (indicators) | 3316 | kfree(indicators); |
3319 | kfree(indicators); | ||
3320 | } | 3317 | } |
3321 | 3318 | ||
3322 | static void | 3319 | static void |