aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/char
diff options
context:
space:
mode:
authorGautham R Shenoy <ego@in.ibm.com>2008-01-25 15:08:02 -0500
committerIngo Molnar <mingo@elte.hu>2008-01-25 15:08:02 -0500
commit86ef5c9a8edd78e6bf92879f32329d89b2d55b5a (patch)
tree7bf46885326a6fdbb0c3596855408e9a5634dd3a /drivers/s390/char
parentd221938c049f4845da13c8593132595a6b9222a8 (diff)
cpu-hotplug: replace lock_cpu_hotplug() with get_online_cpus()
Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use get_online_cpus and put_online_cpus instead as it highlights the refcount semantics in these operations. The new API guarantees protection against the cpu-hotplug operation, but it doesn't guarantee serialized access to any of the local data structures. Hence the changes needs to be reviewed. In case of pseries_add_processor/pseries_remove_processor, use cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the cpu_present_map there. Signed-off-by: Gautham R Shenoy <ego@in.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/s390/char')
-rw-r--r--drivers/s390/char/sclp_config.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/char/sclp_config.c b/drivers/s390/char/sclp_config.c
index 5322e5e54a98..9dc77f14fa52 100644
--- a/drivers/s390/char/sclp_config.c
+++ b/drivers/s390/char/sclp_config.c
@@ -29,12 +29,12 @@ static void sclp_cpu_capability_notify(struct work_struct *work)
29 struct sys_device *sysdev; 29 struct sys_device *sysdev;
30 30
31 printk(KERN_WARNING TAG "cpu capability changed.\n"); 31 printk(KERN_WARNING TAG "cpu capability changed.\n");
32 lock_cpu_hotplug(); 32 get_online_cpus();
33 for_each_online_cpu(cpu) { 33 for_each_online_cpu(cpu) {
34 sysdev = get_cpu_sysdev(cpu); 34 sysdev = get_cpu_sysdev(cpu);
35 kobject_uevent(&sysdev->kobj, KOBJ_CHANGE); 35 kobject_uevent(&sysdev->kobj, KOBJ_CHANGE);
36 } 36 }
37 unlock_cpu_hotplug(); 37 put_online_cpus();
38} 38}
39 39
40static void sclp_conf_receiver_fn(struct evbuf_header *evbuf) 40static void sclp_conf_receiver_fn(struct evbuf_header *evbuf)