aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/char/vmlogrdr.c
diff options
context:
space:
mode:
authorMartin Schwidefsky <schwidefsky@de.ibm.com>2008-07-14 03:59:37 -0400
committerHeiko Carstens <heiko.carstens@de.ibm.com>2008-07-14 04:02:22 -0400
commit2f6f2521bcfff108e02d97e3a326f995996ce95f (patch)
treec969d02e4e442f0b5b0fa9003ac260671093184c /drivers/s390/char/vmlogrdr.c
parent21b21fc4f4b03361ceec0c7eb6b7b0557d4ffe86 (diff)
[S390] Cleanup vmlogrdr printk messages.
The message descriptions are still missing though .. Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Diffstat (limited to 'drivers/s390/char/vmlogrdr.c')
-rw-r--r--drivers/s390/char/vmlogrdr.c29
1 files changed, 3 insertions, 26 deletions
diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c
index 2c2428cc05d8..a246bc73ae64 100644
--- a/drivers/s390/char/vmlogrdr.c
+++ b/drivers/s390/char/vmlogrdr.c
@@ -216,9 +216,7 @@ static int vmlogrdr_get_recording_class_AB(void)
216 char *tail; 216 char *tail;
217 int len,i; 217 int len,i;
218 218
219 printk (KERN_DEBUG "vmlogrdr: query command: %s\n", cp_command);
220 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL); 219 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL);
221 printk (KERN_DEBUG "vmlogrdr: response: %s", cp_response);
222 len = strnlen(cp_response,sizeof(cp_response)); 220 len = strnlen(cp_response,sizeof(cp_response));
223 // now the parsing 221 // now the parsing
224 tail=strnchr(cp_response,len,'='); 222 tail=strnchr(cp_response,len,'=');
@@ -268,11 +266,7 @@ static int vmlogrdr_recording(struct vmlogrdr_priv_t * logptr,
268 logptr->recording_name, 266 logptr->recording_name,
269 qid_string); 267 qid_string);
270 268
271 printk (KERN_DEBUG "vmlogrdr: recording command: %s\n",
272 cp_command);
273 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL); 269 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL);
274 printk (KERN_DEBUG "vmlogrdr: recording response: %s",
275 cp_response);
276 } 270 }
277 271
278 memset(cp_command, 0x00, sizeof(cp_command)); 272 memset(cp_command, 0x00, sizeof(cp_command));
@@ -282,10 +276,7 @@ static int vmlogrdr_recording(struct vmlogrdr_priv_t * logptr,
282 onoff, 276 onoff,
283 qid_string); 277 qid_string);
284 278
285 printk (KERN_DEBUG "vmlogrdr: recording command: %s\n", cp_command);
286 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL); 279 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL);
287 printk (KERN_DEBUG "vmlogrdr: recording response: %s",
288 cp_response);
289 /* The recording command will usually answer with 'Command complete' 280 /* The recording command will usually answer with 'Command complete'
290 * on success, but when the specific service was never connected 281 * on success, but when the specific service was never connected
291 * before then there might be an additional informational message 282 * before then there might be an additional informational message
@@ -567,10 +558,7 @@ static ssize_t vmlogrdr_purge_store(struct device * dev,
567 "RECORDING %s PURGE ", 558 "RECORDING %s PURGE ",
568 priv->recording_name); 559 priv->recording_name);
569 560
570 printk (KERN_DEBUG "vmlogrdr: recording command: %s\n", cp_command);
571 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL); 561 cpcmd(cp_command, cp_response, sizeof(cp_response), NULL);
572 printk (KERN_DEBUG "vmlogrdr: recording response: %s",
573 cp_response);
574 562
575 return count; 563 return count;
576} 564}
@@ -682,28 +670,20 @@ static int vmlogrdr_register_driver(void)
682 670
683 /* Register with iucv driver */ 671 /* Register with iucv driver */
684 ret = iucv_register(&vmlogrdr_iucv_handler, 1); 672 ret = iucv_register(&vmlogrdr_iucv_handler, 1);
685 if (ret) { 673 if (ret)
686 printk (KERN_ERR "vmlogrdr: failed to register with "
687 "iucv driver\n");
688 goto out; 674 goto out;
689 }
690 675
691 ret = driver_register(&vmlogrdr_driver); 676 ret = driver_register(&vmlogrdr_driver);
692 if (ret) { 677 if (ret)
693 printk(KERN_ERR "vmlogrdr: failed to register driver.\n");
694 goto out_iucv; 678 goto out_iucv;
695 }
696 679
697 ret = driver_create_file(&vmlogrdr_driver, 680 ret = driver_create_file(&vmlogrdr_driver,
698 &driver_attr_recording_status); 681 &driver_attr_recording_status);
699 if (ret) { 682 if (ret)
700 printk(KERN_ERR "vmlogrdr: failed to add driver attribute.\n");
701 goto out_driver; 683 goto out_driver;
702 }
703 684
704 vmlogrdr_class = class_create(THIS_MODULE, "vmlogrdr"); 685 vmlogrdr_class = class_create(THIS_MODULE, "vmlogrdr");
705 if (IS_ERR(vmlogrdr_class)) { 686 if (IS_ERR(vmlogrdr_class)) {
706 printk(KERN_ERR "vmlogrdr: failed to create class.\n");
707 ret = PTR_ERR(vmlogrdr_class); 687 ret = PTR_ERR(vmlogrdr_class);
708 vmlogrdr_class = NULL; 688 vmlogrdr_class = NULL;
709 goto out_attr; 689 goto out_attr;
@@ -871,12 +851,10 @@ static int __init vmlogrdr_init(void)
871 rc = vmlogrdr_register_cdev(dev); 851 rc = vmlogrdr_register_cdev(dev);
872 if (rc) 852 if (rc)
873 goto cleanup; 853 goto cleanup;
874 printk (KERN_INFO "vmlogrdr: driver loaded\n");
875 return 0; 854 return 0;
876 855
877cleanup: 856cleanup:
878 vmlogrdr_cleanup(); 857 vmlogrdr_cleanup();
879 printk (KERN_ERR "vmlogrdr: driver not loaded.\n");
880 return rc; 858 return rc;
881} 859}
882 860
@@ -884,7 +862,6 @@ cleanup:
884static void __exit vmlogrdr_exit(void) 862static void __exit vmlogrdr_exit(void)
885{ 863{
886 vmlogrdr_cleanup(); 864 vmlogrdr_cleanup();
887 printk (KERN_INFO "vmlogrdr: driver unloaded\n");
888 return; 865 return;
889} 866}
890 867