diff options
author | Peter Oberparleiter <peter.oberparleiter@de.ibm.com> | 2011-10-30 10:16:04 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2011-10-30 10:16:15 -0400 |
commit | de400d6b78d15a73023485f050bc6b1709dc7a79 (patch) | |
tree | 2d2e7233a76982db4cf12ff0859054a33e46a911 /drivers/s390/block | |
parent | ce949717b559709423c1ef716a9db16d1dcadaed (diff) |
[S390] fix mismatch in summation of I/O IRQ statistics
Current IRQ statistics support does not show detail counts for I/O
interrupts which are processed internally only. The result is a
summation count which is way off such as this one:
CPU0 CPU1 CPU2
I/O: 1331 710 442
[...]
QAI: 15 16 16 [I/O] QDIO Adapter Interrupt
QDI: 1 0 0 [I/O] QDIO Interrupt
DAS: 706 645 381 [I/O] DASD
C15: 26 10 0 [I/O] 3215
C70: 0 0 0 [I/O] 3270
TAP: 0 0 0 [I/O] Tape
VMR: 0 0 0 [I/O] Unit Record Devices
LCS: 0 0 0 [I/O] LCS
CLW: 0 0 0 [I/O] CLAW
CTC: 0 0 0 [I/O] CTC
APB: 0 0 0 [I/O] AP Bus
Fix this by moving I/O interrupt accounting into the common I/O layer.
Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390/block')
-rw-r--r-- | drivers/s390/block/dasd.c | 2 | ||||
-rw-r--r-- | drivers/s390/block/dasd_eckd.c | 1 | ||||
-rw-r--r-- | drivers/s390/block/dasd_fba.c | 1 |
3 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c index a1d3ddba99cc..46054c75cf31 100644 --- a/drivers/s390/block/dasd.c +++ b/drivers/s390/block/dasd.c | |||
@@ -11,7 +11,6 @@ | |||
11 | #define KMSG_COMPONENT "dasd" | 11 | #define KMSG_COMPONENT "dasd" |
12 | #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt | 12 | #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt |
13 | 13 | ||
14 | #include <linux/kernel_stat.h> | ||
15 | #include <linux/kmod.h> | 14 | #include <linux/kmod.h> |
16 | #include <linux/init.h> | 15 | #include <linux/init.h> |
17 | #include <linux/interrupt.h> | 16 | #include <linux/interrupt.h> |
@@ -1594,7 +1593,6 @@ void dasd_int_handler(struct ccw_device *cdev, unsigned long intparm, | |||
1594 | unsigned long long now; | 1593 | unsigned long long now; |
1595 | int expires; | 1594 | int expires; |
1596 | 1595 | ||
1597 | kstat_cpu(smp_processor_id()).irqs[IOINT_DAS]++; | ||
1598 | if (IS_ERR(irb)) { | 1596 | if (IS_ERR(irb)) { |
1599 | switch (PTR_ERR(irb)) { | 1597 | switch (PTR_ERR(irb)) { |
1600 | case -EIO: | 1598 | case -EIO: |
diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c index 6e835c9fdfcb..0e9c4dcf1452 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c | |||
@@ -3998,6 +3998,7 @@ static struct ccw_driver dasd_eckd_driver = { | |||
3998 | .thaw = dasd_generic_restore_device, | 3998 | .thaw = dasd_generic_restore_device, |
3999 | .restore = dasd_generic_restore_device, | 3999 | .restore = dasd_generic_restore_device, |
4000 | .uc_handler = dasd_generic_uc_handler, | 4000 | .uc_handler = dasd_generic_uc_handler, |
4001 | .int_class = IOINT_DAS, | ||
4001 | }; | 4002 | }; |
4002 | 4003 | ||
4003 | /* | 4004 | /* |
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c index 4b71b1164868..a62a75358eb9 100644 --- a/drivers/s390/block/dasd_fba.c +++ b/drivers/s390/block/dasd_fba.c | |||
@@ -79,6 +79,7 @@ static struct ccw_driver dasd_fba_driver = { | |||
79 | .freeze = dasd_generic_pm_freeze, | 79 | .freeze = dasd_generic_pm_freeze, |
80 | .thaw = dasd_generic_restore_device, | 80 | .thaw = dasd_generic_restore_device, |
81 | .restore = dasd_generic_restore_device, | 81 | .restore = dasd_generic_restore_device, |
82 | .int_class = IOINT_DAS, | ||
82 | }; | 83 | }; |
83 | 84 | ||
84 | static void | 85 | static void |