diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-05 21:52:57 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-07 02:16:21 -0400 |
commit | db2a144bedd58b3dcf19950c2f476c58c9f39d18 (patch) | |
tree | 931f1b5a8e6bafe388b317bce02a9fd9af309d38 /drivers/s390/block/dasd.c | |
parent | a8ca889ed9585894d53fd8919d80cbe8baff09e7 (diff) |
block_device_operations->release() should return void
The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/s390/block/dasd.c')
-rw-r--r-- | drivers/s390/block/dasd.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c index 82758cbb220b..4361d9772c42 100644 --- a/drivers/s390/block/dasd.c +++ b/drivers/s390/block/dasd.c | |||
@@ -2997,18 +2997,14 @@ unlock: | |||
2997 | return rc; | 2997 | return rc; |
2998 | } | 2998 | } |
2999 | 2999 | ||
3000 | static int dasd_release(struct gendisk *disk, fmode_t mode) | 3000 | static void dasd_release(struct gendisk *disk, fmode_t mode) |
3001 | { | 3001 | { |
3002 | struct dasd_device *base; | 3002 | struct dasd_device *base = dasd_device_from_gendisk(disk); |
3003 | 3003 | if (base) { | |
3004 | base = dasd_device_from_gendisk(disk); | 3004 | atomic_dec(&base->block->open_count); |
3005 | if (!base) | 3005 | module_put(base->discipline->owner); |
3006 | return -ENODEV; | 3006 | dasd_put_device(base); |
3007 | 3007 | } | |
3008 | atomic_dec(&base->block->open_count); | ||
3009 | module_put(base->discipline->owner); | ||
3010 | dasd_put_device(base); | ||
3011 | return 0; | ||
3012 | } | 3008 | } |
3013 | 3009 | ||
3014 | /* | 3010 | /* |