diff options
| author | Shubhrajyoti D <shubhrajyoti@ti.com> | 2012-10-04 20:14:17 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-05 14:05:05 -0400 |
| commit | 2bfc37dffa844e5b28a240feec5e2fa8ec2ea8ba (patch) | |
| tree | 52a6d9a4b7c61d975870284bd49ea4c79ac4ffa5 /drivers/rtc | |
| parent | 1ee8c0ca2a6aef9af4b78f860cc690f33fc8f287 (diff) | |
drivers/rtc/rtc-ds1672.c: convert struct i2c_msg initialization to C99 format
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-ds1672.c | 26 |
1 files changed, 22 insertions, 4 deletions
diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c index 7fa67d0df172..45d65c0b3a85 100644 --- a/drivers/rtc/rtc-ds1672.c +++ b/drivers/rtc/rtc-ds1672.c | |||
| @@ -37,8 +37,17 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm) | |||
| 37 | unsigned char buf[4]; | 37 | unsigned char buf[4]; |
| 38 | 38 | ||
| 39 | struct i2c_msg msgs[] = { | 39 | struct i2c_msg msgs[] = { |
| 40 | {client->addr, 0, 1, &addr}, /* setup read ptr */ | 40 | {/* setup read ptr */ |
| 41 | {client->addr, I2C_M_RD, 4, buf}, /* read date */ | 41 | .addr = client->addr, |
| 42 | .len = 1, | ||
| 43 | .buf = &addr | ||
| 44 | }, | ||
| 45 | {/* read date */ | ||
| 46 | .addr = client->addr, | ||
| 47 | .flags = I2C_M_RD, | ||
| 48 | .len = 4, | ||
| 49 | .buf = buf | ||
| 50 | }, | ||
| 42 | }; | 51 | }; |
| 43 | 52 | ||
| 44 | /* read date registers */ | 53 | /* read date registers */ |
| @@ -99,8 +108,17 @@ static int ds1672_get_control(struct i2c_client *client, u8 *status) | |||
| 99 | unsigned char addr = DS1672_REG_CONTROL; | 108 | unsigned char addr = DS1672_REG_CONTROL; |
| 100 | 109 | ||
| 101 | struct i2c_msg msgs[] = { | 110 | struct i2c_msg msgs[] = { |
| 102 | {client->addr, 0, 1, &addr}, /* setup read ptr */ | 111 | {/* setup read ptr */ |
| 103 | {client->addr, I2C_M_RD, 1, status}, /* read control */ | 112 | .addr = client->addr, |
| 113 | .len = 1, | ||
| 114 | .buf = &addr | ||
| 115 | }, | ||
| 116 | {/* read control */ | ||
| 117 | .addr = client->addr, | ||
| 118 | .flags = I2C_M_RD, | ||
| 119 | .len = 1, | ||
| 120 | .buf = status | ||
| 121 | }, | ||
| 104 | }; | 122 | }; |
| 105 | 123 | ||
| 106 | /* read control register */ | 124 | /* read control register */ |
