aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-tx4939.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2013-09-11 17:24:27 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2013-09-11 18:58:59 -0400
commit7c1d69ee11b8986c40a53d8e2238204fc86f5b33 (patch)
treee711a10129ef7b6e060fdfa82dc7eb31f55be2d8 /drivers/rtc/rtc-tx4939.c
parent1735be4b822e8e3808f461372ff3942824790172 (diff)
rtc: simplify devm_request_mem_region/devm_ioremap
Convert the composition of devm_request_mem_region and devm_ioremap to a single call to devm_ioremap_resource. The associated call to platform_get_resource is also simplified and moved next to the new call to devm_ioremap_resource. This was done using a combination of the semantic patches devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in the scripts/coccinelle/api directory. In rtc-lpc32xx.c and rtc-mv.c, the local variable size is no longer needed. In rtc-ds1511.c the size field of the local structure is not useful any more, and is deleted. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-tx4939.c')
-rw-r--r--drivers/rtc/rtc-tx4939.c14
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c
index f9a0677e4e3b..4f87234e0dee 100644
--- a/drivers/rtc/rtc-tx4939.c
+++ b/drivers/rtc/rtc-tx4939.c
@@ -244,9 +244,6 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev)
244 struct resource *res; 244 struct resource *res;
245 int irq, ret; 245 int irq, ret;
246 246
247 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
248 if (!res)
249 return -ENODEV;
250 irq = platform_get_irq(pdev, 0); 247 irq = platform_get_irq(pdev, 0);
251 if (irq < 0) 248 if (irq < 0)
252 return -ENODEV; 249 return -ENODEV;
@@ -255,13 +252,10 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev)
255 return -ENOMEM; 252 return -ENOMEM;
256 platform_set_drvdata(pdev, pdata); 253 platform_set_drvdata(pdev, pdata);
257 254
258 if (!devm_request_mem_region(&pdev->dev, res->start, 255 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
259 resource_size(res), pdev->name)) 256 pdata->rtcreg = devm_ioremap_resource(&pdev->dev, res);
260 return -EBUSY; 257 if (IS_ERR(pdata->rtcreg))
261 pdata->rtcreg = devm_ioremap(&pdev->dev, res->start, 258 return PTR_ERR(pdata->rtcreg);
262 resource_size(res));
263 if (!pdata->rtcreg)
264 return -EBUSY;
265 259
266 spin_lock_init(&pdata->lock); 260 spin_lock_init(&pdata->lock);
267 tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP); 261 tx4939_rtc_cmd(pdata->rtcreg, TX4939_RTCCTL_COMMAND_NOP);