rtc: fix potential race condition

RTC drivers must not return an error after device registration.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
Reported-by: Ales Novak <alnovak@suse.cz>
Cc: Alexander Shiyan <shc_work@mail.ru>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Srikanth Srinivasan <srikanth.srinivasan@freescale.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 3 insertions, 6 deletions

diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c
index 7746e65b93f2..6599c20bc454 100644
--- a/drivers/rtc/rtc-test.c
+++ b/drivers/rtc/rtc-test.c
@@ -104,20 +104,17 @@ static int test_probe(struct platform_device *plat_dev)
         rtc = devm_rtc_device_register(&plat_dev->dev, "test",
                                 &test_rtc_ops, THIS_MODULE);
         if (IS_ERR(rtc)) {
-                err = PTR_ERR(rtc);
-                return err;
+                return PTR_ERR(rtc);
         }
 
         err = device_create_file(&plat_dev->dev, &dev_attr_irq);
         if (err)
-                goto err;
+                dev_err(&plat_dev->dev, "Unable to create sysfs entry: %s\n",
+                        dev_attr_irq.attr.name);
 
         platform_set_drvdata(plat_dev, rtc);
 
         return 0;
-
-err:
-        return err;
 }
 
 static int test_remove(struct platform_device *plat_dev)