diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-09-11 17:24:27 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 18:58:59 -0400 |
commit | 7c1d69ee11b8986c40a53d8e2238204fc86f5b33 (patch) | |
tree | e711a10129ef7b6e060fdfa82dc7eb31f55be2d8 /drivers/rtc/rtc-mv.c | |
parent | 1735be4b822e8e3808f461372ff3942824790172 (diff) |
rtc: simplify devm_request_mem_region/devm_ioremap
Convert the composition of devm_request_mem_region and devm_ioremap to a
single call to devm_ioremap_resource. The associated call to
platform_get_resource is also simplified and moved next to the new call
to devm_ioremap_resource.
This was done using a combination of the semantic patches
devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in
the scripts/coccinelle/api directory.
In rtc-lpc32xx.c and rtc-mv.c, the local variable size is no longer needed.
In rtc-ds1511.c the size field of the local structure is not useful any
more, and is deleted.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-mv.c')
-rw-r--r-- | drivers/rtc/rtc-mv.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c index baab802f2153..d536c5962c99 100644 --- a/drivers/rtc/rtc-mv.c +++ b/drivers/rtc/rtc-mv.c | |||
@@ -221,26 +221,17 @@ static int __init mv_rtc_probe(struct platform_device *pdev) | |||
221 | { | 221 | { |
222 | struct resource *res; | 222 | struct resource *res; |
223 | struct rtc_plat_data *pdata; | 223 | struct rtc_plat_data *pdata; |
224 | resource_size_t size; | ||
225 | u32 rtc_time; | 224 | u32 rtc_time; |
226 | int ret = 0; | 225 | int ret = 0; |
227 | 226 | ||
228 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
229 | if (!res) | ||
230 | return -ENODEV; | ||
231 | |||
232 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); | 227 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); |
233 | if (!pdata) | 228 | if (!pdata) |
234 | return -ENOMEM; | 229 | return -ENOMEM; |
235 | 230 | ||
236 | size = resource_size(res); | 231 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
237 | if (!devm_request_mem_region(&pdev->dev, res->start, size, | 232 | pdata->ioaddr = devm_ioremap_resource(&pdev->dev, res); |
238 | pdev->name)) | 233 | if (IS_ERR(pdata->ioaddr)) |
239 | return -EBUSY; | 234 | return PTR_ERR(pdata->ioaddr); |
240 | |||
241 | pdata->ioaddr = devm_ioremap(&pdev->dev, res->start, size); | ||
242 | if (!pdata->ioaddr) | ||
243 | return -ENOMEM; | ||
244 | 235 | ||
245 | pdata->clk = devm_clk_get(&pdev->dev, NULL); | 236 | pdata->clk = devm_clk_get(&pdev->dev, NULL); |
246 | /* Not all SoCs require a clock.*/ | 237 | /* Not all SoCs require a clock.*/ |