regulator: wm831x-dcdc: set_current_limit should select the maximum current in specific range

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

1 files changed, 5 insertions, 6 deletions

diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c
index 7413885be01b..90cbcc683704 100644
--- a/drivers/regulator/wm831x-dcdc.c
+++ b/drivers/regulator/wm831x-dcdc.c
@@ -339,16 +339,15 @@ static int wm831x_buckv_set_current_limit(struct regulator_dev *rdev,
         u16 reg = dcdc->base + WM831X_DCDC_CONTROL_2;
         int i;
 
-        for (i = 0; i < ARRAY_SIZE(wm831x_dcdc_ilim); i++) {
+        for (i = ARRAY_SIZE(wm831x_dcdc_ilim) - 1; i >= 0; i--) {
                 if ((min_uA <= wm831x_dcdc_ilim[i]) &&
                     (wm831x_dcdc_ilim[i] <= max_uA))
-                        break;
+                        return wm831x_set_bits(wm831x, reg,
+                                               WM831X_DC1_HC_THR_MASK,
+                                                i << WM831X_DC1_HC_THR_SHIFT);
         }
-        if (i == ARRAY_SIZE(wm831x_dcdc_ilim))
-                return -EINVAL;
 
-        return wm831x_set_bits(wm831x, reg, WM831X_DC1_HC_THR_MASK,
-                               i << WM831X_DC1_HC_THR_SHIFT);
+        return -EINVAL;
 }
 
 static int wm831x_buckv_get_current_limit(struct regulator_dev *rdev)