aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/power/power_supply_sysfs.c
diff options
context:
space:
mode:
authorDaniel Mack <daniel@caiaq.de>2010-05-24 20:39:45 -0400
committerAnton Vorontsov <cbouatmailru@gmail.com>2010-05-25 05:52:58 -0400
commitbbabb158f0e9d41174ae5c2183a8e4f981daf6ce (patch)
tree257637b9c8bad8a95e32d3a857bb0268ae9822b2 /drivers/power/power_supply_sysfs.c
parent24af3202459d9a25643009b1ab8ab5ff04d94b49 (diff)
power_supply: Fix regression for 'type' property
Commit 5f487cd34f4337f9bc27ca19da72a39d1b0a0ab4 (power_supply: Use attribute groups) causes a regression the power supply core does not export the 'type' attribute anymore. POWER_SUPPLY_PROP_TYPE is handled by the power supply core without the low-level driver, so power_supply_attr_is_visible() must always return the entry as readable. Reported-by: Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by: Daniel Mack <daniel@caiaq.de> Tested-by: Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Diffstat (limited to 'drivers/power/power_supply_sysfs.c')
-rw-r--r--drivers/power/power_supply_sysfs.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 6a86cdfd79fa..9d30eeb8c810 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -179,14 +179,16 @@ static mode_t power_supply_attr_is_visible(struct kobject *kobj,
179{ 179{
180 struct device *dev = container_of(kobj, struct device, kobj); 180 struct device *dev = container_of(kobj, struct device, kobj);
181 struct power_supply *psy = dev_get_drvdata(dev); 181 struct power_supply *psy = dev_get_drvdata(dev);
182 mode_t mode = S_IRUSR | S_IRGRP | S_IROTH;
182 int i; 183 int i;
183 184
185 if (attrno == POWER_SUPPLY_PROP_TYPE)
186 return mode;
187
184 for (i = 0; i < psy->num_properties; i++) { 188 for (i = 0; i < psy->num_properties; i++) {
185 int property = psy->properties[i]; 189 int property = psy->properties[i];
186 190
187 if (property == attrno) { 191 if (property == attrno) {
188 mode_t mode = S_IRUSR | S_IRGRP | S_IROTH;
189
190 if (psy->property_is_writeable && 192 if (psy->property_is_writeable &&
191 psy->property_is_writeable(psy, property) > 0) 193 psy->property_is_writeable(psy, property) > 0)
192 mode |= S_IWUSR; 194 mode |= S_IWUSR;