aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/platform
diff options
context:
space:
mode:
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>2014-06-01 08:58:52 -0400
committerMatthew Garrett <matthew.garrett@nebula.com>2014-06-10 19:11:08 -0400
commit8ad3be1eacbe252b93f5a0478413774308f3dbfb (patch)
treec25b9fe27facb4cc8689b4328ac72ce063a9d8d9 /drivers/platform
parent14627e36121c90b9a794ab0ea3195efa4c23373e (diff)
platform: x86: asus-wmi.c: Cleaning up uninitialized variables
There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/asus-wmi.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 91ef69a52263..3c6ccedc82b6 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -266,7 +266,7 @@ static int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1,
266 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; 266 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
267 acpi_status status; 267 acpi_status status;
268 union acpi_object *obj; 268 union acpi_object *obj;
269 u32 tmp; 269 u32 tmp = 0;
270 270
271 status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1, method_id, 271 status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1, method_id,
272 &input, &output); 272 &input, &output);
@@ -277,8 +277,6 @@ static int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1,
277 obj = (union acpi_object *)output.pointer; 277 obj = (union acpi_object *)output.pointer;
278 if (obj && obj->type == ACPI_TYPE_INTEGER) 278 if (obj && obj->type == ACPI_TYPE_INTEGER)
279 tmp = (u32) obj->integer.value; 279 tmp = (u32) obj->integer.value;
280 else
281 tmp = 0;
282 280
283 if (retval) 281 if (retval)
284 *retval = tmp; 282 *retval = tmp;