diff options
| author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-01-10 09:27:08 -0500 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-01-14 14:14:25 -0500 |
| commit | 8b9ec1da6a310b438516468c669a7e1be046b18c (patch) | |
| tree | e944d9d21bba1f2f90ff48f0bd9b467b9f3ee270 /drivers/platform/x86 | |
| parent | c4ec84c7db0e4b01ed40cc2388f16ae5c6513cc0 (diff) | |
platform / x86: Use global PCI rescan-remove locking
Multiple race conditions are possible between the rfkill hotplug in the
asus-wmi and eeepc-laptop drivers and the generic PCI bus rescan and device
removal that can be triggered via sysfs.
To avoid those race conditions make asus-wmi and eeepc-laptop use global
PCI rescan-remove locking around the rfkill hotplug.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/platform/x86')
| -rw-r--r-- | drivers/platform/x86/asus-wmi.c | 2 | ||||
| -rw-r--r-- | drivers/platform/x86/eeepc-laptop.c | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 19c313b056c3..6fe268f6af91 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c | |||
| @@ -606,6 +606,7 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus) | |||
| 606 | mutex_unlock(&asus->wmi_lock); | 606 | mutex_unlock(&asus->wmi_lock); |
| 607 | 607 | ||
| 608 | mutex_lock(&asus->hotplug_lock); | 608 | mutex_lock(&asus->hotplug_lock); |
| 609 | pci_lock_rescan_remove(); | ||
| 609 | 610 | ||
| 610 | if (asus->wlan.rfkill) | 611 | if (asus->wlan.rfkill) |
| 611 | rfkill_set_sw_state(asus->wlan.rfkill, blocked); | 612 | rfkill_set_sw_state(asus->wlan.rfkill, blocked); |
| @@ -656,6 +657,7 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus) | |||
| 656 | } | 657 | } |
| 657 | 658 | ||
| 658 | out_unlock: | 659 | out_unlock: |
| 660 | pci_unlock_rescan_remove(); | ||
| 659 | mutex_unlock(&asus->hotplug_lock); | 661 | mutex_unlock(&asus->hotplug_lock); |
| 660 | } | 662 | } |
| 661 | 663 | ||
diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index aefcc32e5634..538521b00948 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c | |||
| @@ -592,6 +592,7 @@ static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle) | |||
| 592 | rfkill_set_sw_state(eeepc->wlan_rfkill, blocked); | 592 | rfkill_set_sw_state(eeepc->wlan_rfkill, blocked); |
| 593 | 593 | ||
| 594 | mutex_lock(&eeepc->hotplug_lock); | 594 | mutex_lock(&eeepc->hotplug_lock); |
| 595 | pci_lock_rescan_remove(); | ||
| 595 | 596 | ||
| 596 | if (eeepc->hotplug_slot) { | 597 | if (eeepc->hotplug_slot) { |
| 597 | port = acpi_get_pci_dev(handle); | 598 | port = acpi_get_pci_dev(handle); |
| @@ -649,6 +650,7 @@ out_put_dev: | |||
| 649 | } | 650 | } |
| 650 | 651 | ||
| 651 | out_unlock: | 652 | out_unlock: |
| 653 | pci_unlock_rescan_remove(); | ||
| 652 | mutex_unlock(&eeepc->hotplug_lock); | 654 | mutex_unlock(&eeepc->hotplug_lock); |
| 653 | } | 655 | } |
| 654 | 656 | ||
