diff options
author | Stephen Boyd <sboyd@codeaurora.org> | 2014-03-07 01:44:44 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2014-03-12 10:12:28 -0400 |
commit | 7cc34e2e1a003bc7002868f51678d6fc6e7aeb85 (patch) | |
tree | 8d9fb316e39fc4adc2ea3c290e45812bdd65d96b /drivers/pinctrl | |
parent | 5f2449d0228048a4c7103672187126c5c7d78d08 (diff) |
pinctrl: msm: Replace lookup tables with math
We don't need to waste space with these lookup tables, just do
the math directly.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r-- | drivers/pinctrl/pinctrl-msm.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c index b6eb88cf124f..4527e8d1ea9a 100644 --- a/drivers/pinctrl/pinctrl-msm.c +++ b/drivers/pinctrl/pinctrl-msm.c | |||
@@ -263,8 +263,10 @@ static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin, | |||
263 | #define MSM_PULL_DOWN 1 | 263 | #define MSM_PULL_DOWN 1 |
264 | #define MSM_PULL_UP 3 | 264 | #define MSM_PULL_UP 3 |
265 | 265 | ||
266 | static const unsigned msm_regval_to_drive[] = { 2, 4, 6, 8, 10, 12, 14, 16 }; | 266 | static unsigned msm_regval_to_drive(u32 val) |
267 | static const unsigned msm_drive_to_regval[] = { -1, -1, 0, -1, 1, -1, 2, -1, 3, -1, 4, -1, 5, -1, 6, -1, 7 }; | 267 | { |
268 | return (val + 1) * 2; | ||
269 | } | ||
268 | 270 | ||
269 | static int msm_config_group_get(struct pinctrl_dev *pctldev, | 271 | static int msm_config_group_get(struct pinctrl_dev *pctldev, |
270 | unsigned int group, | 272 | unsigned int group, |
@@ -301,7 +303,7 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev, | |||
301 | arg = arg == MSM_PULL_UP; | 303 | arg = arg == MSM_PULL_UP; |
302 | break; | 304 | break; |
303 | case PIN_CONFIG_DRIVE_STRENGTH: | 305 | case PIN_CONFIG_DRIVE_STRENGTH: |
304 | arg = msm_regval_to_drive[arg]; | 306 | arg = msm_regval_to_drive(arg); |
305 | break; | 307 | break; |
306 | case PIN_CONFIG_OUTPUT: | 308 | case PIN_CONFIG_OUTPUT: |
307 | /* Pin is not output */ | 309 | /* Pin is not output */ |
@@ -362,10 +364,10 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev, | |||
362 | break; | 364 | break; |
363 | case PIN_CONFIG_DRIVE_STRENGTH: | 365 | case PIN_CONFIG_DRIVE_STRENGTH: |
364 | /* Check for invalid values */ | 366 | /* Check for invalid values */ |
365 | if (arg >= ARRAY_SIZE(msm_drive_to_regval)) | 367 | if (arg > 16 || arg < 2 || (arg % 2) != 0) |
366 | arg = -1; | 368 | arg = -1; |
367 | else | 369 | else |
368 | arg = msm_drive_to_regval[arg]; | 370 | arg = (arg / 2) - 1; |
369 | break; | 371 | break; |
370 | case PIN_CONFIG_OUTPUT: | 372 | case PIN_CONFIG_OUTPUT: |
371 | /* set output value */ | 373 | /* set output value */ |
@@ -558,7 +560,7 @@ static void msm_gpio_dbg_show_one(struct seq_file *s, | |||
558 | pull = (ctl_reg >> g->pull_bit) & 3; | 560 | pull = (ctl_reg >> g->pull_bit) & 3; |
559 | 561 | ||
560 | seq_printf(s, " %-8s: %-3s %d", g->name, is_out ? "out" : "in", func); | 562 | seq_printf(s, " %-8s: %-3s %d", g->name, is_out ? "out" : "in", func); |
561 | seq_printf(s, " %dmA", msm_regval_to_drive[drive]); | 563 | seq_printf(s, " %dmA", msm_regval_to_drive(drive)); |
562 | seq_printf(s, " %s", pulls[pull]); | 564 | seq_printf(s, " %s", pulls[pull]); |
563 | } | 565 | } |
564 | 566 | ||