aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pcmcia/ds.c
diff options
context:
space:
mode:
authorDominik Brodowski <linux@dominikbrodowski.net>2005-09-28 13:41:56 -0400
committerDominik Brodowski <linux@dominikbrodowski.net>2006-01-05 17:41:14 -0500
commitde75914ee103a30d82ad21b39b7e04f70e4fa1f0 (patch)
tree492f275d49d2e37449ba89594127ebca8502cb3f /drivers/pcmcia/ds.c
parent9da4bc6d6a38c1c3d850c046d0aee324c1a2e52a (diff)
[PATCH] pcmcia: validate_mem shouldn't be void
Add a return value to pcmcia_validate_mem. Only if we have enough memory available to map the CIS, we should proceed in trying to determine information about the device. Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/pcmcia/ds.c')
-rw-r--r--drivers/pcmcia/ds.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 6fb76399547e..b120794c03a9 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -583,7 +583,9 @@ static int pcmcia_card_add(struct pcmcia_socket *s)
583 if (!(s->resource_setup_done)) 583 if (!(s->resource_setup_done))
584 return -EAGAIN; /* try again, but later... */ 584 return -EAGAIN; /* try again, but later... */
585 585
586 pcmcia_validate_mem(s); 586 if (pcmcia_validate_mem(s))
587 return -EAGAIN; /* try again, but later... */
588
587 ret = pccard_validate_cis(s, BIND_FN_ALL, &cisinfo); 589 ret = pccard_validate_cis(s, BIND_FN_ALL, &cisinfo);
588 if (ret || !cisinfo.Chains) { 590 if (ret || !cisinfo.Chains) {
589 ds_dbg(0, "invalid CIS or invalid resources\n"); 591 ds_dbg(0, "invalid CIS or invalid resources\n");