diff options
author | Wolfram Sang <w.sang@pengutronix.de> | 2009-07-20 04:58:59 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-09-15 13:17:16 -0400 |
commit | b4b3d7bbe1e1d924dc5f3b48b6c06977aee2d494 (patch) | |
tree | a63a04b5a6f24d4ba80c7af4d25379d505a8844f /drivers/pcmcia/ds.c | |
parent | d598de02187e4de89595537f69dffe8334f9a066 (diff) |
pcmcia: fix incorrect argument order to list_add_tail()
Commit a56bc69a182f501582557af7fad5bc882b1c856c fixed a wrong usage of
list_add_tail() within store_new_id() for PCI. Port the fix to PCMCIA,
which adapted this function from PCI.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/pcmcia/ds.c')
-rw-r--r-- | drivers/pcmcia/ds.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c index 304ff6d5cf3b..9f300d3cb125 100644 --- a/drivers/pcmcia/ds.c +++ b/drivers/pcmcia/ds.c | |||
@@ -236,7 +236,6 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count) | |||
236 | if (!dynid) | 236 | if (!dynid) |
237 | return -ENOMEM; | 237 | return -ENOMEM; |
238 | 238 | ||
239 | INIT_LIST_HEAD(&dynid->node); | ||
240 | dynid->id.match_flags = match_flags; | 239 | dynid->id.match_flags = match_flags; |
241 | dynid->id.manf_id = manf_id; | 240 | dynid->id.manf_id = manf_id; |
242 | dynid->id.card_id = card_id; | 241 | dynid->id.card_id = card_id; |
@@ -246,7 +245,7 @@ pcmcia_store_new_id(struct device_driver *driver, const char *buf, size_t count) | |||
246 | memcpy(dynid->id.prod_id_hash, prod_id_hash, sizeof(__u32) * 4); | 245 | memcpy(dynid->id.prod_id_hash, prod_id_hash, sizeof(__u32) * 4); |
247 | 246 | ||
248 | spin_lock(&pdrv->dynids.lock); | 247 | spin_lock(&pdrv->dynids.lock); |
249 | list_add_tail(&pdrv->dynids.list, &dynid->node); | 248 | list_add_tail(&dynid->node, &pdrv->dynids.list); |
250 | spin_unlock(&pdrv->dynids.lock); | 249 | spin_unlock(&pdrv->dynids.lock); |
251 | 250 | ||
252 | if (get_driver(&pdrv->drv)) { | 251 | if (get_driver(&pdrv->drv)) { |