Merge branch 'pci/misc' into next

* pci/misc:
  PCI: Warn on driver probe return value greater than zero
  PCI: Drop warning about drivers that don't use pci_set_master()
  PCI: Workaround missing pci_set_master in pci drivers
  PCI: Update pcie_ports 'auto' behavior for non-ACPI platforms

1 files changed, 10 insertions, 2 deletions

diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 840fdc5ba0d8..454853507b7e 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -267,11 +267,19 @@ static long local_pci_probe(void *_ddi)
         pm_runtime_get_sync(dev);
         pci_dev->driver = pci_drv;
         rc = pci_drv->probe(pci_dev, ddi->id);
-        if (rc) {
+        if (!rc)
+                return rc;
+        if (rc < 0) {
                 pci_dev->driver = NULL;
                 pm_runtime_put_sync(dev);
+                return rc;
         }
-        return rc;
+        /*
+         * Probe function should return < 0 for failure, 0 for success
+         * Treat values > 0 as success, but warn.
+         */
+        dev_warn(dev, "Driver probe function unexpectedly returned %d\n", rc);
+        return 0;
 }
 
 static int pci_call_probe(struct pci_driver *drv, struct pci_dev *dev,