diff options
author | Ryan Desfosses <ryan@desfo.org> | 2014-04-18 20:13:50 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-06-10 22:20:42 -0400 |
commit | 227f06470502c4fea3d93df1f12a77e3e37f6263 (patch) | |
tree | 817a80fa89d17305a47a3e4e4012d36ae6cac36c /drivers/pci/hotplug | |
parent | 3c78bc61f5ef3bc87e7f94f67ec737d2273f120b (diff) |
PCI: Merge multi-line quoted strings
Merge quoted strings that are broken across lines into a single entity.
The compiler merges them anyway, but checkpatch complains about it, and
merging them makes it easier to grep for strings.
No functional change.
[bhelgaas: changelog, do the same for everything under drivers/pci]
Signed-off-by: Ryan Desfosses <ryan@desfo.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/hotplug')
-rw-r--r-- | drivers/pci/hotplug/acpiphp_glue.c | 6 | ||||
-rw-r--r-- | drivers/pci/hotplug/cpqphp_core.c | 6 | ||||
-rw-r--r-- | drivers/pci/hotplug/ibmphp_core.c | 12 | ||||
-rw-r--r-- | drivers/pci/hotplug/ibmphp_pci.c | 32 | ||||
-rw-r--r-- | drivers/pci/hotplug/ibmphp_res.c | 3 | ||||
-rw-r--r-- | drivers/pci/hotplug/pci_hotplug_core.c | 3 | ||||
-rw-r--r-- | drivers/pci/hotplug/pciehp_core.c | 3 | ||||
-rw-r--r-- | drivers/pci/hotplug/pciehp_ctrl.c | 14 | ||||
-rw-r--r-- | drivers/pci/hotplug/pciehp_hpc.c | 6 | ||||
-rw-r--r-- | drivers/pci/hotplug/pciehp_pci.c | 5 | ||||
-rw-r--r-- | drivers/pci/hotplug/sgi_hotplug.c | 33 | ||||
-rw-r--r-- | drivers/pci/hotplug/shpchp_core.c | 3 | ||||
-rw-r--r-- | drivers/pci/hotplug/shpchp_ctrl.c | 34 | ||||
-rw-r--r-- | drivers/pci/hotplug/shpchp_hpc.c | 17 | ||||
-rw-r--r-- | drivers/pci/hotplug/shpchp_pci.c | 6 |
15 files changed, 71 insertions, 112 deletions
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 75e178330215..772d8766338a 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c | |||
@@ -351,11 +351,9 @@ static acpi_status acpiphp_add_context(acpi_handle handle, u32 lvl, void *data, | |||
351 | slot->slot = NULL; | 351 | slot->slot = NULL; |
352 | bridge->nr_slots--; | 352 | bridge->nr_slots--; |
353 | if (retval == -EBUSY) | 353 | if (retval == -EBUSY) |
354 | pr_warn("Slot %llu already registered by another " | 354 | pr_warn("Slot %llu already registered by another hotplug driver\n", sun); |
355 | "hotplug driver\n", sun); | ||
356 | else | 355 | else |
357 | pr_warn("acpiphp_register_hotplug_slot failed " | 356 | pr_warn("acpiphp_register_hotplug_slot failed (err code = 0x%x)\n", retval); |
358 | "(err code = 0x%x)\n", retval); | ||
359 | } | 357 | } |
360 | /* Even if the slot registration fails, we can still use it. */ | 358 | /* Even if the slot registration fails, we can still use it. */ |
361 | } | 359 | } |
diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c index 868e62fc869b..4aaee746df88 100644 --- a/drivers/pci/hotplug/cpqphp_core.c +++ b/drivers/pci/hotplug/cpqphp_core.c | |||
@@ -706,8 +706,7 @@ static int ctrl_slot_setup(struct controller *ctrl, | |||
706 | hotplug_slot_info->adapter_status = | 706 | hotplug_slot_info->adapter_status = |
707 | get_presence_status(ctrl, slot); | 707 | get_presence_status(ctrl, slot); |
708 | 708 | ||
709 | dbg("registering bus %d, dev %d, number %d, " | 709 | dbg("registering bus %d, dev %d, number %d, ctrl->slot_device_offset %d, slot %d\n", |
710 | "ctrl->slot_device_offset %d, slot %d\n", | ||
711 | slot->bus, slot->device, | 710 | slot->bus, slot->device, |
712 | slot->number, ctrl->slot_device_offset, | 711 | slot->number, ctrl->slot_device_offset, |
713 | slot_number); | 712 | slot_number); |
@@ -837,8 +836,7 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
837 | 836 | ||
838 | bus = pdev->subordinate; | 837 | bus = pdev->subordinate; |
839 | if (!bus) { | 838 | if (!bus) { |
840 | dev_notice(&pdev->dev, "the device is not a bridge, " | 839 | dev_notice(&pdev->dev, "the device is not a bridge, skipping\n"); |
841 | "skipping\n"); | ||
842 | rc = -ENODEV; | 840 | rc = -ENODEV; |
843 | goto err_disable_device; | 841 | goto err_disable_device; |
844 | } | 842 | } |
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c index 5794057f7ec1..f7b8684a7739 100644 --- a/drivers/pci/hotplug/ibmphp_core.c +++ b/drivers/pci/hotplug/ibmphp_core.c | |||
@@ -1045,8 +1045,7 @@ static int enable_slot(struct hotplug_slot *hs) | |||
1045 | rc = check_limitations(slot_cur); | 1045 | rc = check_limitations(slot_cur); |
1046 | if (rc) { | 1046 | if (rc) { |
1047 | err("Adding this card exceeds the limitations of this bus.\n"); | 1047 | err("Adding this card exceeds the limitations of this bus.\n"); |
1048 | err("(i.e., >1 133MHz cards running on same bus, or " | 1048 | err("(i.e., >1 133MHz cards running on same bus, or >2 66 PCI cards running on same bus.\n"); |
1049 | ">2 66 PCI cards running on same bus.\n"); | ||
1050 | err("Try hot-adding into another bus\n"); | 1049 | err("Try hot-adding into another bus\n"); |
1051 | rc = -EINVAL; | 1050 | rc = -EINVAL; |
1052 | goto error_nopower; | 1051 | goto error_nopower; |
@@ -1070,12 +1069,10 @@ static int enable_slot(struct hotplug_slot *hs) | |||
1070 | !(SLOT_PWRGD(slot_cur->status))) | 1069 | !(SLOT_PWRGD(slot_cur->status))) |
1071 | err("power fault occurred trying to power up\n"); | 1070 | err("power fault occurred trying to power up\n"); |
1072 | else if (SLOT_BUS_SPEED(slot_cur->status)) { | 1071 | else if (SLOT_BUS_SPEED(slot_cur->status)) { |
1073 | err("bus speed mismatch occurred. please check " | 1072 | err("bus speed mismatch occurred. please check current bus speed and card capability\n"); |
1074 | "current bus speed and card capability\n"); | ||
1075 | print_card_capability(slot_cur); | 1073 | print_card_capability(slot_cur); |
1076 | } else if (SLOT_BUS_MODE(slot_cur->ext_status)) { | 1074 | } else if (SLOT_BUS_MODE(slot_cur->ext_status)) { |
1077 | err("bus mode mismatch occurred. please check " | 1075 | err("bus mode mismatch occurred. please check current bus mode and card capability\n"); |
1078 | "current bus mode and card capability\n"); | ||
1079 | print_card_capability(slot_cur); | 1076 | print_card_capability(slot_cur); |
1080 | } | 1077 | } |
1081 | ibmphp_update_slot_info(slot_cur); | 1078 | ibmphp_update_slot_info(slot_cur); |
@@ -1098,8 +1095,7 @@ static int enable_slot(struct hotplug_slot *hs) | |||
1098 | goto error_power; | 1095 | goto error_power; |
1099 | } | 1096 | } |
1100 | if (SLOT_POWER(slot_cur->status) && (SLOT_BUS_SPEED(slot_cur->status))) { | 1097 | if (SLOT_POWER(slot_cur->status) && (SLOT_BUS_SPEED(slot_cur->status))) { |
1101 | err("bus speed mismatch occurred. please check current bus " | 1098 | err("bus speed mismatch occurred. please check current bus speed and card capability\n"); |
1102 | "speed and card capability\n"); | ||
1103 | print_card_capability(slot_cur); | 1099 | print_card_capability(slot_cur); |
1104 | goto error_power; | 1100 | goto error_power; |
1105 | } | 1101 | } |
diff --git a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c index f53b7c5b9a3f..2fd296706ce7 100644 --- a/drivers/pci/hotplug/ibmphp_pci.c +++ b/drivers/pci/hotplug/ibmphp_pci.c | |||
@@ -137,8 +137,8 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno) | |||
137 | "Please choose another device.\n", cur_func->device); | 137 | "Please choose another device.\n", cur_func->device); |
138 | return -ENODEV; | 138 | return -ENODEV; |
139 | } else if (class == PCI_CLASS_DISPLAY_VGA) { | 139 | } else if (class == PCI_CLASS_DISPLAY_VGA) { |
140 | err ("The device %x is not supported for hot plugging. " | 140 | err ("The device %x is not supported for hot plugging. Please choose another device.\n", |
141 | "Please choose another device.\n", cur_func->device); | 141 | cur_func->device); |
142 | return -ENODEV; | 142 | return -ENODEV; |
143 | } | 143 | } |
144 | switch (hdr_type) { | 144 | switch (hdr_type) { |
@@ -179,8 +179,8 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno) | |||
179 | case PCI_HEADER_TYPE_MULTIBRIDGE: | 179 | case PCI_HEADER_TYPE_MULTIBRIDGE: |
180 | class >>= 8; | 180 | class >>= 8; |
181 | if (class != PCI_CLASS_BRIDGE_PCI) { | 181 | if (class != PCI_CLASS_BRIDGE_PCI) { |
182 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. " | 182 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. Please insert another card.\n", |
183 | "Please insert another card.\n", cur_func->device); | 183 | cur_func->device); |
184 | return -ENODEV; | 184 | return -ENODEV; |
185 | } | 185 | } |
186 | assign_alt_irq (cur_func, class_code); | 186 | assign_alt_irq (cur_func, class_code); |
@@ -247,8 +247,8 @@ int ibmphp_configure_card (struct pci_func *func, u8 slotno) | |||
247 | class >>= 8; | 247 | class >>= 8; |
248 | debug ("class now is %x\n", class); | 248 | debug ("class now is %x\n", class); |
249 | if (class != PCI_CLASS_BRIDGE_PCI) { | 249 | if (class != PCI_CLASS_BRIDGE_PCI) { |
250 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. " | 250 | err ("This %x is not PCI-to-PCI bridge, and as is not supported for hot-plugging. Please insert another card.\n", |
251 | "Please insert another card.\n", cur_func->device); | 251 | cur_func->device); |
252 | return -ENODEV; | 252 | return -ENODEV; |
253 | } | 253 | } |
254 | 254 | ||
@@ -1125,13 +1125,11 @@ static struct res_needed *scan_behind_bridge (struct pci_func *func, u8 busno) | |||
1125 | 1125 | ||
1126 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ | 1126 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ |
1127 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { | 1127 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { |
1128 | err ("The device %x is VGA compatible and as is not supported for hot plugging. " | 1128 | err ("The device %x is VGA compatible and as is not supported for hot plugging. Please choose another device.\n", device); |
1129 | "Please choose another device.\n", device); | ||
1130 | amount->not_correct = 1; | 1129 | amount->not_correct = 1; |
1131 | return amount; | 1130 | return amount; |
1132 | } else if (class == PCI_CLASS_DISPLAY_VGA) { | 1131 | } else if (class == PCI_CLASS_DISPLAY_VGA) { |
1133 | err ("The device %x is not supported for hot plugging. " | 1132 | err ("The device %x is not supported for hot plugging. Please choose another device.\n", device); |
1134 | "Please choose another device.\n", device); | ||
1135 | amount->not_correct = 1; | 1133 | amount->not_correct = 1; |
1136 | return amount; | 1134 | return amount; |
1137 | } | 1135 | } |
@@ -1483,12 +1481,10 @@ static int unconfigure_boot_card (struct slot *slot_cur) | |||
1483 | debug ("hdr_type %x, class %x\n", hdr_type, class); | 1481 | debug ("hdr_type %x, class %x\n", hdr_type, class); |
1484 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ | 1482 | class >>= 8; /* to take revision out, class = class.subclass.prog i/f */ |
1485 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { | 1483 | if (class == PCI_CLASS_NOT_DEFINED_VGA) { |
1486 | err ("The device %x function %x is VGA compatible and is not supported for hot removing. " | 1484 | err ("The device %x function %x is VGA compatible and is not supported for hot removing. Please choose another device.\n", device, function); |
1487 | "Please choose another device.\n", device, function); | ||
1488 | return -ENODEV; | 1485 | return -ENODEV; |
1489 | } else if (class == PCI_CLASS_DISPLAY_VGA) { | 1486 | } else if (class == PCI_CLASS_DISPLAY_VGA) { |
1490 | err ("The device %x function %x is not supported for hot removing. " | 1487 | err ("The device %x function %x is not supported for hot removing. Please choose another device.\n", device, function); |
1491 | "Please choose another device.\n", device, function); | ||
1492 | return -ENODEV; | 1488 | return -ENODEV; |
1493 | } | 1489 | } |
1494 | 1490 | ||
@@ -1513,9 +1509,7 @@ static int unconfigure_boot_card (struct slot *slot_cur) | |||
1513 | case PCI_HEADER_TYPE_BRIDGE: | 1509 | case PCI_HEADER_TYPE_BRIDGE: |
1514 | class >>= 8; | 1510 | class >>= 8; |
1515 | if (class != PCI_CLASS_BRIDGE_PCI) { | 1511 | if (class != PCI_CLASS_BRIDGE_PCI) { |
1516 | err ("This device %x function %x is not PCI-to-PCI bridge, " | 1512 | err ("This device %x function %x is not PCI-to-PCI bridge, and is not supported for hot-removing. Please try another card.\n", device, function); |
1517 | "and is not supported for hot-removing. " | ||
1518 | "Please try another card.\n", device, function); | ||
1519 | return -ENODEV; | 1513 | return -ENODEV; |
1520 | } | 1514 | } |
1521 | rc = unconfigure_boot_bridge (busno, device, function); | 1515 | rc = unconfigure_boot_bridge (busno, device, function); |
@@ -1529,9 +1523,7 @@ static int unconfigure_boot_card (struct slot *slot_cur) | |||
1529 | case PCI_HEADER_TYPE_MULTIBRIDGE: | 1523 | case PCI_HEADER_TYPE_MULTIBRIDGE: |
1530 | class >>= 8; | 1524 | class >>= 8; |
1531 | if (class != PCI_CLASS_BRIDGE_PCI) { | 1525 | if (class != PCI_CLASS_BRIDGE_PCI) { |
1532 | err ("This device %x function %x is not PCI-to-PCI bridge, " | 1526 | err ("This device %x function %x is not PCI-to-PCI bridge, and is not supported for hot-removing. Please try another card.\n", device, function); |
1533 | "and is not supported for hot-removing. " | ||
1534 | "Please try another card.\n", device, function); | ||
1535 | return -ENODEV; | 1527 | return -ENODEV; |
1536 | } | 1528 | } |
1537 | rc = unconfigure_boot_bridge (busno, device, function); | 1529 | rc = unconfigure_boot_bridge (busno, device, function); |
diff --git a/drivers/pci/hotplug/ibmphp_res.c b/drivers/pci/hotplug/ibmphp_res.c index f62dfc40f753..f34745abd5b6 100644 --- a/drivers/pci/hotplug/ibmphp_res.c +++ b/drivers/pci/hotplug/ibmphp_res.c | |||
@@ -789,8 +789,7 @@ int ibmphp_remove_resource (struct resource_node *res) | |||
789 | bus_cur = find_bus_wprev (res->busno, NULL, 0); | 789 | bus_cur = find_bus_wprev (res->busno, NULL, 0); |
790 | 790 | ||
791 | if (!bus_cur) { | 791 | if (!bus_cur) { |
792 | err ("cannot find corresponding bus of the io resource to remove " | 792 | err ("cannot find corresponding bus of the io resource to remove bailing out...\n"); |
793 | "bailing out...\n"); | ||
794 | return -ENODEV; | 793 | return -ENODEV; |
795 | } | 794 | } |
796 | 795 | ||
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index 29caef96a21c..56d8486dc167 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c | |||
@@ -432,8 +432,7 @@ int __pci_hp_register(struct hotplug_slot *slot, struct pci_bus *bus, | |||
432 | if ((slot->info == NULL) || (slot->ops == NULL)) | 432 | if ((slot->info == NULL) || (slot->ops == NULL)) |
433 | return -EINVAL; | 433 | return -EINVAL; |
434 | if (slot->release == NULL) { | 434 | if (slot->release == NULL) { |
435 | dbg("Why are you trying to register a hotplug slot " | 435 | dbg("Why are you trying to register a hotplug slot without a proper release function?\n"); |
436 | "without a proper release function?\n"); | ||
437 | return -EINVAL; | 436 | return -EINVAL; |
438 | } | 437 | } |
439 | 438 | ||
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 96bb617e4de5..a2297db80813 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c | |||
@@ -266,8 +266,7 @@ static int pciehp_probe(struct pcie_device *dev) | |||
266 | rc = init_slot(ctrl); | 266 | rc = init_slot(ctrl); |
267 | if (rc) { | 267 | if (rc) { |
268 | if (rc == -EBUSY) | 268 | if (rc == -EBUSY) |
269 | ctrl_warn(ctrl, "Slot already registered by another " | 269 | ctrl_warn(ctrl, "Slot already registered by another hotplug driver\n"); |
270 | "hotplug driver\n"); | ||
271 | else | 270 | else |
272 | ctrl_err(ctrl, "Slot initialization failed\n"); | 271 | ctrl_err(ctrl, "Slot initialization failed\n"); |
273 | goto err_out_release_ctlr; | 272 | goto err_out_release_ctlr; |
diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c index c57463e1d756..ff32e85e1de6 100644 --- a/drivers/pci/hotplug/pciehp_ctrl.c +++ b/drivers/pci/hotplug/pciehp_ctrl.c | |||
@@ -376,14 +376,12 @@ static void handle_button_press_event(struct slot *p_slot) | |||
376 | pciehp_get_power_status(p_slot, &getstatus); | 376 | pciehp_get_power_status(p_slot, &getstatus); |
377 | if (getstatus) { | 377 | if (getstatus) { |
378 | p_slot->state = BLINKINGOFF_STATE; | 378 | p_slot->state = BLINKINGOFF_STATE; |
379 | ctrl_info(ctrl, | 379 | ctrl_info(ctrl, "PCI slot #%s - powering off due to button press\n", |
380 | "PCI slot #%s - powering off due to button " | 380 | slot_name(p_slot)); |
381 | "press.\n", slot_name(p_slot)); | ||
382 | } else { | 381 | } else { |
383 | p_slot->state = BLINKINGON_STATE; | 382 | p_slot->state = BLINKINGON_STATE; |
384 | ctrl_info(ctrl, | 383 | ctrl_info(ctrl, "PCI slot #%s - powering on due to button press\n", |
385 | "PCI slot #%s - powering on due to button " | 384 | slot_name(p_slot)); |
386 | "press.\n", slot_name(p_slot)); | ||
387 | } | 385 | } |
388 | /* blink green LED and turn off amber */ | 386 | /* blink green LED and turn off amber */ |
389 | pciehp_green_led_blink(p_slot); | 387 | pciehp_green_led_blink(p_slot); |
@@ -404,8 +402,8 @@ static void handle_button_press_event(struct slot *p_slot) | |||
404 | else | 402 | else |
405 | pciehp_green_led_off(p_slot); | 403 | pciehp_green_led_off(p_slot); |
406 | pciehp_set_attention_status(p_slot, 0); | 404 | pciehp_set_attention_status(p_slot, 0); |
407 | ctrl_info(ctrl, "PCI slot #%s - action canceled " | 405 | ctrl_info(ctrl, "PCI slot #%s - action canceled due to button press\n", |
408 | "due to button press\n", slot_name(p_slot)); | 406 | slot_name(p_slot)); |
409 | p_slot->state = STATIC_STATE; | 407 | p_slot->state = STATIC_STATE; |
410 | break; | 408 | break; |
411 | case POWEROFF_STATE: | 409 | case POWEROFF_STATE: |
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 9334fc76b9d1..42914e04d110 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c | |||
@@ -174,12 +174,10 @@ static void pcie_write_cmd(struct controller *ctrl, u16 cmd, u16 mask) | |||
174 | * event even though it supports none of power | 174 | * event even though it supports none of power |
175 | * controller, attention led, power led and EMI. | 175 | * controller, attention led, power led and EMI. |
176 | */ | 176 | */ |
177 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Need to " | 177 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Need to wait for command completed event\n"); |
178 | "wait for command completed event.\n"); | ||
179 | ctrl->no_cmd_complete = 0; | 178 | ctrl->no_cmd_complete = 0; |
180 | } else { | 179 | } else { |
181 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Maybe " | 180 | ctrl_dbg(ctrl, "Unexpected CMD_COMPLETED. Maybe the controller is broken\n"); |
182 | "the controller is broken.\n"); | ||
183 | } | 181 | } |
184 | } | 182 | } |
185 | 183 | ||
diff --git a/drivers/pci/hotplug/pciehp_pci.c b/drivers/pci/hotplug/pciehp_pci.c index b6cb1df67097..5f871f4c4af1 100644 --- a/drivers/pci/hotplug/pciehp_pci.c +++ b/drivers/pci/hotplug/pciehp_pci.c | |||
@@ -46,9 +46,8 @@ int pciehp_configure_device(struct slot *p_slot) | |||
46 | 46 | ||
47 | dev = pci_get_slot(parent, PCI_DEVFN(0, 0)); | 47 | dev = pci_get_slot(parent, PCI_DEVFN(0, 0)); |
48 | if (dev) { | 48 | if (dev) { |
49 | ctrl_err(ctrl, "Device %s already exists " | 49 | ctrl_err(ctrl, "Device %s already exists at %04x:%02x:00, cannot hot-add\n", |
50 | "at %04x:%02x:00, cannot hot-add\n", pci_name(dev), | 50 | pci_name(dev), pci_domain_nr(parent), parent->number); |
51 | pci_domain_nr(parent), parent->number); | ||
52 | pci_dev_put(dev); | 51 | pci_dev_put(dev); |
53 | ret = -EEXIST; | 52 | ret = -EEXIST; |
54 | goto out; | 53 | goto out; |
diff --git a/drivers/pci/hotplug/sgi_hotplug.c b/drivers/pci/hotplug/sgi_hotplug.c index 0f4c36033ade..bada20999870 100644 --- a/drivers/pci/hotplug/sgi_hotplug.c +++ b/drivers/pci/hotplug/sgi_hotplug.c | |||
@@ -250,15 +250,13 @@ static int sn_slot_enable(struct hotplug_slot *bss_hotplug_slot, | |||
250 | } | 250 | } |
251 | 251 | ||
252 | if (rc == PCI_L1_ERR) { | 252 | if (rc == PCI_L1_ERR) { |
253 | dev_dbg(&slot->pci_bus->self->dev, | 253 | dev_dbg(&slot->pci_bus->self->dev, "L1 failure %d with message: %s", |
254 | "L1 failure %d with message: %s", | ||
255 | resp.resp_sub_errno, resp.resp_l1_msg); | 254 | resp.resp_sub_errno, resp.resp_l1_msg); |
256 | return -EPERM; | 255 | return -EPERM; |
257 | } | 256 | } |
258 | 257 | ||
259 | if (rc) { | 258 | if (rc) { |
260 | dev_dbg(&slot->pci_bus->self->dev, | 259 | dev_dbg(&slot->pci_bus->self->dev, "insert failed with error %d sub-error %d\n", |
261 | "insert failed with error %d sub-error %d\n", | ||
262 | rc, resp.resp_sub_errno); | 260 | rc, resp.resp_sub_errno); |
263 | return -EIO; | 261 | return -EIO; |
264 | } | 262 | } |
@@ -288,21 +286,18 @@ static int sn_slot_disable(struct hotplug_slot *bss_hotplug_slot, | |||
288 | } | 286 | } |
289 | 287 | ||
290 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_EMPTY_33MHZ)) { | 288 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_EMPTY_33MHZ)) { |
291 | dev_dbg(&slot->pci_bus->self->dev, | 289 | dev_dbg(&slot->pci_bus->self->dev, "Cannot remove last 33MHz card\n"); |
292 | "Cannot remove last 33MHz card\n"); | ||
293 | return -EPERM; | 290 | return -EPERM; |
294 | } | 291 | } |
295 | 292 | ||
296 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_L1_ERR)) { | 293 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && (rc == PCI_L1_ERR)) { |
297 | dev_dbg(&slot->pci_bus->self->dev, | 294 | dev_dbg(&slot->pci_bus->self->dev, "L1 failure %d with message \n%s\n", |
298 | "L1 failure %d with message \n%s\n", | ||
299 | resp.resp_sub_errno, resp.resp_l1_msg); | 295 | resp.resp_sub_errno, resp.resp_l1_msg); |
300 | return -EPERM; | 296 | return -EPERM; |
301 | } | 297 | } |
302 | 298 | ||
303 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && rc) { | 299 | if ((action == PCI_REQ_SLOT_ELIGIBLE) && rc) { |
304 | dev_dbg(&slot->pci_bus->self->dev, | 300 | dev_dbg(&slot->pci_bus->self->dev, "remove failed with error %d sub-error %d\n", |
305 | "remove failed with error %d sub-error %d\n", | ||
306 | rc, resp.resp_sub_errno); | 301 | rc, resp.resp_sub_errno); |
307 | return -EIO; | 302 | return -EIO; |
308 | } | 303 | } |
@@ -417,8 +412,7 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
417 | phandle = acpi_device_handle(PCI_CONTROLLER(slot->pci_bus)->companion); | 412 | phandle = acpi_device_handle(PCI_CONTROLLER(slot->pci_bus)->companion); |
418 | 413 | ||
419 | if (acpi_bus_get_device(phandle, &pdevice)) { | 414 | if (acpi_bus_get_device(phandle, &pdevice)) { |
420 | dev_dbg(&slot->pci_bus->self->dev, | 415 | dev_dbg(&slot->pci_bus->self->dev, "no parent device, assuming NULL\n"); |
421 | "no parent device, assuming NULL\n"); | ||
422 | pdevice = NULL; | 416 | pdevice = NULL; |
423 | } | 417 | } |
424 | 418 | ||
@@ -447,10 +441,8 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
447 | 441 | ||
448 | ret = acpi_bus_scan(chandle); | 442 | ret = acpi_bus_scan(chandle); |
449 | if (ACPI_FAILURE(ret)) { | 443 | if (ACPI_FAILURE(ret)) { |
450 | printk(KERN_ERR "%s: acpi_bus_scan " | 444 | printk(KERN_ERR "%s: acpi_bus_scan failed (0x%x) for slot %d func %d\n", |
451 | "failed (0x%x) for slot %d " | 445 | __func__, ret, (int)(adr>>16), |
452 | "func %d\n", __func__, | ||
453 | ret, (int)(adr>>16), | ||
454 | (int)(adr&0xffff)); | 446 | (int)(adr&0xffff)); |
455 | /* try to continue on */ | 447 | /* try to continue on */ |
456 | } | 448 | } |
@@ -471,11 +463,9 @@ static int enable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
471 | mutex_unlock(&sn_hotplug_mutex); | 463 | mutex_unlock(&sn_hotplug_mutex); |
472 | 464 | ||
473 | if (rc == 0) | 465 | if (rc == 0) |
474 | dev_dbg(&slot->pci_bus->self->dev, | 466 | dev_dbg(&slot->pci_bus->self->dev, "insert operation successful\n"); |
475 | "insert operation successful\n"); | ||
476 | else | 467 | else |
477 | dev_dbg(&slot->pci_bus->self->dev, | 468 | dev_dbg(&slot->pci_bus->self->dev, "insert operation failed rc = %d\n", rc); |
478 | "insert operation failed rc = %d\n", rc); | ||
479 | 469 | ||
480 | return rc; | 470 | return rc; |
481 | } | 471 | } |
@@ -561,8 +551,7 @@ static int disable_slot(struct hotplug_slot *bss_hotplug_slot) | |||
561 | acpi_status ret; | 551 | acpi_status ret; |
562 | ret = acpi_unload_table_id(ssdt_id); | 552 | ret = acpi_unload_table_id(ssdt_id); |
563 | if (ACPI_FAILURE(ret)) { | 553 | if (ACPI_FAILURE(ret)) { |
564 | printk(KERN_ERR "%s: acpi_unload_table_id " | 554 | printk(KERN_ERR "%s: acpi_unload_table_id failed (0x%x) for id %d\n", |
565 | "failed (0x%x) for id %d\n", | ||
566 | __func__, ret, ssdt_id); | 555 | __func__, ret, ssdt_id); |
567 | /* try to continue on */ | 556 | /* try to continue on */ |
568 | } | 557 | } |
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c index faf13abd5b99..294ef4b10cf1 100644 --- a/drivers/pci/hotplug/shpchp_core.c +++ b/drivers/pci/hotplug/shpchp_core.c | |||
@@ -143,8 +143,7 @@ static int init_slots(struct controller *ctrl) | |||
143 | snprintf(name, SLOT_NAME_SIZE, "%d", slot->number); | 143 | snprintf(name, SLOT_NAME_SIZE, "%d", slot->number); |
144 | hotplug_slot->ops = &shpchp_hotplug_slot_ops; | 144 | hotplug_slot->ops = &shpchp_hotplug_slot_ops; |
145 | 145 | ||
146 | ctrl_dbg(ctrl, "Registering domain:bus:dev=%04x:%02x:%02x " | 146 | ctrl_dbg(ctrl, "Registering domain:bus:dev=%04x:%02x:%02x hp_slot=%x sun=%x slot_device_offset=%x\n", |
147 | "hp_slot=%x sun=%x slot_device_offset=%x\n", | ||
148 | pci_domain_nr(ctrl->pci_dev->subordinate), | 147 | pci_domain_nr(ctrl->pci_dev->subordinate), |
149 | slot->bus, slot->device, slot->hp_slot, slot->number, | 148 | slot->bus, slot->device, slot->hp_slot, slot->number, |
150 | ctrl->slot_device_offset); | 149 | ctrl->slot_device_offset); |
diff --git a/drivers/pci/hotplug/shpchp_ctrl.c b/drivers/pci/hotplug/shpchp_ctrl.c index 90cd75c1a3a7..e57972366c91 100644 --- a/drivers/pci/hotplug/shpchp_ctrl.c +++ b/drivers/pci/hotplug/shpchp_ctrl.c | |||
@@ -196,8 +196,8 @@ static int change_bus_speed(struct controller *ctrl, struct slot *p_slot, | |||
196 | 196 | ||
197 | ctrl_dbg(ctrl, "Change speed to %d\n", speed); | 197 | ctrl_dbg(ctrl, "Change speed to %d\n", speed); |
198 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, speed))) { | 198 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, speed))) { |
199 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command " | 199 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command failed\n", |
200 | "failed\n", __func__); | 200 | __func__); |
201 | return WRONG_BUS_FREQUENCY; | 201 | return WRONG_BUS_FREQUENCY; |
202 | } | 202 | } |
203 | return rc; | 203 | return rc; |
@@ -215,8 +215,8 @@ static int fix_bus_speed(struct controller *ctrl, struct slot *pslot, | |||
215 | */ | 215 | */ |
216 | if (flag) { | 216 | if (flag) { |
217 | if (asp < bsp) { | 217 | if (asp < bsp) { |
218 | ctrl_err(ctrl, "Speed of bus %x and adapter %x " | 218 | ctrl_err(ctrl, "Speed of bus %x and adapter %x mismatch\n", |
219 | "mismatch\n", bsp, asp); | 219 | bsp, asp); |
220 | rc = WRONG_BUS_FREQUENCY; | 220 | rc = WRONG_BUS_FREQUENCY; |
221 | } | 221 | } |
222 | return rc; | 222 | return rc; |
@@ -250,8 +250,7 @@ static int board_added(struct slot *p_slot) | |||
250 | 250 | ||
251 | hp_slot = p_slot->device - ctrl->slot_device_offset; | 251 | hp_slot = p_slot->device - ctrl->slot_device_offset; |
252 | 252 | ||
253 | ctrl_dbg(ctrl, | 253 | ctrl_dbg(ctrl, "%s: p_slot->device, slot_offset, hp_slot = %d, %d ,%d\n", |
254 | "%s: p_slot->device, slot_offset, hp_slot = %d, %d ,%d\n", | ||
255 | __func__, p_slot->device, ctrl->slot_device_offset, hp_slot); | 254 | __func__, p_slot->device, ctrl->slot_device_offset, hp_slot); |
256 | 255 | ||
257 | /* Power on slot without connecting to bus */ | 256 | /* Power on slot without connecting to bus */ |
@@ -263,8 +262,8 @@ static int board_added(struct slot *p_slot) | |||
263 | 262 | ||
264 | if ((ctrl->pci_dev->vendor == 0x8086) && (ctrl->pci_dev->device == 0x0332)) { | 263 | if ((ctrl->pci_dev->vendor == 0x8086) && (ctrl->pci_dev->device == 0x0332)) { |
265 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, PCI_SPEED_33MHz))) { | 264 | if ((rc = p_slot->hpc_ops->set_bus_speed_mode(p_slot, PCI_SPEED_33MHz))) { |
266 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command" | 265 | ctrl_err(ctrl, "%s: Issue of set bus speed mode command failed\n", |
267 | " failed\n", __func__); | 266 | __func__); |
268 | return WRONG_BUS_FREQUENCY; | 267 | return WRONG_BUS_FREQUENCY; |
269 | } | 268 | } |
270 | 269 | ||
@@ -277,8 +276,7 @@ static int board_added(struct slot *p_slot) | |||
277 | 276 | ||
278 | rc = p_slot->hpc_ops->get_adapter_speed(p_slot, &asp); | 277 | rc = p_slot->hpc_ops->get_adapter_speed(p_slot, &asp); |
279 | if (rc) { | 278 | if (rc) { |
280 | ctrl_err(ctrl, "Can't get adapter speed or " | 279 | ctrl_err(ctrl, "Can't get adapter speed or bus mode mismatch\n"); |
281 | "bus mode mismatch\n"); | ||
282 | return WRONG_BUS_FREQUENCY; | 280 | return WRONG_BUS_FREQUENCY; |
283 | } | 281 | } |
284 | 282 | ||
@@ -289,8 +287,8 @@ static int board_added(struct slot *p_slot) | |||
289 | if (!list_empty(&ctrl->pci_dev->subordinate->devices)) | 287 | if (!list_empty(&ctrl->pci_dev->subordinate->devices)) |
290 | slots_not_empty = 1; | 288 | slots_not_empty = 1; |
291 | 289 | ||
292 | ctrl_dbg(ctrl, "%s: slots_not_empty %d, adapter_speed %d, bus_speed %d," | 290 | ctrl_dbg(ctrl, "%s: slots_not_empty %d, adapter_speed %d, bus_speed %d, max_bus_speed %d\n", |
293 | " max_bus_speed %d\n", __func__, slots_not_empty, asp, | 291 | __func__, slots_not_empty, asp, |
294 | bsp, msp); | 292 | bsp, msp); |
295 | 293 | ||
296 | rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, asp, bsp, msp); | 294 | rc = fix_bus_speed(ctrl, p_slot, slots_not_empty, asp, bsp, msp); |
@@ -490,12 +488,12 @@ static void handle_button_press_event(struct slot *p_slot) | |||
490 | p_slot->hpc_ops->get_power_status(p_slot, &getstatus); | 488 | p_slot->hpc_ops->get_power_status(p_slot, &getstatus); |
491 | if (getstatus) { | 489 | if (getstatus) { |
492 | p_slot->state = BLINKINGOFF_STATE; | 490 | p_slot->state = BLINKINGOFF_STATE; |
493 | ctrl_info(ctrl, "PCI slot #%s - powering off due to " | 491 | ctrl_info(ctrl, "PCI slot #%s - powering off due to button press\n", |
494 | "button press.\n", slot_name(p_slot)); | 492 | slot_name(p_slot)); |
495 | } else { | 493 | } else { |
496 | p_slot->state = BLINKINGON_STATE; | 494 | p_slot->state = BLINKINGON_STATE; |
497 | ctrl_info(ctrl, "PCI slot #%s - powering on due to " | 495 | ctrl_info(ctrl, "PCI slot #%s - powering on due to button press\n", |
498 | "button press.\n", slot_name(p_slot)); | 496 | slot_name(p_slot)); |
499 | } | 497 | } |
500 | /* blink green LED and turn off amber */ | 498 | /* blink green LED and turn off amber */ |
501 | p_slot->hpc_ops->green_led_blink(p_slot); | 499 | p_slot->hpc_ops->green_led_blink(p_slot); |
@@ -518,8 +516,8 @@ static void handle_button_press_event(struct slot *p_slot) | |||
518 | else | 516 | else |
519 | p_slot->hpc_ops->green_led_off(p_slot); | 517 | p_slot->hpc_ops->green_led_off(p_slot); |
520 | p_slot->hpc_ops->set_attention_status(p_slot, 0); | 518 | p_slot->hpc_ops->set_attention_status(p_slot, 0); |
521 | ctrl_info(ctrl, "PCI slot #%s - action canceled due to " | 519 | ctrl_info(ctrl, "PCI slot #%s - action canceled due to button press\n", |
522 | "button press\n", slot_name(p_slot)); | 520 | slot_name(p_slot)); |
523 | p_slot->state = STATIC_STATE; | 521 | p_slot->state = STATIC_STATE; |
524 | break; | 522 | break; |
525 | case POWEROFF_STATE: | 523 | case POWEROFF_STATE: |
diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index 12aa9e2b78aa..29e22352822c 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c | |||
@@ -341,8 +341,7 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd) | |||
341 | 341 | ||
342 | cmd_status = hpc_check_cmd_status(slot->ctrl); | 342 | cmd_status = hpc_check_cmd_status(slot->ctrl); |
343 | if (cmd_status) { | 343 | if (cmd_status) { |
344 | ctrl_err(ctrl, | 344 | ctrl_err(ctrl, "Failed to issued command 0x%x (error code = %d)\n", |
345 | "Failed to issued command 0x%x (error code = %d)\n", | ||
346 | cmd, cmd_status); | 345 | cmd, cmd_status); |
347 | retval = -EIO; | 346 | retval = -EIO; |
348 | } | 347 | } |
@@ -974,8 +973,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
974 | for (i = 0; i < 9 + num_slots; i++) { | 973 | for (i = 0; i < 9 + num_slots; i++) { |
975 | rc = shpc_indirect_read(ctrl, i, &tempdword); | 974 | rc = shpc_indirect_read(ctrl, i, &tempdword); |
976 | if (rc) { | 975 | if (rc) { |
977 | ctrl_err(ctrl, | 976 | ctrl_err(ctrl, "Cannot read creg (index = %d)\n", |
978 | "Cannot read creg (index = %d)\n", i); | 977 | i); |
979 | goto abort; | 978 | goto abort; |
980 | } | 979 | } |
981 | ctrl_dbg(ctrl, " offset %d: value %x\n", i, tempdword); | 980 | ctrl_dbg(ctrl, " offset %d: value %x\n", i, tempdword); |
@@ -1060,10 +1059,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
1060 | /* Installs the interrupt handler */ | 1059 | /* Installs the interrupt handler */ |
1061 | rc = pci_enable_msi(pdev); | 1060 | rc = pci_enable_msi(pdev); |
1062 | if (rc) { | 1061 | if (rc) { |
1063 | ctrl_info(ctrl, | 1062 | ctrl_info(ctrl, "Can't get msi for the hotplug controller\n"); |
1064 | "Can't get msi for the hotplug controller\n"); | 1063 | ctrl_info(ctrl, "Use INTx for the hotplug controller\n"); |
1065 | ctrl_info(ctrl, | ||
1066 | "Use INTx for the hotplug controller\n"); | ||
1067 | } | 1064 | } |
1068 | 1065 | ||
1069 | rc = request_irq(ctrl->pci_dev->irq, shpc_isr, IRQF_SHARED, | 1066 | rc = request_irq(ctrl->pci_dev->irq, shpc_isr, IRQF_SHARED, |
@@ -1071,8 +1068,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
1071 | ctrl_dbg(ctrl, "request_irq %d (returns %d)\n", | 1068 | ctrl_dbg(ctrl, "request_irq %d (returns %d)\n", |
1072 | ctrl->pci_dev->irq, rc); | 1069 | ctrl->pci_dev->irq, rc); |
1073 | if (rc) { | 1070 | if (rc) { |
1074 | ctrl_err(ctrl, "Can't get irq %d for the hotplug " | 1071 | ctrl_err(ctrl, "Can't get irq %d for the hotplug controller\n", |
1075 | "controller\n", ctrl->pci_dev->irq); | 1072 | ctrl->pci_dev->irq); |
1076 | goto abort_iounmap; | 1073 | goto abort_iounmap; |
1077 | } | 1074 | } |
1078 | } | 1075 | } |
diff --git a/drivers/pci/hotplug/shpchp_pci.c b/drivers/pci/hotplug/shpchp_pci.c index 9202d133485c..469454e0cc48 100644 --- a/drivers/pci/hotplug/shpchp_pci.c +++ b/drivers/pci/hotplug/shpchp_pci.c | |||
@@ -46,9 +46,9 @@ int shpchp_configure_device(struct slot *p_slot) | |||
46 | 46 | ||
47 | dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, 0)); | 47 | dev = pci_get_slot(parent, PCI_DEVFN(p_slot->device, 0)); |
48 | if (dev) { | 48 | if (dev) { |
49 | ctrl_err(ctrl, "Device %s already exists " | 49 | ctrl_err(ctrl, "Device %s already exists at %04x:%02x:%02x, cannot hot-add\n", |
50 | "at %04x:%02x:%02x, cannot hot-add\n", pci_name(dev), | 50 | pci_name(dev), pci_domain_nr(parent), |
51 | pci_domain_nr(parent), p_slot->bus, p_slot->device); | 51 | p_slot->bus, p_slot->device); |
52 | pci_dev_put(dev); | 52 | pci_dev_put(dev); |
53 | ret = -EINVAL; | 53 | ret = -EINVAL; |
54 | goto out; | 54 | goto out; |