aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/of
diff options
context:
space:
mode:
authorThomas Abraham <thomas.abraham@linaro.org>2013-01-19 13:20:42 -0500
committerRob Herring <rob.herring@calxeda.com>2013-01-20 17:26:42 -0500
commitdc71bcf1b99c265fffdb1e8c60e7933612f3bca7 (patch)
treec9ff0a23acfd5b5a2dd487a13cab817e2b671a19 /drivers/of
parent7d1f9aeff1ee4a20b1aeb377dd0f579fe9647619 (diff)
of: fix incorrect return value of of_find_matching_node_and_match()
The of_find_matching_node_and_match() function incorrectly sets the matched entry to 'matches' when the compatible value of a node matches one of the possible values. This results in incorrectly selecting the the first entry in the 'matches' list as the matched entry. Fix this by noting down the result of the call to of_match_node() and setting that as the matched entry. Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/base.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 2390ddb22d60..960ae5bf3ddc 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -612,6 +612,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from,
612 const struct of_device_id **match) 612 const struct of_device_id **match)
613{ 613{
614 struct device_node *np; 614 struct device_node *np;
615 const struct of_device_id *m;
615 616
616 if (match) 617 if (match)
617 *match = NULL; 618 *match = NULL;
@@ -619,9 +620,10 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from,
619 read_lock(&devtree_lock); 620 read_lock(&devtree_lock);
620 np = from ? from->allnext : of_allnodes; 621 np = from ? from->allnext : of_allnodes;
621 for (; np; np = np->allnext) { 622 for (; np; np = np->allnext) {
622 if (of_match_node(matches, np) && of_node_get(np)) { 623 m = of_match_node(matches, np);
624 if (m && of_node_get(np)) {
623 if (match) 625 if (match)
624 *match = matches; 626 *match = m;
625 break; 627 break;
626 } 628 }
627 } 629 }