aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2008-09-01 07:48:03 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-09-03 09:53:46 -0400
commitd3074025345ae27fbb076a92425f28b40b6fa4c0 (patch)
treee220c1876fe6391c710acf3c21a96566fcad865b /drivers/net
parenta2589027ff0011077cdaf761be3a9a4ba40b5118 (diff)
sfc: Remove efx_channel::evqnum field
It is redundant with efx_channel::channel. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/sfc/efx.c1
-rw-r--r--drivers/net/sfc/falcon.c14
-rw-r--r--drivers/net/sfc/net_driver.h2
3 files changed, 7 insertions, 10 deletions
diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
index ba4369c8a834..22004a612d2c 100644
--- a/drivers/net/sfc/efx.c
+++ b/drivers/net/sfc/efx.c
@@ -1854,7 +1854,6 @@ static int efx_init_struct(struct efx_nic *efx, struct efx_nic_type *type,
1854 channel = &efx->channel[i]; 1854 channel = &efx->channel[i];
1855 channel->efx = efx; 1855 channel->efx = efx;
1856 channel->channel = i; 1856 channel->channel = i;
1857 channel->evqnum = i;
1858 channel->work_pending = false; 1857 channel->work_pending = false;
1859 } 1858 }
1860 for (i = 0; i < EFX_TX_QUEUE_COUNT; i++) { 1859 for (i = 0; i < EFX_TX_QUEUE_COUNT; i++) {
diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
index bfae0826848a..7b1c387ff8ef 100644
--- a/drivers/net/sfc/falcon.c
+++ b/drivers/net/sfc/falcon.c
@@ -466,7 +466,7 @@ int falcon_init_tx(struct efx_tx_queue *tx_queue)
466 TX_ISCSI_DDIG_EN, 0, 466 TX_ISCSI_DDIG_EN, 0,
467 TX_ISCSI_HDIG_EN, 0, 467 TX_ISCSI_HDIG_EN, 0,
468 TX_DESCQ_BUF_BASE_ID, tx_queue->txd.index, 468 TX_DESCQ_BUF_BASE_ID, tx_queue->txd.index,
469 TX_DESCQ_EVQ_ID, tx_queue->channel->evqnum, 469 TX_DESCQ_EVQ_ID, tx_queue->channel->channel,
470 TX_DESCQ_OWNER_ID, 0, 470 TX_DESCQ_OWNER_ID, 0,
471 TX_DESCQ_LABEL, tx_queue->queue, 471 TX_DESCQ_LABEL, tx_queue->queue,
472 TX_DESCQ_SIZE, FALCON_TXD_RING_ORDER, 472 TX_DESCQ_SIZE, FALCON_TXD_RING_ORDER,
@@ -661,7 +661,7 @@ int falcon_init_rx(struct efx_rx_queue *rx_queue)
661 RX_ISCSI_DDIG_EN, iscsi_digest_en, 661 RX_ISCSI_DDIG_EN, iscsi_digest_en,
662 RX_ISCSI_HDIG_EN, iscsi_digest_en, 662 RX_ISCSI_HDIG_EN, iscsi_digest_en,
663 RX_DESCQ_BUF_BASE_ID, rx_queue->rxd.index, 663 RX_DESCQ_BUF_BASE_ID, rx_queue->rxd.index,
664 RX_DESCQ_EVQ_ID, rx_queue->channel->evqnum, 664 RX_DESCQ_EVQ_ID, rx_queue->channel->channel,
665 RX_DESCQ_OWNER_ID, 0, 665 RX_DESCQ_OWNER_ID, 0,
666 RX_DESCQ_LABEL, rx_queue->queue, 666 RX_DESCQ_LABEL, rx_queue->queue,
667 RX_DESCQ_SIZE, FALCON_RXD_RING_ORDER, 667 RX_DESCQ_SIZE, FALCON_RXD_RING_ORDER,
@@ -795,7 +795,7 @@ void falcon_eventq_read_ack(struct efx_channel *channel)
795 795
796 EFX_POPULATE_DWORD_1(reg, EVQ_RPTR_DWORD, channel->eventq_read_ptr); 796 EFX_POPULATE_DWORD_1(reg, EVQ_RPTR_DWORD, channel->eventq_read_ptr);
797 falcon_writel_table(efx, &reg, efx->type->evq_rptr_tbl_base, 797 falcon_writel_table(efx, &reg, efx->type->evq_rptr_tbl_base,
798 channel->evqnum); 798 channel->channel);
799} 799}
800 800
801/* Use HW to insert a SW defined event */ 801/* Use HW to insert a SW defined event */
@@ -804,7 +804,7 @@ void falcon_generate_event(struct efx_channel *channel, efx_qword_t *event)
804 efx_oword_t drv_ev_reg; 804 efx_oword_t drv_ev_reg;
805 805
806 EFX_POPULATE_OWORD_2(drv_ev_reg, 806 EFX_POPULATE_OWORD_2(drv_ev_reg,
807 DRV_EV_QID, channel->evqnum, 807 DRV_EV_QID, channel->channel,
808 DRV_EV_DATA, 808 DRV_EV_DATA,
809 EFX_QWORD_FIELD64(*event, WHOLE_EVENT)); 809 EFX_QWORD_FIELD64(*event, WHOLE_EVENT));
810 falcon_write(channel->efx, &drv_ev_reg, DRV_EV_REG_KER); 810 falcon_write(channel->efx, &drv_ev_reg, DRV_EV_REG_KER);
@@ -1197,7 +1197,7 @@ void falcon_set_int_moderation(struct efx_channel *channel)
1197 TIMER_VAL, 0); 1197 TIMER_VAL, 0);
1198 } 1198 }
1199 falcon_writel_page_locked(efx, &timer_cmd, TIMER_CMD_REG_KER, 1199 falcon_writel_page_locked(efx, &timer_cmd, TIMER_CMD_REG_KER,
1200 channel->evqnum); 1200 channel->channel);
1201 1201
1202} 1202}
1203 1203
@@ -1235,7 +1235,7 @@ int falcon_init_eventq(struct efx_channel *channel)
1235 EVQ_SIZE, FALCON_EVQ_ORDER, 1235 EVQ_SIZE, FALCON_EVQ_ORDER,
1236 EVQ_BUF_BASE_ID, channel->eventq.index); 1236 EVQ_BUF_BASE_ID, channel->eventq.index);
1237 falcon_write_table(efx, &evq_ptr, efx->type->evq_ptr_tbl_base, 1237 falcon_write_table(efx, &evq_ptr, efx->type->evq_ptr_tbl_base,
1238 channel->evqnum); 1238 channel->channel);
1239 1239
1240 falcon_set_int_moderation(channel); 1240 falcon_set_int_moderation(channel);
1241 1241
@@ -1250,7 +1250,7 @@ void falcon_fini_eventq(struct efx_channel *channel)
1250 /* Remove event queue from card */ 1250 /* Remove event queue from card */
1251 EFX_ZERO_OWORD(eventq_ptr); 1251 EFX_ZERO_OWORD(eventq_ptr);
1252 falcon_write_table(efx, &eventq_ptr, efx->type->evq_ptr_tbl_base, 1252 falcon_write_table(efx, &eventq_ptr, efx->type->evq_ptr_tbl_base,
1253 channel->evqnum); 1253 channel->channel);
1254 1254
1255 /* Unpin event queue */ 1255 /* Unpin event queue */
1256 falcon_fini_special_buffer(efx, &channel->eventq); 1256 falcon_fini_special_buffer(efx, &channel->eventq);
diff --git a/drivers/net/sfc/net_driver.h b/drivers/net/sfc/net_driver.h
index 74e934c7e6f8..e65d6617beea 100644
--- a/drivers/net/sfc/net_driver.h
+++ b/drivers/net/sfc/net_driver.h
@@ -322,7 +322,6 @@ enum efx_rx_alloc_method {
322 * queue. 322 * queue.
323 * 323 *
324 * @efx: Associated Efx NIC 324 * @efx: Associated Efx NIC
325 * @evqnum: Event queue number
326 * @channel: Channel instance number 325 * @channel: Channel instance number
327 * @used_flags: Channel is used by net driver 326 * @used_flags: Channel is used by net driver
328 * @enabled: Channel enabled indicator 327 * @enabled: Channel enabled indicator
@@ -353,7 +352,6 @@ enum efx_rx_alloc_method {
353 */ 352 */
354struct efx_channel { 353struct efx_channel {
355 struct efx_nic *efx; 354 struct efx_nic *efx;
356 int evqnum;
357 int channel; 355 int channel;
358 int used_flags; 356 int used_flags;
359 bool enabled; 357 bool enabled;