bnx2x: Test nvram when interface is down

Since commit 3fb43eb ("bnx2x: Change to D3hot only on removal") nvram
is accessible whenever the driver is loaded - Thus it is possible to
test it during self-test even if the interface is down

Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 10 insertions, 9 deletions

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 324de5f05332..120966c5f1cf 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -2900,9 +2900,16 @@ static void bnx2x_self_test(struct net_device *dev,
 
         memset(buf, 0, sizeof(u64) * BNX2X_NUM_TESTS(bp));
 
+        if (bnx2x_test_nvram(bp) != 0) {
+                if (!IS_MF(bp))
+                        buf[4] = 1;
+                else
+                        buf[0] = 1;
+                etest->flags |= ETH_TEST_FL_FAILED;
+        }
+
         if (!netif_running(dev)) {
-                DP(BNX2X_MSG_ETHTOOL,
-                   "Can't perform self-test when interface is down\n");
+                DP(BNX2X_MSG_ETHTOOL, "Interface is down\n");
                 return;
         }
 
@@ -2964,13 +2971,7 @@ static void bnx2x_self_test(struct net_device *dev,
                 /* wait until link state is restored */
                 bnx2x_wait_for_link(bp, link_up, is_serdes);
         }
-        if (bnx2x_test_nvram(bp) != 0) {
-                if (!IS_MF(bp))
-                        buf[4] = 1;
-                else
-                        buf[0] = 1;
-                etest->flags |= ETH_TEST_FL_FAILED;
-        }
+
         if (bnx2x_test_intr(bp) != 0) {
                 if (!IS_MF(bp))
                         buf[5] = 1;