diff options
author | Bing Zhao <bzhao@marvell.com> | 2012-08-07 19:08:08 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-08-10 15:26:59 -0400 |
commit | 8dd4372e2a462081b92b38af18accb427fa2d554 (patch) | |
tree | aa6339f353458d0a26e467cf43e2a53ebd45fd75 /drivers/net | |
parent | 450e9038ee65e3246b2a942669fc79001466f9be (diff) |
mwifiex: fix powerpc64-linux- compilation warnings
These warnings can be detected by using powerpc64-linux toolchain
(gcc-4.6.3-nolibc).
CC [M] drivers/net/wireless/mwifiex/sta_event.o
drivers/net/wireless/mwifiex/sta_event.c: In function 'mwifiex_process_sta_event':
drivers/net/wireless/mwifiex/sta_event.c:388:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
CC [M] drivers/net/wireless/mwifiex/uap_event.o
drivers/net/wireless/mwifiex/uap_event.c: In function 'mwifiex_process_uap_event':
drivers/net/wireless/mwifiex/uap_event.c:258:11: warning: comparison of distinct pointer types lacks a cast [enabled by default]
Use min_t() instead of min() to fix the warnings.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/wireless/mwifiex/sta_event.c | 9 | ||||
-rw-r--r-- | drivers/net/wireless/mwifiex/uap_event.c | 9 |
2 files changed, 9 insertions, 9 deletions
diff --git a/drivers/net/wireless/mwifiex/sta_event.c b/drivers/net/wireless/mwifiex/sta_event.c index 2aad148db5c3..4758d3064887 100644 --- a/drivers/net/wireless/mwifiex/sta_event.c +++ b/drivers/net/wireless/mwifiex/sta_event.c | |||
@@ -186,6 +186,7 @@ int mwifiex_process_sta_event(struct mwifiex_private *priv) | |||
186 | struct mwifiex_adapter *adapter = priv->adapter; | 186 | struct mwifiex_adapter *adapter = priv->adapter; |
187 | int ret = 0; | 187 | int ret = 0; |
188 | u32 eventcause = adapter->event_cause; | 188 | u32 eventcause = adapter->event_cause; |
189 | u16 ctrl; | ||
189 | 190 | ||
190 | switch (eventcause) { | 191 | switch (eventcause) { |
191 | case EVENT_DUMMY_HOST_WAKEUP_SIGNAL: | 192 | case EVENT_DUMMY_HOST_WAKEUP_SIGNAL: |
@@ -382,11 +383,11 @@ int mwifiex_process_sta_event(struct mwifiex_private *priv) | |||
382 | adapter->event_body); | 383 | adapter->event_body); |
383 | break; | 384 | break; |
384 | case EVENT_AMSDU_AGGR_CTRL: | 385 | case EVENT_AMSDU_AGGR_CTRL: |
385 | dev_dbg(adapter->dev, "event: AMSDU_AGGR_CTRL %d\n", | 386 | ctrl = le16_to_cpu(*(__le16 *)adapter->event_body); |
386 | *(u16 *) adapter->event_body); | 387 | dev_dbg(adapter->dev, "event: AMSDU_AGGR_CTRL %d\n", ctrl); |
388 | |||
387 | adapter->tx_buf_size = | 389 | adapter->tx_buf_size = |
388 | min(adapter->curr_tx_buf_size, | 390 | min_t(u16, adapter->curr_tx_buf_size, ctrl); |
389 | le16_to_cpu(*(__le16 *) adapter->event_body)); | ||
390 | dev_dbg(adapter->dev, "event: tx_buf_size %d\n", | 391 | dev_dbg(adapter->dev, "event: tx_buf_size %d\n", |
391 | adapter->tx_buf_size); | 392 | adapter->tx_buf_size); |
392 | break; | 393 | break; |
diff --git a/drivers/net/wireless/mwifiex/uap_event.c b/drivers/net/wireless/mwifiex/uap_event.c index 14d4f04201b9..1703abf73dac 100644 --- a/drivers/net/wireless/mwifiex/uap_event.c +++ b/drivers/net/wireless/mwifiex/uap_event.c | |||
@@ -170,6 +170,7 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv) | |||
170 | struct mwifiex_sta_node *node; | 170 | struct mwifiex_sta_node *node; |
171 | u8 *deauth_mac; | 171 | u8 *deauth_mac; |
172 | struct host_cmd_ds_11n_batimeout *ba_timeout; | 172 | struct host_cmd_ds_11n_batimeout *ba_timeout; |
173 | u16 ctrl; | ||
173 | 174 | ||
174 | switch (eventcause) { | 175 | switch (eventcause) { |
175 | case EVENT_UAP_STA_ASSOC: | 176 | case EVENT_UAP_STA_ASSOC: |
@@ -250,14 +251,12 @@ int mwifiex_process_uap_event(struct mwifiex_private *priv) | |||
250 | dev_dbg(adapter->dev, "AP EVENT: event id: %#x\n", eventcause); | 251 | dev_dbg(adapter->dev, "AP EVENT: event id: %#x\n", eventcause); |
251 | break; | 252 | break; |
252 | case EVENT_AMSDU_AGGR_CTRL: | 253 | case EVENT_AMSDU_AGGR_CTRL: |
253 | dev_dbg(adapter->dev, "event: AMSDU_AGGR_CTRL %d\n", | 254 | ctrl = le16_to_cpu(*(__le16 *)adapter->event_body); |
254 | *(u16 *)adapter->event_body); | 255 | dev_dbg(adapter->dev, "event: AMSDU_AGGR_CTRL %d\n", ctrl); |
255 | 256 | ||
256 | if (priv->media_connected) { | 257 | if (priv->media_connected) { |
257 | adapter->tx_buf_size = | 258 | adapter->tx_buf_size = |
258 | min(adapter->curr_tx_buf_size, | 259 | min_t(u16, adapter->curr_tx_buf_size, ctrl); |
259 | le16_to_cpu(*(__le16 *)adapter->event_body)); | ||
260 | |||
261 | dev_dbg(adapter->dev, "event: tx_buf_size %d\n", | 260 | dev_dbg(adapter->dev, "event: tx_buf_size %d\n", |
262 | adapter->tx_buf_size); | 261 | adapter->tx_buf_size); |
263 | } | 262 | } |