diff options
author | Marc Kleine-Budde <mkl@pengutronix.de> | 2013-10-04 09:40:22 -0400 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2013-10-31 15:55:15 -0400 |
commit | 49cb5c0e0cb26e9f39445d8b5aa5c50ba9451cdd (patch) | |
tree | 643795318f2e0c67b65f665f78651caf4bdbae50 /drivers/net | |
parent | 57a59b9ef58f3422f9d9f2cf7631da1727686991 (diff) |
can: dev: sort can_changelink() by IFLA_CAN_*
This patch sorts the handling of data[IFLA_CAN_*] by IFLA_CAN_*.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/can/dev.c | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 8d6f7212ae22..bda1888cae9a 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c | |||
@@ -645,19 +645,6 @@ static int can_changelink(struct net_device *dev, | |||
645 | /* We need synchronization with dev->stop() */ | 645 | /* We need synchronization with dev->stop() */ |
646 | ASSERT_RTNL(); | 646 | ASSERT_RTNL(); |
647 | 647 | ||
648 | if (data[IFLA_CAN_CTRLMODE]) { | ||
649 | struct can_ctrlmode *cm; | ||
650 | |||
651 | /* Do not allow changing controller mode while running */ | ||
652 | if (dev->flags & IFF_UP) | ||
653 | return -EBUSY; | ||
654 | cm = nla_data(data[IFLA_CAN_CTRLMODE]); | ||
655 | if (cm->flags & ~priv->ctrlmode_supported) | ||
656 | return -EOPNOTSUPP; | ||
657 | priv->ctrlmode &= ~cm->mask; | ||
658 | priv->ctrlmode |= cm->flags; | ||
659 | } | ||
660 | |||
661 | if (data[IFLA_CAN_BITTIMING]) { | 648 | if (data[IFLA_CAN_BITTIMING]) { |
662 | struct can_bittiming bt; | 649 | struct can_bittiming bt; |
663 | 650 | ||
@@ -680,6 +667,19 @@ static int can_changelink(struct net_device *dev, | |||
680 | } | 667 | } |
681 | } | 668 | } |
682 | 669 | ||
670 | if (data[IFLA_CAN_CTRLMODE]) { | ||
671 | struct can_ctrlmode *cm; | ||
672 | |||
673 | /* Do not allow changing controller mode while running */ | ||
674 | if (dev->flags & IFF_UP) | ||
675 | return -EBUSY; | ||
676 | cm = nla_data(data[IFLA_CAN_CTRLMODE]); | ||
677 | if (cm->flags & ~priv->ctrlmode_supported) | ||
678 | return -EOPNOTSUPP; | ||
679 | priv->ctrlmode &= ~cm->mask; | ||
680 | priv->ctrlmode |= cm->flags; | ||
681 | } | ||
682 | |||
683 | if (data[IFLA_CAN_RESTART_MS]) { | 683 | if (data[IFLA_CAN_RESTART_MS]) { |
684 | /* Do not allow changing restart delay while running */ | 684 | /* Do not allow changing restart delay while running */ |
685 | if (dev->flags & IFF_UP) | 685 | if (dev->flags & IFF_UP) |