diff options
author | Stephen Hemminger <shemminger@osdl.org> | 2005-12-06 20:36:44 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2005-12-06 20:36:44 -0500 |
commit | 1f064a87c80c86bd3878e6633de61e8b71aa6788 (patch) | |
tree | b5e5eefaa380590f118176c4c1855b9f98b5e85b /drivers/net | |
parent | 4ebf0ae2618fbbb0d365e5d295a30ccfcb91fe0b (diff) |
[TG3]: remove warning on race
[ Move assosciated code comment to the correct spot, and
update driver version and release date -DaveM ]
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/tg3.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 1828a6bf8458..47bd4a394420 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -68,8 +68,8 @@ | |||
68 | 68 | ||
69 | #define DRV_MODULE_NAME "tg3" | 69 | #define DRV_MODULE_NAME "tg3" |
70 | #define PFX DRV_MODULE_NAME ": " | 70 | #define PFX DRV_MODULE_NAME ": " |
71 | #define DRV_MODULE_VERSION "3.43" | 71 | #define DRV_MODULE_VERSION "3.44" |
72 | #define DRV_MODULE_RELDATE "Oct 24, 2005" | 72 | #define DRV_MODULE_RELDATE "Dec 6, 2005" |
73 | 73 | ||
74 | #define TG3_DEF_MAC_MODE 0 | 74 | #define TG3_DEF_MAC_MODE 0 |
75 | #define TG3_DEF_RX_MODE 0 | 75 | #define TG3_DEF_RX_MODE 0 |
@@ -3565,12 +3565,15 @@ static int tg3_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
3565 | if (!spin_trylock(&tp->tx_lock)) | 3565 | if (!spin_trylock(&tp->tx_lock)) |
3566 | return NETDEV_TX_LOCKED; | 3566 | return NETDEV_TX_LOCKED; |
3567 | 3567 | ||
3568 | /* This is a hard error, log it. */ | ||
3569 | if (unlikely(TX_BUFFS_AVAIL(tp) <= (skb_shinfo(skb)->nr_frags + 1))) { | 3568 | if (unlikely(TX_BUFFS_AVAIL(tp) <= (skb_shinfo(skb)->nr_frags + 1))) { |
3570 | netif_stop_queue(dev); | 3569 | if (!netif_queue_stopped(dev)) { |
3570 | netif_stop_queue(dev); | ||
3571 | |||
3572 | /* This is a hard error, log it. */ | ||
3573 | printk(KERN_ERR PFX "%s: BUG! Tx Ring full when " | ||
3574 | "queue awake!\n", dev->name); | ||
3575 | } | ||
3571 | spin_unlock(&tp->tx_lock); | 3576 | spin_unlock(&tp->tx_lock); |
3572 | printk(KERN_ERR PFX "%s: BUG! Tx Ring full when queue awake!\n", | ||
3573 | dev->name); | ||
3574 | return NETDEV_TX_BUSY; | 3577 | return NETDEV_TX_BUSY; |
3575 | } | 3578 | } |
3576 | 3579 | ||