diff options
| author | Frans Pop <elendil@planet.nl> | 2009-10-02 13:04:12 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-10-02 13:04:12 -0400 |
| commit | 19d5afd4f0d26201d8d8bec351ee0442775a5379 (patch) | |
| tree | 8bf3b440d53c2e3a60c0a0ea69cb99bc3b729428 /drivers/net | |
| parent | b607bd900051efc3308c4edc65dd98b34b230021 (diff) | |
e1000e/igb/ixgbe: Don't report an error if devices don't support AER
The only error returned by pci_{en,dis}able_pcie_error_reporting() is
-EIO which simply means that Advanced Error Reporting is not supported.
There is no need to report that, so remove the error check from e1000e,
igb and ixgbe.
Signed-off-by: Frans Pop <elendil@planet.nl>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/e1000e/netdev.c | 13 | ||||
| -rw-r--r-- | drivers/net/igb/igb_main.c | 13 | ||||
| -rw-r--r-- | drivers/net/ixgbe/ixgbe_main.c | 13 |
3 files changed, 6 insertions, 33 deletions
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 16c193a6c95c..0687c6aa4e46 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c | |||
| @@ -4982,12 +4982,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev, | |||
| 4982 | goto err_pci_reg; | 4982 | goto err_pci_reg; |
| 4983 | 4983 | ||
| 4984 | /* AER (Advanced Error Reporting) hooks */ | 4984 | /* AER (Advanced Error Reporting) hooks */ |
| 4985 | err = pci_enable_pcie_error_reporting(pdev); | 4985 | pci_enable_pcie_error_reporting(pdev); |
| 4986 | if (err) { | ||
| 4987 | dev_err(&pdev->dev, "pci_enable_pcie_error_reporting failed " | ||
| 4988 | "0x%x\n", err); | ||
| 4989 | /* non-fatal, continue */ | ||
| 4990 | } | ||
| 4991 | 4986 | ||
| 4992 | pci_set_master(pdev); | 4987 | pci_set_master(pdev); |
| 4993 | /* PCI config space info */ | 4988 | /* PCI config space info */ |
| @@ -5263,7 +5258,6 @@ static void __devexit e1000_remove(struct pci_dev *pdev) | |||
| 5263 | { | 5258 | { |
| 5264 | struct net_device *netdev = pci_get_drvdata(pdev); | 5259 | struct net_device *netdev = pci_get_drvdata(pdev); |
| 5265 | struct e1000_adapter *adapter = netdev_priv(netdev); | 5260 | struct e1000_adapter *adapter = netdev_priv(netdev); |
| 5266 | int err; | ||
| 5267 | 5261 | ||
| 5268 | /* | 5262 | /* |
| 5269 | * flush_scheduled work may reschedule our watchdog task, so | 5263 | * flush_scheduled work may reschedule our watchdog task, so |
| @@ -5299,10 +5293,7 @@ static void __devexit e1000_remove(struct pci_dev *pdev) | |||
| 5299 | free_netdev(netdev); | 5293 | free_netdev(netdev); |
| 5300 | 5294 | ||
| 5301 | /* AER disable */ | 5295 | /* AER disable */ |
| 5302 | err = pci_disable_pcie_error_reporting(pdev); | 5296 | pci_disable_pcie_error_reporting(pdev); |
| 5303 | if (err) | ||
| 5304 | dev_err(&pdev->dev, | ||
| 5305 | "pci_disable_pcie_error_reporting failed 0x%x\n", err); | ||
| 5306 | 5297 | ||
| 5307 | pci_disable_device(pdev); | 5298 | pci_disable_device(pdev); |
| 5308 | } | 5299 | } |
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index 5d6c1530a8c0..714c3a4a44ef 100644 --- a/drivers/net/igb/igb_main.c +++ b/drivers/net/igb/igb_main.c | |||
| @@ -1246,12 +1246,7 @@ static int __devinit igb_probe(struct pci_dev *pdev, | |||
| 1246 | if (err) | 1246 | if (err) |
| 1247 | goto err_pci_reg; | 1247 | goto err_pci_reg; |
| 1248 | 1248 | ||
| 1249 | err = pci_enable_pcie_error_reporting(pdev); | 1249 | pci_enable_pcie_error_reporting(pdev); |
| 1250 | if (err) { | ||
| 1251 | dev_err(&pdev->dev, "pci_enable_pcie_error_reporting failed " | ||
| 1252 | "0x%x\n", err); | ||
| 1253 | /* non-fatal, continue */ | ||
| 1254 | } | ||
| 1255 | 1250 | ||
| 1256 | pci_set_master(pdev); | 1251 | pci_set_master(pdev); |
| 1257 | pci_save_state(pdev); | 1252 | pci_save_state(pdev); |
| @@ -1628,7 +1623,6 @@ static void __devexit igb_remove(struct pci_dev *pdev) | |||
| 1628 | struct net_device *netdev = pci_get_drvdata(pdev); | 1623 | struct net_device *netdev = pci_get_drvdata(pdev); |
| 1629 | struct igb_adapter *adapter = netdev_priv(netdev); | 1624 | struct igb_adapter *adapter = netdev_priv(netdev); |
| 1630 | struct e1000_hw *hw = &adapter->hw; | 1625 | struct e1000_hw *hw = &adapter->hw; |
| 1631 | int err; | ||
| 1632 | 1626 | ||
| 1633 | /* flush_scheduled work may reschedule our watchdog task, so | 1627 | /* flush_scheduled work may reschedule our watchdog task, so |
| 1634 | * explicitly disable watchdog tasks from being rescheduled */ | 1628 | * explicitly disable watchdog tasks from being rescheduled */ |
| @@ -1682,10 +1676,7 @@ static void __devexit igb_remove(struct pci_dev *pdev) | |||
| 1682 | 1676 | ||
| 1683 | free_netdev(netdev); | 1677 | free_netdev(netdev); |
| 1684 | 1678 | ||
| 1685 | err = pci_disable_pcie_error_reporting(pdev); | 1679 | pci_disable_pcie_error_reporting(pdev); |
| 1686 | if (err) | ||
| 1687 | dev_err(&pdev->dev, | ||
| 1688 | "pci_disable_pcie_error_reporting failed 0x%x\n", err); | ||
| 1689 | 1680 | ||
| 1690 | pci_disable_device(pdev); | 1681 | pci_disable_device(pdev); |
| 1691 | } | 1682 | } |
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index 1cbc6a318b67..28fbb9d281f9 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c | |||
| @@ -5507,12 +5507,7 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev, | |||
| 5507 | goto err_pci_reg; | 5507 | goto err_pci_reg; |
| 5508 | } | 5508 | } |
| 5509 | 5509 | ||
| 5510 | err = pci_enable_pcie_error_reporting(pdev); | 5510 | pci_enable_pcie_error_reporting(pdev); |
| 5511 | if (err) { | ||
| 5512 | dev_err(&pdev->dev, "pci_enable_pcie_error_reporting failed " | ||
| 5513 | "0x%x\n", err); | ||
| 5514 | /* non-fatal, continue */ | ||
| 5515 | } | ||
| 5516 | 5511 | ||
| 5517 | pci_set_master(pdev); | 5512 | pci_set_master(pdev); |
| 5518 | pci_save_state(pdev); | 5513 | pci_save_state(pdev); |
| @@ -5821,7 +5816,6 @@ static void __devexit ixgbe_remove(struct pci_dev *pdev) | |||
| 5821 | { | 5816 | { |
| 5822 | struct net_device *netdev = pci_get_drvdata(pdev); | 5817 | struct net_device *netdev = pci_get_drvdata(pdev); |
| 5823 | struct ixgbe_adapter *adapter = netdev_priv(netdev); | 5818 | struct ixgbe_adapter *adapter = netdev_priv(netdev); |
| 5824 | int err; | ||
| 5825 | 5819 | ||
| 5826 | set_bit(__IXGBE_DOWN, &adapter->state); | 5820 | set_bit(__IXGBE_DOWN, &adapter->state); |
| 5827 | /* clear the module not found bit to make sure the worker won't | 5821 | /* clear the module not found bit to make sure the worker won't |
| @@ -5872,10 +5866,7 @@ static void __devexit ixgbe_remove(struct pci_dev *pdev) | |||
| 5872 | 5866 | ||
| 5873 | free_netdev(netdev); | 5867 | free_netdev(netdev); |
| 5874 | 5868 | ||
| 5875 | err = pci_disable_pcie_error_reporting(pdev); | 5869 | pci_disable_pcie_error_reporting(pdev); |
| 5876 | if (err) | ||
| 5877 | dev_err(&pdev->dev, | ||
| 5878 | "pci_disable_pcie_error_reporting failed 0x%x\n", err); | ||
| 5879 | 5870 | ||
| 5880 | pci_disable_device(pdev); | 5871 | pci_disable_device(pdev); |
| 5881 | } | 5872 | } |
