diff options
author | Troy Tan <troy_tan@realsil.com.cn> | 2015-01-20 12:01:22 -0500 |
---|---|---|
committer | Kalle Valo <kvalo@codeaurora.org> | 2015-02-03 08:10:15 -0500 |
commit | b661a5da57766f4f565d64238b753d6efc0f5499 (patch) | |
tree | b358595d5bcb92eff7f253fc4fe2b038c946a5c0 /drivers/net/wireless | |
parent | 3f7bb3f34cc880bc35f6c278be16cd8afee7c524 (diff) |
rtlwifi: rtl8192ee: Fix adhoc fail
When the buffer descriptor index exceeds 2, then a TX HANG condition
will result.
Signed-off-by: Troy Tan <troy_tan@realsil.com.cn>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org> [V3.18]
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless')
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192ee/fw.c | 6 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192ee/hw.c | 26 |
2 files changed, 1 insertions, 31 deletions
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ee/fw.c b/drivers/net/wireless/rtlwifi/rtl8192ee/fw.c index 45c128b91f7f..c5d4b8013cde 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192ee/fw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ee/fw.c | |||
@@ -666,7 +666,6 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) | |||
666 | struct sk_buff *skb = NULL; | 666 | struct sk_buff *skb = NULL; |
667 | 667 | ||
668 | u32 totalpacketlen; | 668 | u32 totalpacketlen; |
669 | bool rtstatus; | ||
670 | u8 u1rsvdpageloc[5] = { 0 }; | 669 | u8 u1rsvdpageloc[5] = { 0 }; |
671 | bool b_dlok = false; | 670 | bool b_dlok = false; |
672 | 671 | ||
@@ -728,10 +727,7 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) | |||
728 | memcpy((u8 *)skb_put(skb, totalpacketlen), | 727 | memcpy((u8 *)skb_put(skb, totalpacketlen), |
729 | &reserved_page_packet, totalpacketlen); | 728 | &reserved_page_packet, totalpacketlen); |
730 | 729 | ||
731 | rtstatus = rtl_cmd_send_packet(hw, skb); | 730 | b_dlok = true; |
732 | |||
733 | if (rtstatus) | ||
734 | b_dlok = true; | ||
735 | 731 | ||
736 | if (b_dlok) { | 732 | if (b_dlok) { |
737 | RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD , | 733 | RT_TRACE(rtlpriv, COMP_POWER, DBG_LOUD , |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ee/hw.c b/drivers/net/wireless/rtlwifi/rtl8192ee/hw.c index 1a87edca2c3f..3c27ec2c7b5a 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192ee/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ee/hw.c | |||
@@ -85,29 +85,6 @@ static void _rtl92ee_enable_bcn_sub_func(struct ieee80211_hw *hw) | |||
85 | _rtl92ee_set_bcn_ctrl_reg(hw, 0, BIT(1)); | 85 | _rtl92ee_set_bcn_ctrl_reg(hw, 0, BIT(1)); |
86 | } | 86 | } |
87 | 87 | ||
88 | static void _rtl92ee_return_beacon_queue_skb(struct ieee80211_hw *hw) | ||
89 | { | ||
90 | struct rtl_priv *rtlpriv = rtl_priv(hw); | ||
91 | struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); | ||
92 | struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[BEACON_QUEUE]; | ||
93 | unsigned long flags; | ||
94 | |||
95 | spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags); | ||
96 | while (skb_queue_len(&ring->queue)) { | ||
97 | struct rtl_tx_buffer_desc *entry = | ||
98 | &ring->buffer_desc[ring->idx]; | ||
99 | struct sk_buff *skb = __skb_dequeue(&ring->queue); | ||
100 | |||
101 | pci_unmap_single(rtlpci->pdev, | ||
102 | rtlpriv->cfg->ops->get_desc( | ||
103 | (u8 *)entry, true, HW_DESC_TXBUFF_ADDR), | ||
104 | skb->len, PCI_DMA_TODEVICE); | ||
105 | kfree_skb(skb); | ||
106 | ring->idx = (ring->idx + 1) % ring->entries; | ||
107 | } | ||
108 | spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags); | ||
109 | } | ||
110 | |||
111 | static void _rtl92ee_disable_bcn_sub_func(struct ieee80211_hw *hw) | 88 | static void _rtl92ee_disable_bcn_sub_func(struct ieee80211_hw *hw) |
112 | { | 89 | { |
113 | _rtl92ee_set_bcn_ctrl_reg(hw, BIT(1), 0); | 90 | _rtl92ee_set_bcn_ctrl_reg(hw, BIT(1), 0); |
@@ -403,9 +380,6 @@ static void _rtl92ee_download_rsvd_page(struct ieee80211_hw *hw) | |||
403 | rtl_write_byte(rtlpriv, REG_DWBCN0_CTRL + 2, | 380 | rtl_write_byte(rtlpriv, REG_DWBCN0_CTRL + 2, |
404 | bcnvalid_reg | BIT(0)); | 381 | bcnvalid_reg | BIT(0)); |
405 | 382 | ||
406 | /* Return Beacon TCB */ | ||
407 | _rtl92ee_return_beacon_queue_skb(hw); | ||
408 | |||
409 | /* download rsvd page */ | 383 | /* download rsvd page */ |
410 | rtl92ee_set_fw_rsvdpagepkt(hw, false); | 384 | rtl92ee_set_fw_rsvdpagepkt(hw, false); |
411 | 385 | ||