aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-01-03 00:46:29 -0500
committerJohn W. Linville <linville@tuxdriver.com>2011-01-04 14:46:13 -0500
commita8851d10aadb46b25db4459aa0d1150c957d2bc1 (patch)
treee40710cddea3ff5c328141e57a6287b3b541d4f0 /drivers/net/wireless
parent2ae79d52cdac733037490486792a53de9fb8d6b6 (diff)
ath5k: ath5k_eeprom_mode_from_channel() returns signed
ath5k_eeprom_mode_from_channel() returns -1 on error but we're storing the result in "ee_mode" which is an unsigned char. This breaks the error handling. This patch makes "ee_mode" an int. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless')
-rw-r--r--drivers/net/wireless/ath/ath5k/phy.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 9306d5fda675..78c26fdccad1 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1916,7 +1916,8 @@ ath5k_hw_set_antenna_mode(struct ath5k_hw *ah, u8 ant_mode)
1916 struct ieee80211_channel *channel = ah->ah_current_channel; 1916 struct ieee80211_channel *channel = ah->ah_current_channel;
1917 bool use_def_for_tx, update_def_on_tx, use_def_for_rts, fast_div; 1917 bool use_def_for_tx, update_def_on_tx, use_def_for_rts, fast_div;
1918 bool use_def_for_sg; 1918 bool use_def_for_sg;
1919 u8 def_ant, tx_ant, ee_mode; 1919 int ee_mode;
1920 u8 def_ant, tx_ant;
1920 u32 sta_id1 = 0; 1921 u32 sta_id1 = 0;
1921 1922
1922 /* if channel is not initialized yet we can't set the antennas 1923 /* if channel is not initialized yet we can't set the antennas
@@ -3081,7 +3082,8 @@ ath5k_hw_txpower(struct ath5k_hw *ah, struct ieee80211_channel *channel,
3081{ 3082{
3082 struct ath5k_rate_pcal_info rate_info; 3083 struct ath5k_rate_pcal_info rate_info;
3083 struct ieee80211_channel *curr_channel = ah->ah_current_channel; 3084 struct ieee80211_channel *curr_channel = ah->ah_current_channel;
3084 u8 type, ee_mode; 3085 int ee_mode;
3086 u8 type;
3085 int ret; 3087 int ret;
3086 3088
3087 if (txpower > AR5K_TUNE_MAX_TXPOWER) { 3089 if (txpower > AR5K_TUNE_MAX_TXPOWER) {