aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/zd1201.c
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2013-08-26 03:32:01 -0400
committerJohn W. Linville <linville@tuxdriver.com>2013-08-26 14:10:39 -0400
commit58fe431342fdcf53fe93c4482351a9aa46762a11 (patch)
treee30361d55b8a274ba7ff505a78d416b346845a43 /drivers/net/wireless/zd1201.c
parentcfcd926ea2bc46aaca4e9ca3f0a3b8ac35b9d691 (diff)
zd1201: fix error return code
Fix to return -ENOMEM in the memory alloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/zd1201.c')
-rw-r--r--drivers/net/wireless/zd1201.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c
index 4941f201d6c8..73aa7388dd2b 100644
--- a/drivers/net/wireless/zd1201.c
+++ b/drivers/net/wireless/zd1201.c
@@ -75,8 +75,10 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw)
75 len = fw_entry->size; 75 len = fw_entry->size;
76 76
77 buf = kmalloc(1024, GFP_ATOMIC); 77 buf = kmalloc(1024, GFP_ATOMIC);
78 if (!buf) 78 if (!buf) {
79 err = -ENOMEM;
79 goto exit; 80 goto exit;
81 }
80 82
81 while (len > 0) { 83 while (len > 0) {
82 int translen = (len > 1024) ? 1024 : len; 84 int translen = (len > 1024) ? 1024 : len;
@@ -1762,8 +1764,10 @@ static int zd1201_probe(struct usb_interface *interface,
1762 zd->endp_out2 = 2; 1764 zd->endp_out2 = 2;
1763 zd->rx_urb = usb_alloc_urb(0, GFP_KERNEL); 1765 zd->rx_urb = usb_alloc_urb(0, GFP_KERNEL);
1764 zd->tx_urb = usb_alloc_urb(0, GFP_KERNEL); 1766 zd->tx_urb = usb_alloc_urb(0, GFP_KERNEL);
1765 if (!zd->rx_urb || !zd->tx_urb) 1767 if (!zd->rx_urb || !zd->tx_urb) {
1768 err = -ENOMEM;
1766 goto err_zd; 1769 goto err_zd;
1770 }
1767 1771
1768 mdelay(100); 1772 mdelay(100);
1769 err = zd1201_drvr_start(zd); 1773 err = zd1201_drvr_start(zd);