aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/wl12xx/wl1251_main.c
diff options
context:
space:
mode:
authorJiri Slaby <jirislaby@gmail.com>2009-07-14 16:37:13 -0400
committerJohn W. Linville <linville@tuxdriver.com>2009-07-24 15:05:14 -0400
commitfe643414dbf330d6d910e01edd48dd93dc6f2942 (patch)
treea4db7f0290aad3541da254dc3f5e287a5c733e25 /drivers/net/wireless/wl12xx/wl1251_main.c
parenta94ca4e7af0e6b63ef5345750fad8e1400274ba4 (diff)
wireless: wl12xx, fix lock imbalance
Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when wl12xx_chip_wakeup fails). [v2] Power off the device, because: \= cite from http://marc.info/?l=linux-kernel&m=124755028209880&w=2 If the chip cannot be booted, why should it remain powered on? In some rare cases, the chip might fail to initialize, but can recover if powered off and on again, so turning it off at this point is the right thing to do. =/ Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/wl12xx/wl1251_main.c')
-rw-r--r--drivers/net/wireless/wl12xx/wl1251_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/wl12xx/wl1251_main.c b/drivers/net/wireless/wl12xx/wl1251_main.c
index cf5e0549fa14..106b0f265192 100644
--- a/drivers/net/wireless/wl12xx/wl1251_main.c
+++ b/drivers/net/wireless/wl12xx/wl1251_main.c
@@ -349,7 +349,7 @@ static int wl1251_op_start(struct ieee80211_hw *hw)
349 349
350 ret = wl1251_chip_wakeup(wl); 350 ret = wl1251_chip_wakeup(wl);
351 if (ret < 0) 351 if (ret < 0)
352 return ret; 352 goto out;
353 353
354 ret = wl->chip.op_boot(wl); 354 ret = wl->chip.op_boot(wl);
355 if (ret < 0) 355 if (ret < 0)