drivers/net: Convert compare_ether_addr to ether_addr_equal

Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Done via cocci script:

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
-	!compare_ether_addr(a, b)
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	compare_ether_addr(a, b)
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) == 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) != 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) == 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) != 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!!ether_addr_equal(a, b)
+	ether_addr_equal(a, b)

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

6 files changed, 24 insertions, 22 deletions

diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c
index e54488db0e10..f4c852c6749b 100644
--- a/drivers/net/wireless/rtlwifi/base.c
+++ b/drivers/net/wireless/rtlwifi/base.c
@@ -1460,7 +1460,7 @@ void rtl_recognize_peer(struct ieee80211_hw *hw, u8 *data, unsigned int len)
                 return;
 
         /* and only beacons from the associated BSSID, please */
-        if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
+        if (!ether_addr_equal(hdr->addr3, rtlpriv->mac80211.bssid))
                 return;
 
         if (rtl_find_221_ie(hw, data, len))
diff --git a/drivers/net/wireless/rtlwifi/ps.c b/drivers/net/wireless/rtlwifi/ps.c
index 5b9c3b5e8c92..5ae26647f340 100644
--- a/drivers/net/wireless/rtlwifi/ps.c
+++ b/drivers/net/wireless/rtlwifi/ps.c
@@ -480,7 +480,7 @@ void rtl_swlps_beacon(struct ieee80211_hw *hw, void *data, unsigned int len)
                 return;
 
         /* and only beacons from the associated BSSID, please */
-        if (compare_ether_addr(hdr->addr3, rtlpriv->mac80211.bssid))
+        if (!ether_addr_equal(hdr->addr3, rtlpriv->mac80211.bssid))
                 return;
 
         rtlpriv->psc.last_beacon = jiffies;
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index 37b13636a778..3af874e69595 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -508,14 +508,14 @@ static void _rtl92ce_translate_rx_signal_stuff(struct ieee80211_hw *hw,
 
         packet_matchbssid =
             ((IEEE80211_FTYPE_CTL != type) &&
-             (!compare_ether_addr(mac->bssid,
-                                  (c_fc & IEEE80211_FCTL_TODS) ?
-                                  hdr->addr1 : (c_fc & IEEE80211_FCTL_FROMDS) ?
-                                  hdr->addr2 : hdr->addr3)) &&
+             ether_addr_equal(mac->bssid,
+                              (c_fc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
+                              (c_fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
+                              hdr->addr3) &&
              (!pstats->hwerror) && (!pstats->crc) && (!pstats->icv));
 
         packet_toself = packet_matchbssid &&
-            (!compare_ether_addr(praddr, rtlefuse->dev_addr));
+             ether_addr_equal(praddr, rtlefuse->dev_addr);
 
         if (ieee80211_is_beacon(fc))
                 packet_beacon = true;
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c
index 025bdc2eba44..7e91c76582ec 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c
@@ -1099,14 +1099,14 @@ void rtl92c_translate_rx_signal_stuff(struct ieee80211_hw *hw,
         praddr = hdr->addr1;
         packet_matchbssid =
             ((IEEE80211_FTYPE_CTL != type) &&
-             (!compare_ether_addr(mac->bssid,
-                          (cpu_fc & IEEE80211_FCTL_TODS) ?
-                          hdr->addr1 : (cpu_fc & IEEE80211_FCTL_FROMDS) ?
-                          hdr->addr2 : hdr->addr3)) &&
+             ether_addr_equal(mac->bssid,
+                              (cpu_fc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
+                              (cpu_fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
+                              hdr->addr3) &&
              (!pstats->hwerror) && (!pstats->crc) && (!pstats->icv));
 
         packet_toself = packet_matchbssid &&
-            (!compare_ether_addr(praddr, rtlefuse->dev_addr));
+            ether_addr_equal(praddr, rtlefuse->dev_addr);
         if (ieee80211_is_beacon(fc))
                 packet_beacon = true;
         _rtl92c_query_rxphystatus(hw, pstats, pdesc, p_drvinfo,
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c
index a7f6126e2f86..1666ef7fd87b 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c
@@ -466,12 +466,13 @@ static void _rtl92de_translate_rx_signal_stuff(struct ieee80211_hw *hw,
         type = WLAN_FC_GET_TYPE(fc);
         praddr = hdr->addr1;
         packet_matchbssid = ((IEEE80211_FTYPE_CTL != type) &&
-             (!compare_ether_addr(mac->bssid, (cfc & IEEE80211_FCTL_TODS) ?
-                  hdr->addr1 : (cfc & IEEE80211_FCTL_FROMDS) ?
-                  hdr->addr2 : hdr->addr3)) && (!pstats->hwerror) &&
-                  (!pstats->crc) && (!pstats->icv));
+             ether_addr_equal(mac->bssid,
+                              (cfc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
+                              (cfc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
+                              hdr->addr3) &&
+             (!pstats->hwerror) && (!pstats->crc) && (!pstats->icv));
         packet_toself = packet_matchbssid &&
-                        (!compare_ether_addr(praddr, rtlefuse->dev_addr));
+                        ether_addr_equal(praddr, rtlefuse->dev_addr);
         if (ieee80211_is_beacon(fc))
                 packet_beacon = true;
         _rtl92de_query_rxphystatus(hw, pstats, pdesc, p_drvinfo,
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
index 2fd3d13b7ced..812b5858f14a 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c
@@ -492,13 +492,14 @@ static void _rtl92se_translate_rx_signal_stuff(struct ieee80211_hw *hw,
         praddr = hdr->addr1;
 
         packet_matchbssid = ((IEEE80211_FTYPE_CTL != type) &&
-             (!compare_ether_addr(mac->bssid, (cfc & IEEE80211_FCTL_TODS) ?
-                        hdr->addr1 : (cfc & IEEE80211_FCTL_FROMDS) ?
-                        hdr->addr2 : hdr->addr3)) && (!pstats->hwerror) &&
-                        (!pstats->crc) && (!pstats->icv));
+             ether_addr_equal(mac->bssid,
+                              (cfc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
+                              (cfc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
+                              hdr->addr3) &&
+             (!pstats->hwerror) && (!pstats->crc) && (!pstats->icv));
 
         packet_toself = packet_matchbssid &&
-            (!compare_ether_addr(praddr, rtlefuse->dev_addr));
+            ether_addr_equal(praddr, rtlefuse->dev_addr);
 
         if (ieee80211_is_beacon(fc))
                 packet_beacon = true;