diff options
author | Joe Perches <joe@perches.com> | 2013-02-03 12:28:14 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-02-04 13:22:34 -0500 |
commit | 0d2e7a5c608063f72048899d20505c2ee130566c (patch) | |
tree | 4eae4acaf7c04bb60337389aaef8065c00b1737a /drivers/net/wireless/prism54 | |
parent | 9d11bd1592fba0b9231d3ce8ab61977db7e03e27 (diff) |
wireless: Remove unnecessary alloc/OOM messages, alloc cleanups
alloc failures already get standardized OOM
messages and a dump_stack.
Convert kzalloc's with multiplies to kcalloc.
Convert kmalloc's with multiplies to kmalloc_array.
Remove now unused variables.
Remove unnecessary memset after kzalloc->kcalloc.
Whitespace cleanups for these changes.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wireless/prism54')
-rw-r--r-- | drivers/net/wireless/prism54/islpci_mgt.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/net/wireless/prism54/islpci_mgt.c b/drivers/net/wireless/prism54/islpci_mgt.c index c5404cb59e08..9f19cceab487 100644 --- a/drivers/net/wireless/prism54/islpci_mgt.c +++ b/drivers/net/wireless/prism54/islpci_mgt.c | |||
@@ -123,11 +123,8 @@ islpci_mgmt_rx_fill(struct net_device *ndev) | |||
123 | 123 | ||
124 | if (buf->mem == NULL) { | 124 | if (buf->mem == NULL) { |
125 | buf->mem = kmalloc(MGMT_FRAME_SIZE, GFP_ATOMIC); | 125 | buf->mem = kmalloc(MGMT_FRAME_SIZE, GFP_ATOMIC); |
126 | if (!buf->mem) { | 126 | if (!buf->mem) |
127 | printk(KERN_WARNING | ||
128 | "Error allocating management frame.\n"); | ||
129 | return -ENOMEM; | 127 | return -ENOMEM; |
130 | } | ||
131 | buf->size = MGMT_FRAME_SIZE; | 128 | buf->size = MGMT_FRAME_SIZE; |
132 | } | 129 | } |
133 | if (buf->pci_addr == 0) { | 130 | if (buf->pci_addr == 0) { |
@@ -356,14 +353,11 @@ islpci_mgt_receive(struct net_device *ndev) | |||
356 | 353 | ||
357 | /* Determine frame size, skipping OID_INL_TUNNEL headers. */ | 354 | /* Determine frame size, skipping OID_INL_TUNNEL headers. */ |
358 | size = PIMFOR_HEADER_SIZE + header->length; | 355 | size = PIMFOR_HEADER_SIZE + header->length; |
359 | frame = kmalloc(sizeof (struct islpci_mgmtframe) + size, | 356 | frame = kmalloc(sizeof(struct islpci_mgmtframe) + size, |
360 | GFP_ATOMIC); | 357 | GFP_ATOMIC); |
361 | if (!frame) { | 358 | if (!frame) |
362 | printk(KERN_WARNING | ||
363 | "%s: Out of memory, cannot handle oid 0x%08x\n", | ||
364 | ndev->name, header->oid); | ||
365 | continue; | 359 | continue; |
366 | } | 360 | |
367 | frame->ndev = ndev; | 361 | frame->ndev = ndev; |
368 | memcpy(&frame->buf, header, size); | 362 | memcpy(&frame->buf, header, size); |
369 | frame->header = (pimfor_header_t *) frame->buf; | 363 | frame->header = (pimfor_header_t *) frame->buf; |