diff options
author | Daniel Drake <dsd@laptop.org> | 2012-03-14 18:34:33 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-03-15 13:46:50 -0400 |
commit | 377526578f2c343ea281a918b18ece1fca65005c (patch) | |
tree | f7968ebd2156f6471fafee8ee6c7c5e6b76383a3 /drivers/net/wireless/libertas | |
parent | 783b732ac61dd6c653cc2367f389a6234db8cc16 (diff) |
libertas: remove dump_survey implementation
libertas provides a dump_survey implementation based on reading of
a RSSI value. However, this RSSI value is calculated based on the
last received beacon from the associated AP - it is not a good
way of surveying a channel in general, and even causes an error
if the card is not associated to a network.
As this is not appropriate as a survey, remove it. This fixes an
issue where something in userspace is repeatedly calling site-survey
during boot, resulting in many repeated errors as the RSSI value cannot
be read before associating.
Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/libertas')
-rw-r--r-- | drivers/net/wireless/libertas/cfg.c | 37 |
1 files changed, 0 insertions, 37 deletions
diff --git a/drivers/net/wireless/libertas/cfg.c b/drivers/net/wireless/libertas/cfg.c index a7cd311cb1b7..3fa1ecebadfd 100644 --- a/drivers/net/wireless/libertas/cfg.c +++ b/drivers/net/wireless/libertas/cfg.c | |||
@@ -1631,42 +1631,6 @@ static int lbs_cfg_get_station(struct wiphy *wiphy, struct net_device *dev, | |||
1631 | 1631 | ||
1632 | 1632 | ||
1633 | /* | 1633 | /* |
1634 | * "Site survey", here just current channel and noise level | ||
1635 | */ | ||
1636 | |||
1637 | static int lbs_get_survey(struct wiphy *wiphy, struct net_device *dev, | ||
1638 | int idx, struct survey_info *survey) | ||
1639 | { | ||
1640 | struct lbs_private *priv = wiphy_priv(wiphy); | ||
1641 | s8 signal, noise; | ||
1642 | int ret; | ||
1643 | |||
1644 | if (dev == priv->mesh_dev) | ||
1645 | return -EOPNOTSUPP; | ||
1646 | |||
1647 | if (idx != 0) | ||
1648 | ret = -ENOENT; | ||
1649 | |||
1650 | lbs_deb_enter(LBS_DEB_CFG80211); | ||
1651 | |||
1652 | survey->channel = ieee80211_get_channel(wiphy, | ||
1653 | ieee80211_channel_to_frequency(priv->channel, | ||
1654 | IEEE80211_BAND_2GHZ)); | ||
1655 | |||
1656 | ret = lbs_get_rssi(priv, &signal, &noise); | ||
1657 | if (ret == 0) { | ||
1658 | survey->filled = SURVEY_INFO_NOISE_DBM; | ||
1659 | survey->noise = noise; | ||
1660 | } | ||
1661 | |||
1662 | lbs_deb_leave_args(LBS_DEB_CFG80211, "ret %d", ret); | ||
1663 | return ret; | ||
1664 | } | ||
1665 | |||
1666 | |||
1667 | |||
1668 | |||
1669 | /* | ||
1670 | * Change interface | 1634 | * Change interface |
1671 | */ | 1635 | */ |
1672 | 1636 | ||
@@ -2068,7 +2032,6 @@ static struct cfg80211_ops lbs_cfg80211_ops = { | |||
2068 | .del_key = lbs_cfg_del_key, | 2032 | .del_key = lbs_cfg_del_key, |
2069 | .set_default_key = lbs_cfg_set_default_key, | 2033 | .set_default_key = lbs_cfg_set_default_key, |
2070 | .get_station = lbs_cfg_get_station, | 2034 | .get_station = lbs_cfg_get_station, |
2071 | .dump_survey = lbs_get_survey, | ||
2072 | .change_virtual_intf = lbs_change_intf, | 2035 | .change_virtual_intf = lbs_change_intf, |
2073 | .join_ibss = lbs_join_ibss, | 2036 | .join_ibss = lbs_join_ibss, |
2074 | .leave_ibss = lbs_leave_ibss, | 2037 | .leave_ibss = lbs_leave_ibss, |