diff options
author | David Woodhouse <dwmw2@infradead.org> | 2007-12-12 00:41:51 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:07:00 -0500 |
commit | a27b9f96f21a2f15c423cca745f65de3db61e364 (patch) | |
tree | 31703fb9de80eb03279eaeb730d279296979cc26 /drivers/net/wireless/libertas/scan.c | |
parent | 23d36eec263d2c913ee651dc43472524397e4a0b (diff) |
libertas: slight cleanup of netif queue stop/wake
In particular, we shouldn't be waking the queues in lbs_host_to_card_done()
any more.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/libertas/scan.c')
-rw-r--r-- | drivers/net/wireless/libertas/scan.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c index 92d84c72e2a9..9a61188b62e9 100644 --- a/drivers/net/wireless/libertas/scan.c +++ b/drivers/net/wireless/libertas/scan.c | |||
@@ -590,13 +590,13 @@ int lbs_scan_networks(struct lbs_private *priv, | |||
590 | netif_stop_queue(priv->dev); | 590 | netif_stop_queue(priv->dev); |
591 | netif_carrier_off(priv->dev); | 591 | netif_carrier_off(priv->dev); |
592 | if (priv->mesh_dev) { | 592 | if (priv->mesh_dev) { |
593 | netif_stop_queue(priv->mesh_dev); | 593 | netif_stop_queue(priv->mesh_dev); |
594 | netif_carrier_off(priv->mesh_dev); | 594 | netif_carrier_off(priv->mesh_dev); |
595 | } | 595 | } |
596 | 596 | ||
597 | /* Prepare to continue an interrupted scan */ | 597 | /* Prepare to continue an interrupted scan */ |
598 | lbs_deb_scan("chan_count %d, last_scanned_channel %d\n", | 598 | lbs_deb_scan("chan_count %d, last_scanned_channel %d\n", |
599 | chan_count, priv->last_scanned_channel); | 599 | chan_count, priv->last_scanned_channel); |
600 | curr_chans = chan_list; | 600 | curr_chans = chan_list; |
601 | /* advance channel list by already-scanned-channels */ | 601 | /* advance channel list by already-scanned-channels */ |
602 | if (priv->last_scanned_channel > 0) { | 602 | if (priv->last_scanned_channel > 0) { |
@@ -659,11 +659,13 @@ out2: | |||
659 | out: | 659 | out: |
660 | if (priv->connect_status == LBS_CONNECTED) { | 660 | if (priv->connect_status == LBS_CONNECTED) { |
661 | netif_carrier_on(priv->dev); | 661 | netif_carrier_on(priv->dev); |
662 | netif_wake_queue(priv->dev); | 662 | if (!priv->tx_pending_len) |
663 | netif_wake_queue(priv->dev); | ||
663 | } | 664 | } |
664 | if (priv->mesh_dev && (priv->mesh_connect_status == LBS_CONNECTED)) { | 665 | if (priv->mesh_dev && (priv->mesh_connect_status == LBS_CONNECTED)) { |
665 | netif_carrier_on(priv->mesh_dev); | 666 | netif_carrier_on(priv->mesh_dev); |
666 | netif_wake_queue(priv->mesh_dev); | 667 | if (!priv->tx_pending_len) |
668 | netif_wake_queue(priv->mesh_dev); | ||
667 | } | 669 | } |
668 | kfree(chan_list); | 670 | kfree(chan_list); |
669 | 671 | ||