diff options
author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2011-08-26 02:10:35 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-08-29 15:25:30 -0400 |
commit | a294b96f25f2d436c90ca54d91e13461696cbcd4 (patch) | |
tree | 6265763e62d8d46d9f2652979900586972a18adf /drivers/net/wireless/iwlwifi/iwl-core.c | |
parent | f293bd1aeab7c4937c1688bd346c3910f7c73de0 (diff) |
iwlagn: use iwl_get_debug_level instead of iwl_debug_level
The latter may return incomplete information.
For example, if one switched IWL_DL_TX on through sysfs, IWL_DL_TX bit would
have been set in priv->debug_level, but since iwl_alloc_traffic_mem looked at
iwl_debug_level only, it wouldn't have allocated the tx_traffic buffer.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/iwl-core.c')
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-core.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c index e1c5f5988fef..0d8fd5b0cd7c 100644 --- a/drivers/net/wireless/iwlwifi/iwl-core.c +++ b/drivers/net/wireless/iwlwifi/iwl-core.c | |||
@@ -1398,7 +1398,7 @@ int iwl_alloc_traffic_mem(struct iwl_priv *priv) | |||
1398 | { | 1398 | { |
1399 | u32 traffic_size = IWL_TRAFFIC_DUMP_SIZE; | 1399 | u32 traffic_size = IWL_TRAFFIC_DUMP_SIZE; |
1400 | 1400 | ||
1401 | if (iwl_debug_level & IWL_DL_TX) { | 1401 | if (iwl_get_debug_level(priv) & IWL_DL_TX) { |
1402 | if (!priv->tx_traffic) { | 1402 | if (!priv->tx_traffic) { |
1403 | priv->tx_traffic = | 1403 | priv->tx_traffic = |
1404 | kzalloc(traffic_size, GFP_KERNEL); | 1404 | kzalloc(traffic_size, GFP_KERNEL); |
@@ -1406,7 +1406,7 @@ int iwl_alloc_traffic_mem(struct iwl_priv *priv) | |||
1406 | return -ENOMEM; | 1406 | return -ENOMEM; |
1407 | } | 1407 | } |
1408 | } | 1408 | } |
1409 | if (iwl_debug_level & IWL_DL_RX) { | 1409 | if (iwl_get_debug_level(priv) & IWL_DL_RX) { |
1410 | if (!priv->rx_traffic) { | 1410 | if (!priv->rx_traffic) { |
1411 | priv->rx_traffic = | 1411 | priv->rx_traffic = |
1412 | kzalloc(traffic_size, GFP_KERNEL); | 1412 | kzalloc(traffic_size, GFP_KERNEL); |
@@ -1433,7 +1433,7 @@ void iwl_dbg_log_tx_data_frame(struct iwl_priv *priv, | |||
1433 | __le16 fc; | 1433 | __le16 fc; |
1434 | u16 len; | 1434 | u16 len; |
1435 | 1435 | ||
1436 | if (likely(!(iwl_debug_level & IWL_DL_TX))) | 1436 | if (likely(!(iwl_get_debug_level(priv) & IWL_DL_TX))) |
1437 | return; | 1437 | return; |
1438 | 1438 | ||
1439 | if (!priv->tx_traffic) | 1439 | if (!priv->tx_traffic) |
@@ -1457,7 +1457,7 @@ void iwl_dbg_log_rx_data_frame(struct iwl_priv *priv, | |||
1457 | __le16 fc; | 1457 | __le16 fc; |
1458 | u16 len; | 1458 | u16 len; |
1459 | 1459 | ||
1460 | if (likely(!(iwl_debug_level & IWL_DL_RX))) | 1460 | if (likely(!(iwl_get_debug_level(priv) & IWL_DL_RX))) |
1461 | return; | 1461 | return; |
1462 | 1462 | ||
1463 | if (!priv->rx_traffic) | 1463 | if (!priv->rx_traffic) |