diff options
| author | Arend van Spriel <arend@broadcom.com> | 2012-12-07 04:49:57 -0500 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2012-12-10 15:33:06 -0500 |
| commit | 5e8149f5036afe2d94b5fafc9ff752283804a752 (patch) | |
| tree | b21016be1f39e649b4b79a4abfb75e93fecfe7b9 /drivers/net/wireless/brcm80211/brcmfmac/fweh.c | |
| parent | dc5cbdfdf7936178361c386de84aaf64e8842789 (diff) | |
brcmfmac: error messages should not be suppressed
The call to brcmf_dbg(ERROR, ...) only resulted in a log message
when compiled with -DDEBUG. Error messages are valuable for resolving
issues so this patch replaces it with brcmf_err(...) so they always
end up in the log.
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/brcm80211/brcmfmac/fweh.c')
| -rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/fweh.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c index c26493fb01b6..ba0b22512f12 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c | |||
| @@ -157,9 +157,9 @@ static int brcmf_fweh_call_event_handler(struct brcmf_if *ifp, | |||
| 157 | if (ifp->ndev && fweh->evt_handler[code]) | 157 | if (ifp->ndev && fweh->evt_handler[code]) |
| 158 | err = fweh->evt_handler[code](ifp, emsg, data); | 158 | err = fweh->evt_handler[code](ifp, emsg, data); |
| 159 | else | 159 | else |
| 160 | brcmf_dbg(ERROR, "unhandled event %d ignored\n", code); | 160 | brcmf_err("unhandled event %d ignored\n", code); |
| 161 | } else { | 161 | } else { |
| 162 | brcmf_dbg(ERROR, "no interface object\n"); | 162 | brcmf_err("no interface object\n"); |
| 163 | } | 163 | } |
| 164 | return err; | 164 | return err; |
| 165 | } | 165 | } |
| @@ -184,7 +184,7 @@ static void brcmf_fweh_handle_if_event(struct brcmf_pub *drvr, | |||
| 184 | ifevent->bssidx, ifevent->flags); | 184 | ifevent->bssidx, ifevent->flags); |
| 185 | 185 | ||
| 186 | if (ifevent->ifidx >= BRCMF_MAX_IFS) { | 186 | if (ifevent->ifidx >= BRCMF_MAX_IFS) { |
| 187 | brcmf_dbg(ERROR, "invalid interface index: %u\n", | 187 | brcmf_err("invalid interface index: %u\n", |
| 188 | ifevent->ifidx); | 188 | ifevent->ifidx); |
| 189 | return; | 189 | return; |
| 190 | } | 190 | } |
| @@ -286,7 +286,7 @@ static void brcmf_fweh_event_worker(struct work_struct *work) | |||
| 286 | err = brcmf_fweh_call_event_handler(ifp, event->code, &emsg, | 286 | err = brcmf_fweh_call_event_handler(ifp, event->code, &emsg, |
| 287 | event->data); | 287 | event->data); |
| 288 | if (err) { | 288 | if (err) { |
| 289 | brcmf_dbg(ERROR, "event handler failed (%d)\n", | 289 | brcmf_err("event handler failed (%d)\n", |
| 290 | event->code); | 290 | event->code); |
| 291 | err = 0; | 291 | err = 0; |
| 292 | } | 292 | } |
| @@ -343,7 +343,7 @@ int brcmf_fweh_register(struct brcmf_pub *drvr, enum brcmf_fweh_event_code code, | |||
| 343 | brcmf_fweh_handler_t handler) | 343 | brcmf_fweh_handler_t handler) |
| 344 | { | 344 | { |
| 345 | if (drvr->fweh.evt_handler[code]) { | 345 | if (drvr->fweh.evt_handler[code]) { |
| 346 | brcmf_dbg(ERROR, "event code %d already registered\n", code); | 346 | brcmf_err("event code %d already registered\n", code); |
| 347 | return -ENOSPC; | 347 | return -ENOSPC; |
| 348 | } | 348 | } |
| 349 | drvr->fweh.evt_handler[code] = handler; | 349 | drvr->fweh.evt_handler[code] = handler; |
| @@ -391,7 +391,7 @@ int brcmf_fweh_activate_events(struct brcmf_if *ifp) | |||
| 391 | err = brcmf_fil_iovar_data_set(ifp, "event_msgs", | 391 | err = brcmf_fil_iovar_data_set(ifp, "event_msgs", |
| 392 | eventmask, BRCMF_EVENTING_MASK_LEN); | 392 | eventmask, BRCMF_EVENTING_MASK_LEN); |
| 393 | if (err) | 393 | if (err) |
| 394 | brcmf_dbg(ERROR, "Set event_msgs error (%d)\n", err); | 394 | brcmf_err("Set event_msgs error (%d)\n", err); |
| 395 | 395 | ||
| 396 | return err; | 396 | return err; |
| 397 | } | 397 | } |