aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/ath
diff options
context:
space:
mode:
authorPavel Roskin <proski@gnu.org>2011-07-07 18:14:13 -0400
committerJohn W. Linville <linville@tuxdriver.com>2011-07-08 11:44:32 -0400
commite4bbf2f541501dcde47ce687ffc6d238bd2f7813 (patch)
tree00d4225183178e68067566d33b01cda299943062 /drivers/net/wireless/ath
parentd2c7f7730e5660c812765acd57516f709ea35fc0 (diff)
ath5k: fix formatting errors found by checkpatch.pl
Signed-off-by: Pavel Roskin <proski@gnu.org> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/ath')
-rw-r--r--drivers/net/wireless/ath/ath5k/ahb.c4
-rw-r--r--drivers/net/wireless/ath/ath5k/ani.c2
-rw-r--r--drivers/net/wireless/ath/ath5k/ath5k.h21
-rw-r--r--drivers/net/wireless/ath/ath5k/attach.c17
-rw-r--r--drivers/net/wireless/ath/ath5k/base.c24
-rw-r--r--drivers/net/wireless/ath/ath5k/base.h4
-rw-r--r--drivers/net/wireless/ath/ath5k/debug.c204
-rw-r--r--drivers/net/wireless/ath/ath5k/dma.c2
-rw-r--r--drivers/net/wireless/ath/ath5k/eeprom.c20
-rw-r--r--drivers/net/wireless/ath/ath5k/eeprom.h2
-rw-r--r--drivers/net/wireless/ath/ath5k/led.c4
-rw-r--r--drivers/net/wireless/ath/ath5k/pci.c2
-rw-r--r--drivers/net/wireless/ath/ath5k/pcu.c2
-rw-r--r--drivers/net/wireless/ath/ath5k/phy.c46
-rw-r--r--drivers/net/wireless/ath/ath5k/reset.c8
15 files changed, 182 insertions, 180 deletions
diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index c38e9e848995..ba682a0b2dd8 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -167,8 +167,8 @@ static int ath_ahb_probe(struct platform_device *pdev)
167 * driver for it 167 * driver for it
168 */ 168 */
169 if (to_platform_device(sc->dev)->id == 0 && 169 if (to_platform_device(sc->dev)->id == 0 &&
170 (bcfg->config->flags & (BD_WLAN0|BD_WLAN1)) == 170 (bcfg->config->flags & (BD_WLAN0 | BD_WLAN1)) ==
171 (BD_WLAN1|BD_WLAN0)) 171 (BD_WLAN1 | BD_WLAN0))
172 __set_bit(ATH_STAT_2G_DISABLED, sc->status); 172 __set_bit(ATH_STAT_2G_DISABLED, sc->status);
173 } 173 }
174 174
diff --git a/drivers/net/wireless/ath/ath5k/ani.c b/drivers/net/wireless/ath/ath5k/ani.c
index f915f404302d..a08f17318e63 100644
--- a/drivers/net/wireless/ath/ath5k/ani.c
+++ b/drivers/net/wireless/ath/ath5k/ani.c
@@ -642,7 +642,7 @@ ath5k_ani_init(struct ath5k_hw *ah, enum ath5k_ani_mode mode)
642 /* initial values for our ani parameters */ 642 /* initial values for our ani parameters */
643 if (mode == ATH5K_ANI_MODE_OFF) { 643 if (mode == ATH5K_ANI_MODE_OFF) {
644 ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI, "ANI off\n"); 644 ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI, "ANI off\n");
645 } else if (mode == ATH5K_ANI_MODE_MANUAL_LOW) { 645 } else if (mode == ATH5K_ANI_MODE_MANUAL_LOW) {
646 ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI, 646 ATH5K_DBG_UNLIMIT(ah->ah_sc, ATH5K_DEBUG_ANI,
647 "ANI manual low -> high sensitivity\n"); 647 "ANI manual low -> high sensitivity\n");
648 ath5k_ani_set_noise_immunity_level(ah, 0); 648 ath5k_ani_set_noise_immunity_level(ah, 0);
diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k/ath5k.h
index 68163428fdb2..b1de4a09c8c8 100644
--- a/drivers/net/wireless/ath/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath/ath5k/ath5k.h
@@ -362,7 +362,7 @@ struct ath5k_srev_name {
362/* 362/*
363 * Some of this information is based on Documentation from: 363 * Some of this information is based on Documentation from:
364 * 364 *
365 * http://madwifi-project.org/wiki/ChipsetFeatures/SuperAG 365 * http://madwifi-project.org/wiki/ChipsetFeatures/SuperAG
366 * 366 *
367 * Modulation for Atheros' eXtended Range - range enhancing extension that is 367 * Modulation for Atheros' eXtended Range - range enhancing extension that is
368 * supposed to double the distance an Atheros client device can keep a 368 * supposed to double the distance an Atheros client device can keep a
@@ -617,8 +617,8 @@ struct ath5k_rx_status {
617#define AR5K_RXERR_FIFO 0x04 617#define AR5K_RXERR_FIFO 0x04
618#define AR5K_RXERR_DECRYPT 0x08 618#define AR5K_RXERR_DECRYPT 0x08
619#define AR5K_RXERR_MIC 0x10 619#define AR5K_RXERR_MIC 0x10
620#define AR5K_RXKEYIX_INVALID ((u8) - 1) 620#define AR5K_RXKEYIX_INVALID ((u8) -1)
621#define AR5K_TXKEYIX_INVALID ((u32) - 1) 621#define AR5K_TXKEYIX_INVALID ((u32) -1)
622 622
623 623
624/**************************\ 624/**************************\
@@ -679,12 +679,13 @@ struct ath5k_gain {
679#define CHANNEL_DYN 0x0400 /* Dynamic CCK-OFDM channel (for g operation) */ 679#define CHANNEL_DYN 0x0400 /* Dynamic CCK-OFDM channel (for g operation) */
680#define CHANNEL_XR 0x0800 /* XR channel */ 680#define CHANNEL_XR 0x0800 /* XR channel */
681 681
682#define CHANNEL_A (CHANNEL_5GHZ|CHANNEL_OFDM) 682#define CHANNEL_A (CHANNEL_5GHZ | CHANNEL_OFDM)
683#define CHANNEL_B (CHANNEL_2GHZ|CHANNEL_CCK) 683#define CHANNEL_B (CHANNEL_2GHZ | CHANNEL_CCK)
684#define CHANNEL_G (CHANNEL_2GHZ|CHANNEL_OFDM) 684#define CHANNEL_G (CHANNEL_2GHZ | CHANNEL_OFDM)
685#define CHANNEL_X (CHANNEL_5GHZ|CHANNEL_OFDM|CHANNEL_XR) 685#define CHANNEL_X (CHANNEL_5GHZ | CHANNEL_OFDM | CHANNEL_XR)
686 686
687#define CHANNEL_ALL (CHANNEL_OFDM|CHANNEL_CCK|CHANNEL_2GHZ|CHANNEL_5GHZ) 687#define CHANNEL_ALL (CHANNEL_OFDM | CHANNEL_CCK | \
688 CHANNEL_2GHZ | CHANNEL_5GHZ)
688 689
689#define CHANNEL_MODES CHANNEL_ALL 690#define CHANNEL_MODES CHANNEL_ALL
690 691
@@ -777,7 +778,7 @@ extern int ath5k_modparam_nohwcrypt;
777/* 778/*
778 * Misc definitions 779 * Misc definitions
779 */ 780 */
780#define AR5K_RSSI_EP_MULTIPLIER (1<<7) 781#define AR5K_RSSI_EP_MULTIPLIER (1 << 7)
781 782
782#define AR5K_ASSERT_ENTRY(_e, _s) do { \ 783#define AR5K_ASSERT_ENTRY(_e, _s) do { \
783 if (_e >= _s) \ 784 if (_e >= _s) \
@@ -1378,7 +1379,7 @@ static inline void __iomem *ath5k_ahb_reg(struct ath5k_hw *ah, u16 reg)
1378 /* On AR2315 and AR2317 the PCI clock domain registers 1379 /* On AR2315 and AR2317 the PCI clock domain registers
1379 * are outside of the WMAC register space */ 1380 * are outside of the WMAC register space */
1380 if (unlikely((reg >= 0x4000) && (reg < 0x5000) && 1381 if (unlikely((reg >= 0x4000) && (reg < 0x5000) &&
1381 (ah->ah_mac_srev >= AR5K_SREV_AR2315_R6))) 1382 (ah->ah_mac_srev >= AR5K_SREV_AR2315_R6)))
1382 return AR5K_AR2315_PCI_BASE + reg; 1383 return AR5K_AR2315_PCI_BASE + reg;
1383 1384
1384 return ah->ah_iobase + reg; 1385 return ah->ah_iobase + reg;
diff --git a/drivers/net/wireless/ath/ath5k/attach.c b/drivers/net/wireless/ath/ath5k/attach.c
index f781eeb50852..d6fbb57a5d98 100644
--- a/drivers/net/wireless/ath/ath5k/attach.c
+++ b/drivers/net/wireless/ath/ath5k/attach.c
@@ -192,7 +192,7 @@ int ath5k_hw_init(struct ath5k_softc *sc)
192 break; 192 break;
193 case AR5K_SREV_RAD_5424: 193 case AR5K_SREV_RAD_5424:
194 if (ah->ah_mac_version == AR5K_SREV_AR2425 || 194 if (ah->ah_mac_version == AR5K_SREV_AR2425 ||
195 ah->ah_mac_version == AR5K_SREV_AR2417){ 195 ah->ah_mac_version == AR5K_SREV_AR2417) {
196 ah->ah_radio = AR5K_RF2425; 196 ah->ah_radio = AR5K_RF2425;
197 ah->ah_single_chip = true; 197 ah->ah_single_chip = true;
198 } else { 198 } else {
@@ -211,28 +211,28 @@ int ath5k_hw_init(struct ath5k_softc *sc)
211 ah->ah_radio_2ghz_revision = ath5k_hw_radio_revision(ah, 211 ah->ah_radio_2ghz_revision = ath5k_hw_radio_revision(ah,
212 CHANNEL_2GHZ); 212 CHANNEL_2GHZ);
213 } else if (ah->ah_mac_version == (AR5K_SREV_AR2425 >> 4) || 213 } else if (ah->ah_mac_version == (AR5K_SREV_AR2425 >> 4) ||
214 ah->ah_mac_version == (AR5K_SREV_AR2417 >> 4) || 214 ah->ah_mac_version == (AR5K_SREV_AR2417 >> 4) ||
215 ah->ah_phy_revision == AR5K_SREV_PHY_2425) { 215 ah->ah_phy_revision == AR5K_SREV_PHY_2425) {
216 ah->ah_radio = AR5K_RF2425; 216 ah->ah_radio = AR5K_RF2425;
217 ah->ah_single_chip = true; 217 ah->ah_single_chip = true;
218 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_2425; 218 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_2425;
219 } else if (srev == AR5K_SREV_AR5213A && 219 } else if (srev == AR5K_SREV_AR5213A &&
220 ah->ah_phy_revision == AR5K_SREV_PHY_5212B) { 220 ah->ah_phy_revision == AR5K_SREV_PHY_5212B) {
221 ah->ah_radio = AR5K_RF5112; 221 ah->ah_radio = AR5K_RF5112;
222 ah->ah_single_chip = false; 222 ah->ah_single_chip = false;
223 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_5112B; 223 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_5112B;
224 } else if (ah->ah_mac_version == (AR5K_SREV_AR2415 >> 4) || 224 } else if (ah->ah_mac_version == (AR5K_SREV_AR2415 >> 4) ||
225 ah->ah_mac_version == (AR5K_SREV_AR2315_R6 >> 4)) { 225 ah->ah_mac_version == (AR5K_SREV_AR2315_R6 >> 4)) {
226 ah->ah_radio = AR5K_RF2316; 226 ah->ah_radio = AR5K_RF2316;
227 ah->ah_single_chip = true; 227 ah->ah_single_chip = true;
228 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_2316; 228 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_2316;
229 } else if (ah->ah_mac_version == (AR5K_SREV_AR5414 >> 4) || 229 } else if (ah->ah_mac_version == (AR5K_SREV_AR5414 >> 4) ||
230 ah->ah_phy_revision == AR5K_SREV_PHY_5413) { 230 ah->ah_phy_revision == AR5K_SREV_PHY_5413) {
231 ah->ah_radio = AR5K_RF5413; 231 ah->ah_radio = AR5K_RF5413;
232 ah->ah_single_chip = true; 232 ah->ah_single_chip = true;
233 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_5413; 233 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_5413;
234 } else if (ah->ah_mac_version == (AR5K_SREV_AR2414 >> 4) || 234 } else if (ah->ah_mac_version == (AR5K_SREV_AR2414 >> 4) ||
235 ah->ah_phy_revision == AR5K_SREV_PHY_2413) { 235 ah->ah_phy_revision == AR5K_SREV_PHY_2413) {
236 ah->ah_radio = AR5K_RF2413; 236 ah->ah_radio = AR5K_RF2413;
237 ah->ah_single_chip = true; 237 ah->ah_single_chip = true;
238 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_2413; 238 ah->ah_radio_5ghz_revision = AR5K_SREV_RAD_2413;
@@ -245,8 +245,7 @@ int ath5k_hw_init(struct ath5k_softc *sc)
245 245
246 246
247 /* Return on unsuported chips (unsupported eeprom etc) */ 247 /* Return on unsuported chips (unsupported eeprom etc) */
248 if ((srev >= AR5K_SREV_AR5416) && 248 if ((srev >= AR5K_SREV_AR5416) && (srev < AR5K_SREV_AR2425)) {
249 (srev < AR5K_SREV_AR2425)) {
250 ATH5K_ERR(sc, "Device not yet supported.\n"); 249 ATH5K_ERR(sc, "Device not yet supported.\n");
251 ret = -ENODEV; 250 ret = -ENODEV;
252 goto err; 251 goto err;
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index ac8734254707..58997d3abae6 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -814,8 +814,7 @@ ath5k_desc_alloc(struct ath5k_softc *sc)
814 814
815 INIT_LIST_HEAD(&sc->txbuf); 815 INIT_LIST_HEAD(&sc->txbuf);
816 sc->txbuf_len = ATH_TXBUF; 816 sc->txbuf_len = ATH_TXBUF;
817 for (i = 0; i < ATH_TXBUF; i++, bf++, ds++, 817 for (i = 0; i < ATH_TXBUF; i++, bf++, ds++, da += sizeof(*ds)) {
818 da += sizeof(*ds)) {
819 bf->desc = ds; 818 bf->desc = ds;
820 bf->daddr = da; 819 bf->daddr = da;
821 list_add_tail(&bf->list, &sc->txbuf); 820 list_add_tail(&bf->list, &sc->txbuf);
@@ -981,7 +980,7 @@ ath5k_beaconq_config(struct ath5k_softc *sc)
981 goto err; 980 goto err;
982 981
983 if (sc->opmode == NL80211_IFTYPE_AP || 982 if (sc->opmode == NL80211_IFTYPE_AP ||
984 sc->opmode == NL80211_IFTYPE_MESH_POINT) { 983 sc->opmode == NL80211_IFTYPE_MESH_POINT) {
985 /* 984 /*
986 * Always burst out beacon and CAB traffic 985 * Always burst out beacon and CAB traffic
987 * (aifs = cwmin = cwmax = 0) 986 * (aifs = cwmin = cwmax = 0)
@@ -1261,7 +1260,7 @@ ath5k_update_beacon_rssi(struct ath5k_softc *sc, struct sk_buff *skb, int rssi)
1261 */ 1260 */
1262static int ath5k_common_padpos(struct sk_buff *skb) 1261static int ath5k_common_padpos(struct sk_buff *skb)
1263{ 1262{
1264 struct ieee80211_hdr * hdr = (struct ieee80211_hdr *)skb->data; 1263 struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
1265 __le16 frame_control = hdr->frame_control; 1264 __le16 frame_control = hdr->frame_control;
1266 int padpos = 24; 1265 int padpos = 24;
1267 1266
@@ -1283,13 +1282,13 @@ static int ath5k_add_padding(struct sk_buff *skb)
1283 int padpos = ath5k_common_padpos(skb); 1282 int padpos = ath5k_common_padpos(skb);
1284 int padsize = padpos & 3; 1283 int padsize = padpos & 3;
1285 1284
1286 if (padsize && skb->len>padpos) { 1285 if (padsize && skb->len > padpos) {
1287 1286
1288 if (skb_headroom(skb) < padsize) 1287 if (skb_headroom(skb) < padsize)
1289 return -1; 1288 return -1;
1290 1289
1291 skb_push(skb, padsize); 1290 skb_push(skb, padsize);
1292 memmove(skb->data, skb->data+padsize, padpos); 1291 memmove(skb->data, skb->data + padsize, padpos);
1293 return padsize; 1292 return padsize;
1294 } 1293 }
1295 1294
@@ -1314,7 +1313,7 @@ static int ath5k_remove_padding(struct sk_buff *skb)
1314 int padpos = ath5k_common_padpos(skb); 1313 int padpos = ath5k_common_padpos(skb);
1315 int padsize = padpos & 3; 1314 int padsize = padpos & 3;
1316 1315
1317 if (padsize && skb->len>=padpos+padsize) { 1316 if (padsize && skb->len >= padpos + padsize) {
1318 memmove(skb->data + padsize, skb->data, padpos); 1317 memmove(skb->data + padsize, skb->data, padpos);
1319 skb_pull(skb, padsize); 1318 skb_pull(skb, padsize);
1320 return padsize; 1319 return padsize;
@@ -1709,7 +1708,7 @@ ath5k_tasklet_tx(unsigned long data)
1709 int i; 1708 int i;
1710 struct ath5k_softc *sc = (void *)data; 1709 struct ath5k_softc *sc = (void *)data;
1711 1710
1712 for (i=0; i < AR5K_NUM_TX_QUEUES; i++) 1711 for (i = 0; i < AR5K_NUM_TX_QUEUES; i++)
1713 if (sc->txqs[i].setup && (sc->ah->ah_txq_isr & BIT(i))) 1712 if (sc->txqs[i].setup && (sc->ah->ah_txq_isr & BIT(i)))
1714 ath5k_tx_processq(sc, &sc->txqs[i]); 1713 ath5k_tx_processq(sc, &sc->txqs[i]);
1715 1714
@@ -1900,7 +1899,7 @@ ath5k_beacon_send(struct ath5k_softc *sc)
1900 avf = (void *)vif->drv_priv; 1899 avf = (void *)vif->drv_priv;
1901 bf = avf->bbuf; 1900 bf = avf->bbuf;
1902 if (unlikely(bf->skb == NULL || sc->opmode == NL80211_IFTYPE_STATION || 1901 if (unlikely(bf->skb == NULL || sc->opmode == NL80211_IFTYPE_STATION ||
1903 sc->opmode == NL80211_IFTYPE_MONITOR)) { 1902 sc->opmode == NL80211_IFTYPE_MONITOR)) {
1904 ATH5K_WARN(sc, "bf=%p bf_skb=%p\n", bf, bf ? bf->skb : NULL); 1903 ATH5K_WARN(sc, "bf=%p bf_skb=%p\n", bf, bf ? bf->skb : NULL);
1905 return; 1904 return;
1906 } 1905 }
@@ -1917,7 +1916,7 @@ ath5k_beacon_send(struct ath5k_softc *sc)
1917 1916
1918 /* refresh the beacon for AP or MESH mode */ 1917 /* refresh the beacon for AP or MESH mode */
1919 if (sc->opmode == NL80211_IFTYPE_AP || 1918 if (sc->opmode == NL80211_IFTYPE_AP ||
1920 sc->opmode == NL80211_IFTYPE_MESH_POINT) 1919 sc->opmode == NL80211_IFTYPE_MESH_POINT)
1921 ath5k_beacon_update(sc->hw, vif); 1920 ath5k_beacon_update(sc->hw, vif);
1922 1921
1923 trace_ath5k_tx(sc, bf->skb, &sc->txqs[sc->bhalq]); 1922 trace_ath5k_tx(sc, bf->skb, &sc->txqs[sc->bhalq]);
@@ -2485,7 +2484,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops)
2485 /* Multi chip radio (RF5111 - RF2111) -> 2484 /* Multi chip radio (RF5111 - RF2111) ->
2486 * report both 2GHz/5GHz radios */ 2485 * report both 2GHz/5GHz radios */
2487 else if (sc->ah->ah_radio_5ghz_revision && 2486 else if (sc->ah->ah_radio_5ghz_revision &&
2488 sc->ah->ah_radio_2ghz_revision){ 2487 sc->ah->ah_radio_2ghz_revision) {
2489 ATH5K_INFO(sc, "RF%s 5GHz radio found (0x%x)\n", 2488 ATH5K_INFO(sc, "RF%s 5GHz radio found (0x%x)\n",
2490 ath5k_chip_name(AR5K_VERSION_RAD, 2489 ath5k_chip_name(AR5K_VERSION_RAD,
2491 sc->ah->ah_radio_5ghz_revision), 2490 sc->ah->ah_radio_5ghz_revision),
@@ -2710,8 +2709,7 @@ ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan,
2710 2709
2711 fast = ((chan != NULL) && modparam_fastchanswitch) ? 1 : 0; 2710 fast = ((chan != NULL) && modparam_fastchanswitch) ? 1 : 0;
2712 2711
2713 ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, fast, 2712 ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, fast, skip_pcu);
2714 skip_pcu);
2715 if (ret) { 2713 if (ret) {
2716 ATH5K_ERR(sc, "can't reset hardware (%d)\n", ret); 2714 ATH5K_ERR(sc, "can't reset hardware (%d)\n", ret);
2717 goto err; 2715 goto err;
diff --git a/drivers/net/wireless/ath/ath5k/base.h b/drivers/net/wireless/ath/ath5k/base.h
index eb035cbe665c..e71494ee3290 100644
--- a/drivers/net/wireless/ath/ath5k/base.h
+++ b/drivers/net/wireless/ath/ath5k/base.h
@@ -153,9 +153,9 @@ struct ath5k_statistics {
153}; 153};
154 154
155#if CHAN_DEBUG 155#if CHAN_DEBUG
156#define ATH_CHAN_MAX (26+26+26+200+200) 156#define ATH_CHAN_MAX (26 + 26 + 26 + 200 + 200)
157#else 157#else
158#define ATH_CHAN_MAX (14+14+14+252+20) 158#define ATH_CHAN_MAX (14 + 14 + 14 + 252 + 20)
159#endif 159#endif
160 160
161struct ath5k_vif { 161struct ath5k_vif {
diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 0bf7313b8a17..ae1112bfa1c1 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -205,35 +205,35 @@ static ssize_t read_file_beacon(struct file *file, char __user *user_buf,
205 u64 tsf; 205 u64 tsf;
206 206
207 v = ath5k_hw_reg_read(sc->ah, AR5K_BEACON); 207 v = ath5k_hw_reg_read(sc->ah, AR5K_BEACON);
208 len += snprintf(buf+len, sizeof(buf)-len, 208 len += snprintf(buf + len, sizeof(buf) - len,
209 "%-24s0x%08x\tintval: %d\tTIM: 0x%x\n", 209 "%-24s0x%08x\tintval: %d\tTIM: 0x%x\n",
210 "AR5K_BEACON", v, v & AR5K_BEACON_PERIOD, 210 "AR5K_BEACON", v, v & AR5K_BEACON_PERIOD,
211 (v & AR5K_BEACON_TIM) >> AR5K_BEACON_TIM_S); 211 (v & AR5K_BEACON_TIM) >> AR5K_BEACON_TIM_S);
212 212
213 len += snprintf(buf+len, sizeof(buf)-len, "%-24s0x%08x\n", 213 len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\n",
214 "AR5K_LAST_TSTP", ath5k_hw_reg_read(sc->ah, AR5K_LAST_TSTP)); 214 "AR5K_LAST_TSTP", ath5k_hw_reg_read(sc->ah, AR5K_LAST_TSTP));
215 215
216 len += snprintf(buf+len, sizeof(buf)-len, "%-24s0x%08x\n\n", 216 len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\n\n",
217 "AR5K_BEACON_CNT", ath5k_hw_reg_read(sc->ah, AR5K_BEACON_CNT)); 217 "AR5K_BEACON_CNT", ath5k_hw_reg_read(sc->ah, AR5K_BEACON_CNT));
218 218
219 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER0); 219 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER0);
220 len += snprintf(buf+len, sizeof(buf)-len, "%-24s0x%08x\tTU: %08x\n", 220 len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
221 "AR5K_TIMER0 (TBTT)", v, v); 221 "AR5K_TIMER0 (TBTT)", v, v);
222 222
223 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER1); 223 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER1);
224 len += snprintf(buf+len, sizeof(buf)-len, "%-24s0x%08x\tTU: %08x\n", 224 len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
225 "AR5K_TIMER1 (DMA)", v, v >> 3); 225 "AR5K_TIMER1 (DMA)", v, v >> 3);
226 226
227 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER2); 227 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER2);
228 len += snprintf(buf+len, sizeof(buf)-len, "%-24s0x%08x\tTU: %08x\n", 228 len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
229 "AR5K_TIMER2 (SWBA)", v, v >> 3); 229 "AR5K_TIMER2 (SWBA)", v, v >> 3);
230 230
231 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER3); 231 v = ath5k_hw_reg_read(sc->ah, AR5K_TIMER3);
232 len += snprintf(buf+len, sizeof(buf)-len, "%-24s0x%08x\tTU: %08x\n", 232 len += snprintf(buf + len, sizeof(buf) - len, "%-24s0x%08x\tTU: %08x\n",
233 "AR5K_TIMER3 (ATIM)", v, v); 233 "AR5K_TIMER3 (ATIM)", v, v);
234 234
235 tsf = ath5k_hw_get_tsf64(sc->ah); 235 tsf = ath5k_hw_get_tsf64(sc->ah);
236 len += snprintf(buf+len, sizeof(buf)-len, 236 len += snprintf(buf + len, sizeof(buf) - len,
237 "TSF\t\t0x%016llx\tTU: %08x\n", 237 "TSF\t\t0x%016llx\tTU: %08x\n",
238 (unsigned long long)tsf, TSF_TO_TU(tsf)); 238 (unsigned long long)tsf, TSF_TO_TU(tsf));
239 239
@@ -323,16 +323,16 @@ static ssize_t read_file_debug(struct file *file, char __user *user_buf,
323 unsigned int len = 0; 323 unsigned int len = 0;
324 unsigned int i; 324 unsigned int i;
325 325
326 len += snprintf(buf+len, sizeof(buf)-len, 326 len += snprintf(buf + len, sizeof(buf) - len,
327 "DEBUG LEVEL: 0x%08x\n\n", sc->debug.level); 327 "DEBUG LEVEL: 0x%08x\n\n", sc->debug.level);
328 328
329 for (i = 0; i < ARRAY_SIZE(dbg_info) - 1; i++) { 329 for (i = 0; i < ARRAY_SIZE(dbg_info) - 1; i++) {
330 len += snprintf(buf+len, sizeof(buf)-len, 330 len += snprintf(buf + len, sizeof(buf) - len,
331 "%10s %c 0x%08x - %s\n", dbg_info[i].name, 331 "%10s %c 0x%08x - %s\n", dbg_info[i].name,
332 sc->debug.level & dbg_info[i].level ? '+' : ' ', 332 sc->debug.level & dbg_info[i].level ? '+' : ' ',
333 dbg_info[i].level, dbg_info[i].desc); 333 dbg_info[i].level, dbg_info[i].desc);
334 } 334 }
335 len += snprintf(buf+len, sizeof(buf)-len, 335 len += snprintf(buf + len, sizeof(buf) - len,
336 "%10s %c 0x%08x - %s\n", dbg_info[i].name, 336 "%10s %c 0x%08x - %s\n", dbg_info[i].name,
337 sc->debug.level == dbg_info[i].level ? '+' : ' ', 337 sc->debug.level == dbg_info[i].level ? '+' : ' ',
338 dbg_info[i].level, dbg_info[i].desc); 338 dbg_info[i].level, dbg_info[i].desc);
@@ -384,60 +384,60 @@ static ssize_t read_file_antenna(struct file *file, char __user *user_buf,
384 unsigned int i; 384 unsigned int i;
385 unsigned int v; 385 unsigned int v;
386 386
387 len += snprintf(buf+len, sizeof(buf)-len, "antenna mode\t%d\n", 387 len += snprintf(buf + len, sizeof(buf) - len, "antenna mode\t%d\n",
388 sc->ah->ah_ant_mode); 388 sc->ah->ah_ant_mode);
389 len += snprintf(buf+len, sizeof(buf)-len, "default antenna\t%d\n", 389 len += snprintf(buf + len, sizeof(buf) - len, "default antenna\t%d\n",
390 sc->ah->ah_def_ant); 390 sc->ah->ah_def_ant);
391 len += snprintf(buf+len, sizeof(buf)-len, "tx antenna\t%d\n", 391 len += snprintf(buf + len, sizeof(buf) - len, "tx antenna\t%d\n",
392 sc->ah->ah_tx_ant); 392 sc->ah->ah_tx_ant);
393 393
394 len += snprintf(buf+len, sizeof(buf)-len, "\nANTENNA\t\tRX\tTX\n"); 394 len += snprintf(buf + len, sizeof(buf) - len, "\nANTENNA\t\tRX\tTX\n");
395 for (i = 1; i < ARRAY_SIZE(sc->stats.antenna_rx); i++) { 395 for (i = 1; i < ARRAY_SIZE(sc->stats.antenna_rx); i++) {
396 len += snprintf(buf+len, sizeof(buf)-len, 396 len += snprintf(buf + len, sizeof(buf) - len,
397 "[antenna %d]\t%d\t%d\n", 397 "[antenna %d]\t%d\t%d\n",
398 i, sc->stats.antenna_rx[i], sc->stats.antenna_tx[i]); 398 i, sc->stats.antenna_rx[i], sc->stats.antenna_tx[i]);
399 } 399 }
400 len += snprintf(buf+len, sizeof(buf)-len, "[invalid]\t%d\t%d\n", 400 len += snprintf(buf + len, sizeof(buf) - len, "[invalid]\t%d\t%d\n",
401 sc->stats.antenna_rx[0], sc->stats.antenna_tx[0]); 401 sc->stats.antenna_rx[0], sc->stats.antenna_tx[0]);
402 402
403 v = ath5k_hw_reg_read(sc->ah, AR5K_DEFAULT_ANTENNA); 403 v = ath5k_hw_reg_read(sc->ah, AR5K_DEFAULT_ANTENNA);
404 len += snprintf(buf+len, sizeof(buf)-len, 404 len += snprintf(buf + len, sizeof(buf) - len,
405 "\nAR5K_DEFAULT_ANTENNA\t0x%08x\n", v); 405 "\nAR5K_DEFAULT_ANTENNA\t0x%08x\n", v);
406 406
407 v = ath5k_hw_reg_read(sc->ah, AR5K_STA_ID1); 407 v = ath5k_hw_reg_read(sc->ah, AR5K_STA_ID1);
408 len += snprintf(buf+len, sizeof(buf)-len, 408 len += snprintf(buf + len, sizeof(buf) - len,
409 "AR5K_STA_ID1_DEFAULT_ANTENNA\t%d\n", 409 "AR5K_STA_ID1_DEFAULT_ANTENNA\t%d\n",
410 (v & AR5K_STA_ID1_DEFAULT_ANTENNA) != 0); 410 (v & AR5K_STA_ID1_DEFAULT_ANTENNA) != 0);
411 len += snprintf(buf+len, sizeof(buf)-len, 411 len += snprintf(buf + len, sizeof(buf) - len,
412 "AR5K_STA_ID1_DESC_ANTENNA\t%d\n", 412 "AR5K_STA_ID1_DESC_ANTENNA\t%d\n",
413 (v & AR5K_STA_ID1_DESC_ANTENNA) != 0); 413 (v & AR5K_STA_ID1_DESC_ANTENNA) != 0);
414 len += snprintf(buf+len, sizeof(buf)-len, 414 len += snprintf(buf + len, sizeof(buf) - len,
415 "AR5K_STA_ID1_RTS_DEF_ANTENNA\t%d\n", 415 "AR5K_STA_ID1_RTS_DEF_ANTENNA\t%d\n",
416 (v & AR5K_STA_ID1_RTS_DEF_ANTENNA) != 0); 416 (v & AR5K_STA_ID1_RTS_DEF_ANTENNA) != 0);
417 len += snprintf(buf+len, sizeof(buf)-len, 417 len += snprintf(buf + len, sizeof(buf) - len,
418 "AR5K_STA_ID1_SELFGEN_DEF_ANT\t%d\n", 418 "AR5K_STA_ID1_SELFGEN_DEF_ANT\t%d\n",
419 (v & AR5K_STA_ID1_SELFGEN_DEF_ANT) != 0); 419 (v & AR5K_STA_ID1_SELFGEN_DEF_ANT) != 0);
420 420
421 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_AGCCTL); 421 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_AGCCTL);
422 len += snprintf(buf+len, sizeof(buf)-len, 422 len += snprintf(buf + len, sizeof(buf) - len,
423 "\nAR5K_PHY_AGCCTL_OFDM_DIV_DIS\t%d\n", 423 "\nAR5K_PHY_AGCCTL_OFDM_DIV_DIS\t%d\n",
424 (v & AR5K_PHY_AGCCTL_OFDM_DIV_DIS) != 0); 424 (v & AR5K_PHY_AGCCTL_OFDM_DIV_DIS) != 0);
425 425
426 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_RESTART); 426 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_RESTART);
427 len += snprintf(buf+len, sizeof(buf)-len, 427 len += snprintf(buf + len, sizeof(buf) - len,
428 "AR5K_PHY_RESTART_DIV_GC\t\t%x\n", 428 "AR5K_PHY_RESTART_DIV_GC\t\t%x\n",
429 (v & AR5K_PHY_RESTART_DIV_GC) >> AR5K_PHY_RESTART_DIV_GC_S); 429 (v & AR5K_PHY_RESTART_DIV_GC) >> AR5K_PHY_RESTART_DIV_GC_S);
430 430
431 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_FAST_ANT_DIV); 431 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_FAST_ANT_DIV);
432 len += snprintf(buf+len, sizeof(buf)-len, 432 len += snprintf(buf + len, sizeof(buf) - len,
433 "AR5K_PHY_FAST_ANT_DIV_EN\t%d\n", 433 "AR5K_PHY_FAST_ANT_DIV_EN\t%d\n",
434 (v & AR5K_PHY_FAST_ANT_DIV_EN) != 0); 434 (v & AR5K_PHY_FAST_ANT_DIV_EN) != 0);
435 435
436 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_ANT_SWITCH_TABLE_0); 436 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_ANT_SWITCH_TABLE_0);
437 len += snprintf(buf+len, sizeof(buf)-len, 437 len += snprintf(buf + len, sizeof(buf) - len,
438 "\nAR5K_PHY_ANT_SWITCH_TABLE_0\t0x%08x\n", v); 438 "\nAR5K_PHY_ANT_SWITCH_TABLE_0\t0x%08x\n", v);
439 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_ANT_SWITCH_TABLE_1); 439 v = ath5k_hw_reg_read(sc->ah, AR5K_PHY_ANT_SWITCH_TABLE_1);
440 len += snprintf(buf+len, sizeof(buf)-len, 440 len += snprintf(buf + len, sizeof(buf) - len,
441 "AR5K_PHY_ANT_SWITCH_TABLE_1\t0x%08x\n", v); 441 "AR5K_PHY_ANT_SWITCH_TABLE_1\t0x%08x\n", v);
442 442
443 if (len > sizeof(buf)) 443 if (len > sizeof(buf))
@@ -494,36 +494,36 @@ static ssize_t read_file_misc(struct file *file, char __user *user_buf,
494 unsigned int len = 0; 494 unsigned int len = 0;
495 u32 filt = ath5k_hw_get_rx_filter(sc->ah); 495 u32 filt = ath5k_hw_get_rx_filter(sc->ah);
496 496
497 len += snprintf(buf+len, sizeof(buf)-len, "bssid-mask: %pM\n", 497 len += snprintf(buf + len, sizeof(buf) - len, "bssid-mask: %pM\n",
498 sc->bssidmask); 498 sc->bssidmask);
499 len += snprintf(buf+len, sizeof(buf)-len, "filter-flags: 0x%x ", 499 len += snprintf(buf + len, sizeof(buf) - len, "filter-flags: 0x%x ",
500 filt); 500 filt);
501 if (filt & AR5K_RX_FILTER_UCAST) 501 if (filt & AR5K_RX_FILTER_UCAST)
502 len += snprintf(buf+len, sizeof(buf)-len, " UCAST"); 502 len += snprintf(buf + len, sizeof(buf) - len, " UCAST");
503 if (filt & AR5K_RX_FILTER_MCAST) 503 if (filt & AR5K_RX_FILTER_MCAST)
504 len += snprintf(buf+len, sizeof(buf)-len, " MCAST"); 504 len += snprintf(buf + len, sizeof(buf) - len, " MCAST");
505 if (filt & AR5K_RX_FILTER_BCAST) 505 if (filt & AR5K_RX_FILTER_BCAST)
506 len += snprintf(buf+len, sizeof(buf)-len, " BCAST"); 506 len += snprintf(buf + len, sizeof(buf) - len, " BCAST");
507 if (filt & AR5K_RX_FILTER_CONTROL) 507 if (filt & AR5K_RX_FILTER_CONTROL)
508 len += snprintf(buf+len, sizeof(buf)-len, " CONTROL"); 508 len += snprintf(buf + len, sizeof(buf) - len, " CONTROL");
509 if (filt & AR5K_RX_FILTER_BEACON) 509 if (filt & AR5K_RX_FILTER_BEACON)
510 len += snprintf(buf+len, sizeof(buf)-len, " BEACON"); 510 len += snprintf(buf + len, sizeof(buf) - len, " BEACON");
511 if (filt & AR5K_RX_FILTER_PROM) 511 if (filt & AR5K_RX_FILTER_PROM)
512 len += snprintf(buf+len, sizeof(buf)-len, " PROM"); 512 len += snprintf(buf + len, sizeof(buf) - len, " PROM");
513 if (filt & AR5K_RX_FILTER_XRPOLL) 513 if (filt & AR5K_RX_FILTER_XRPOLL)
514 len += snprintf(buf+len, sizeof(buf)-len, " XRPOLL"); 514 len += snprintf(buf + len, sizeof(buf) - len, " XRPOLL");
515 if (filt & AR5K_RX_FILTER_PROBEREQ) 515 if (filt & AR5K_RX_FILTER_PROBEREQ)
516 len += snprintf(buf+len, sizeof(buf)-len, " PROBEREQ"); 516 len += snprintf(buf + len, sizeof(buf) - len, " PROBEREQ");
517 if (filt & AR5K_RX_FILTER_PHYERR_5212) 517 if (filt & AR5K_RX_FILTER_PHYERR_5212)
518 len += snprintf(buf+len, sizeof(buf)-len, " PHYERR-5212"); 518 len += snprintf(buf + len, sizeof(buf) - len, " PHYERR-5212");
519 if (filt & AR5K_RX_FILTER_RADARERR_5212) 519 if (filt & AR5K_RX_FILTER_RADARERR_5212)
520 len += snprintf(buf+len, sizeof(buf)-len, " RADARERR-5212"); 520 len += snprintf(buf + len, sizeof(buf) - len, " RADARERR-5212");
521 if (filt & AR5K_RX_FILTER_PHYERR_5211) 521 if (filt & AR5K_RX_FILTER_PHYERR_5211)
522 snprintf(buf+len, sizeof(buf)-len, " PHYERR-5211"); 522 snprintf(buf + len, sizeof(buf) - len, " PHYERR-5211");
523 if (filt & AR5K_RX_FILTER_RADARERR_5211) 523 if (filt & AR5K_RX_FILTER_RADARERR_5211)
524 len += snprintf(buf+len, sizeof(buf)-len, " RADARERR-5211"); 524 len += snprintf(buf + len, sizeof(buf) - len, " RADARERR-5211");
525 525
526 len += snprintf(buf+len, sizeof(buf)-len, "\nopmode: %s (%d)\n", 526 len += snprintf(buf + len, sizeof(buf) - len, "\nopmode: %s (%d)\n",
527 ath_opmode_to_string(sc->opmode), sc->opmode); 527 ath_opmode_to_string(sc->opmode), sc->opmode);
528 528
529 if (len > sizeof(buf)) 529 if (len > sizeof(buf))
@@ -550,65 +550,65 @@ static ssize_t read_file_frameerrors(struct file *file, char __user *user_buf,
550 unsigned int len = 0; 550 unsigned int len = 0;
551 int i; 551 int i;
552 552
553 len += snprintf(buf+len, sizeof(buf)-len, 553 len += snprintf(buf + len, sizeof(buf) - len,
554 "RX\n---------------------\n"); 554 "RX\n---------------------\n");
555 len += snprintf(buf+len, sizeof(buf)-len, "CRC\t%u\t(%u%%)\n", 555 len += snprintf(buf + len, sizeof(buf) - len, "CRC\t%u\t(%u%%)\n",
556 st->rxerr_crc, 556 st->rxerr_crc,
557 st->rx_all_count > 0 ? 557 st->rx_all_count > 0 ?
558 st->rxerr_crc*100/st->rx_all_count : 0); 558 st->rxerr_crc * 100 / st->rx_all_count : 0);
559 len += snprintf(buf+len, sizeof(buf)-len, "PHY\t%u\t(%u%%)\n", 559 len += snprintf(buf + len, sizeof(buf) - len, "PHY\t%u\t(%u%%)\n",
560 st->rxerr_phy, 560 st->rxerr_phy,
561 st->rx_all_count > 0 ? 561 st->rx_all_count > 0 ?
562 st->rxerr_phy*100/st->rx_all_count : 0); 562 st->rxerr_phy * 100 / st->rx_all_count : 0);
563 for (i = 0; i < 32; i++) { 563 for (i = 0; i < 32; i++) {
564 if (st->rxerr_phy_code[i]) 564 if (st->rxerr_phy_code[i])
565 len += snprintf(buf+len, sizeof(buf)-len, 565 len += snprintf(buf + len, sizeof(buf) - len,
566 " phy_err[%u]\t%u\n", 566 " phy_err[%u]\t%u\n",
567 i, st->rxerr_phy_code[i]); 567 i, st->rxerr_phy_code[i]);
568 } 568 }
569 569
570 len += snprintf(buf+len, sizeof(buf)-len, "FIFO\t%u\t(%u%%)\n", 570 len += snprintf(buf + len, sizeof(buf) - len, "FIFO\t%u\t(%u%%)\n",
571 st->rxerr_fifo, 571 st->rxerr_fifo,
572 st->rx_all_count > 0 ? 572 st->rx_all_count > 0 ?
573 st->rxerr_fifo*100/st->rx_all_count : 0); 573 st->rxerr_fifo * 100 / st->rx_all_count : 0);
574 len += snprintf(buf+len, sizeof(buf)-len, "decrypt\t%u\t(%u%%)\n", 574 len += snprintf(buf + len, sizeof(buf) - len, "decrypt\t%u\t(%u%%)\n",
575 st->rxerr_decrypt, 575 st->rxerr_decrypt,
576 st->rx_all_count > 0 ? 576 st->rx_all_count > 0 ?
577 st->rxerr_decrypt*100/st->rx_all_count : 0); 577 st->rxerr_decrypt * 100 / st->rx_all_count : 0);
578 len += snprintf(buf+len, sizeof(buf)-len, "MIC\t%u\t(%u%%)\n", 578 len += snprintf(buf + len, sizeof(buf) - len, "MIC\t%u\t(%u%%)\n",
579 st->rxerr_mic, 579 st->rxerr_mic,
580 st->rx_all_count > 0 ? 580 st->rx_all_count > 0 ?
581 st->rxerr_mic*100/st->rx_all_count : 0); 581 st->rxerr_mic * 100 / st->rx_all_count : 0);
582 len += snprintf(buf+len, sizeof(buf)-len, "process\t%u\t(%u%%)\n", 582 len += snprintf(buf + len, sizeof(buf) - len, "process\t%u\t(%u%%)\n",
583 st->rxerr_proc, 583 st->rxerr_proc,
584 st->rx_all_count > 0 ? 584 st->rx_all_count > 0 ?
585 st->rxerr_proc*100/st->rx_all_count : 0); 585 st->rxerr_proc * 100 / st->rx_all_count : 0);
586 len += snprintf(buf+len, sizeof(buf)-len, "jumbo\t%u\t(%u%%)\n", 586 len += snprintf(buf + len, sizeof(buf) - len, "jumbo\t%u\t(%u%%)\n",
587 st->rxerr_jumbo, 587 st->rxerr_jumbo,
588 st->rx_all_count > 0 ? 588 st->rx_all_count > 0 ?
589 st->rxerr_jumbo*100/st->rx_all_count : 0); 589 st->rxerr_jumbo * 100 / st->rx_all_count : 0);
590 len += snprintf(buf+len, sizeof(buf)-len, "[RX all\t%u]\n", 590 len += snprintf(buf + len, sizeof(buf) - len, "[RX all\t%u]\n",
591 st->rx_all_count); 591 st->rx_all_count);
592 len += snprintf(buf+len, sizeof(buf)-len, "RX-all-bytes\t%u\n", 592 len += snprintf(buf + len, sizeof(buf) - len, "RX-all-bytes\t%u\n",
593 st->rx_bytes_count); 593 st->rx_bytes_count);
594 594
595 len += snprintf(buf+len, sizeof(buf)-len, 595 len += snprintf(buf + len, sizeof(buf) - len,
596 "\nTX\n---------------------\n"); 596 "\nTX\n---------------------\n");
597 len += snprintf(buf+len, sizeof(buf)-len, "retry\t%u\t(%u%%)\n", 597 len += snprintf(buf + len, sizeof(buf) - len, "retry\t%u\t(%u%%)\n",
598 st->txerr_retry, 598 st->txerr_retry,
599 st->tx_all_count > 0 ? 599 st->tx_all_count > 0 ?
600 st->txerr_retry*100/st->tx_all_count : 0); 600 st->txerr_retry * 100 / st->tx_all_count : 0);
601 len += snprintf(buf+len, sizeof(buf)-len, "FIFO\t%u\t(%u%%)\n", 601 len += snprintf(buf + len, sizeof(buf) - len, "FIFO\t%u\t(%u%%)\n",
602 st->txerr_fifo, 602 st->txerr_fifo,
603 st->tx_all_count > 0 ? 603 st->tx_all_count > 0 ?
604 st->txerr_fifo*100/st->tx_all_count : 0); 604 st->txerr_fifo * 100 / st->tx_all_count : 0);
605 len += snprintf(buf+len, sizeof(buf)-len, "filter\t%u\t(%u%%)\n", 605 len += snprintf(buf + len, sizeof(buf) - len, "filter\t%u\t(%u%%)\n",
606 st->txerr_filt, 606 st->txerr_filt,
607 st->tx_all_count > 0 ? 607 st->tx_all_count > 0 ?
608 st->txerr_filt*100/st->tx_all_count : 0); 608 st->txerr_filt * 100 / st->tx_all_count : 0);
609 len += snprintf(buf+len, sizeof(buf)-len, "[TX all\t%u]\n", 609 len += snprintf(buf + len, sizeof(buf) - len, "[TX all\t%u]\n",
610 st->tx_all_count); 610 st->tx_all_count);
611 len += snprintf(buf+len, sizeof(buf)-len, "TX-all-bytes\t%u\n", 611 len += snprintf(buf + len, sizeof(buf) - len, "TX-all-bytes\t%u\n",
612 st->tx_bytes_count); 612 st->tx_bytes_count);
613 613
614 if (len > sizeof(buf)) 614 if (len > sizeof(buf))
@@ -667,89 +667,93 @@ static ssize_t read_file_ani(struct file *file, char __user *user_buf,
667 char buf[700]; 667 char buf[700];
668 unsigned int len = 0; 668 unsigned int len = 0;
669 669
670 len += snprintf(buf+len, sizeof(buf)-len, 670 len += snprintf(buf + len, sizeof(buf) - len,
671 "HW has PHY error counters:\t%s\n", 671 "HW has PHY error counters:\t%s\n",
672 sc->ah->ah_capabilities.cap_has_phyerr_counters ? 672 sc->ah->ah_capabilities.cap_has_phyerr_counters ?
673 "yes" : "no"); 673 "yes" : "no");
674 len += snprintf(buf+len, sizeof(buf)-len, 674 len += snprintf(buf + len, sizeof(buf) - len,
675 "HW max spur immunity level:\t%d\n", 675 "HW max spur immunity level:\t%d\n",
676 as->max_spur_level); 676 as->max_spur_level);
677 len += snprintf(buf+len, sizeof(buf)-len, 677 len += snprintf(buf + len, sizeof(buf) - len,
678 "\nANI state\n--------------------------------------------\n"); 678 "\nANI state\n--------------------------------------------\n");
679 len += snprintf(buf+len, sizeof(buf)-len, "operating mode:\t\t\t"); 679 len += snprintf(buf + len, sizeof(buf) - len, "operating mode:\t\t\t");
680 switch (as->ani_mode) { 680 switch (as->ani_mode) {
681 case ATH5K_ANI_MODE_OFF: 681 case ATH5K_ANI_MODE_OFF:
682 len += snprintf(buf+len, sizeof(buf)-len, "OFF\n"); 682 len += snprintf(buf + len, sizeof(buf) - len, "OFF\n");
683 break; 683 break;
684 case ATH5K_ANI_MODE_MANUAL_LOW: 684 case ATH5K_ANI_MODE_MANUAL_LOW:
685 len += snprintf(buf+len, sizeof(buf)-len, 685 len += snprintf(buf + len, sizeof(buf) - len,
686 "MANUAL LOW\n"); 686 "MANUAL LOW\n");
687 break; 687 break;
688 case ATH5K_ANI_MODE_MANUAL_HIGH: 688 case ATH5K_ANI_MODE_MANUAL_HIGH:
689 len += snprintf(buf+len, sizeof(buf)-len, 689 len += snprintf(buf + len, sizeof(buf) - len,
690 "MANUAL HIGH\n"); 690 "MANUAL HIGH\n");
691 break; 691 break;
692 case ATH5K_ANI_MODE_AUTO: 692 case ATH5K_ANI_MODE_AUTO:
693 len += snprintf(buf+len, sizeof(buf)-len, "AUTO\n"); 693 len += snprintf(buf + len, sizeof(buf) - len, "AUTO\n");
694 break; 694 break;
695 default: 695 default:
696 len += snprintf(buf+len, sizeof(buf)-len, 696 len += snprintf(buf + len, sizeof(buf) - len,
697 "??? (not good)\n"); 697 "??? (not good)\n");
698 break; 698 break;
699 } 699 }
700 len += snprintf(buf+len, sizeof(buf)-len, 700 len += snprintf(buf + len, sizeof(buf) - len,
701 "noise immunity level:\t\t%d\n", 701 "noise immunity level:\t\t%d\n",
702 as->noise_imm_level); 702 as->noise_imm_level);
703 len += snprintf(buf+len, sizeof(buf)-len, 703 len += snprintf(buf + len, sizeof(buf) - len,
704 "spur immunity level:\t\t%d\n", 704 "spur immunity level:\t\t%d\n",
705 as->spur_level); 705 as->spur_level);
706 len += snprintf(buf+len, sizeof(buf)-len, "firstep level:\t\t\t%d\n", 706 len += snprintf(buf + len, sizeof(buf) - len,
707 "firstep level:\t\t\t%d\n",
707 as->firstep_level); 708 as->firstep_level);
708 len += snprintf(buf+len, sizeof(buf)-len, 709 len += snprintf(buf + len, sizeof(buf) - len,
709 "OFDM weak signal detection:\t%s\n", 710 "OFDM weak signal detection:\t%s\n",
710 as->ofdm_weak_sig ? "on" : "off"); 711 as->ofdm_weak_sig ? "on" : "off");
711 len += snprintf(buf+len, sizeof(buf)-len, 712 len += snprintf(buf + len, sizeof(buf) - len,
712 "CCK weak signal detection:\t%s\n", 713 "CCK weak signal detection:\t%s\n",
713 as->cck_weak_sig ? "on" : "off"); 714 as->cck_weak_sig ? "on" : "off");
714 715
715 len += snprintf(buf+len, sizeof(buf)-len, 716 len += snprintf(buf + len, sizeof(buf) - len,
716 "\nMIB INTERRUPTS:\t\t%u\n", 717 "\nMIB INTERRUPTS:\t\t%u\n",
717 st->mib_intr); 718 st->mib_intr);
718 len += snprintf(buf+len, sizeof(buf)-len, 719 len += snprintf(buf + len, sizeof(buf) - len,
719 "beacon RSSI average:\t%d\n", 720 "beacon RSSI average:\t%d\n",
720 (int)ewma_read(&sc->ah->ah_beacon_rssi_avg)); 721 (int)ewma_read(&sc->ah->ah_beacon_rssi_avg));
721 722
722#define CC_PRINT(_struct, _field) \ 723#define CC_PRINT(_struct, _field) \
723 _struct._field, \ 724 _struct._field, \
724 _struct.cycles > 0 ? \ 725 _struct.cycles > 0 ? \
725 _struct._field*100/_struct.cycles : 0 726 _struct._field * 100 / _struct.cycles : 0
726 727
727 len += snprintf(buf+len, sizeof(buf)-len, "profcnt tx\t\t%u\t(%d%%)\n", 728 len += snprintf(buf + len, sizeof(buf) - len,
729 "profcnt tx\t\t%u\t(%d%%)\n",
728 CC_PRINT(as->last_cc, tx_frame)); 730 CC_PRINT(as->last_cc, tx_frame));
729 len += snprintf(buf+len, sizeof(buf)-len, "profcnt rx\t\t%u\t(%d%%)\n", 731 len += snprintf(buf + len, sizeof(buf) - len,
732 "profcnt rx\t\t%u\t(%d%%)\n",
730 CC_PRINT(as->last_cc, rx_frame)); 733 CC_PRINT(as->last_cc, rx_frame));
731 len += snprintf(buf+len, sizeof(buf)-len, "profcnt busy\t\t%u\t(%d%%)\n", 734 len += snprintf(buf + len, sizeof(buf) - len,
735 "profcnt busy\t\t%u\t(%d%%)\n",
732 CC_PRINT(as->last_cc, rx_busy)); 736 CC_PRINT(as->last_cc, rx_busy));
733#undef CC_PRINT 737#undef CC_PRINT
734 len += snprintf(buf+len, sizeof(buf)-len, "profcnt cycles\t\t%u\n", 738 len += snprintf(buf + len, sizeof(buf) - len, "profcnt cycles\t\t%u\n",
735 as->last_cc.cycles); 739 as->last_cc.cycles);
736 len += snprintf(buf+len, sizeof(buf)-len, 740 len += snprintf(buf + len, sizeof(buf) - len,
737 "listen time\t\t%d\tlast: %d\n", 741 "listen time\t\t%d\tlast: %d\n",
738 as->listen_time, as->last_listen); 742 as->listen_time, as->last_listen);
739 len += snprintf(buf+len, sizeof(buf)-len, 743 len += snprintf(buf + len, sizeof(buf) - len,
740 "OFDM errors\t\t%u\tlast: %u\tsum: %u\n", 744 "OFDM errors\t\t%u\tlast: %u\tsum: %u\n",
741 as->ofdm_errors, as->last_ofdm_errors, 745 as->ofdm_errors, as->last_ofdm_errors,
742 as->sum_ofdm_errors); 746 as->sum_ofdm_errors);
743 len += snprintf(buf+len, sizeof(buf)-len, 747 len += snprintf(buf + len, sizeof(buf) - len,
744 "CCK errors\t\t%u\tlast: %u\tsum: %u\n", 748 "CCK errors\t\t%u\tlast: %u\tsum: %u\n",
745 as->cck_errors, as->last_cck_errors, 749 as->cck_errors, as->last_cck_errors,
746 as->sum_cck_errors); 750 as->sum_cck_errors);
747 len += snprintf(buf+len, sizeof(buf)-len, 751 len += snprintf(buf + len, sizeof(buf) - len,
748 "AR5K_PHYERR_CNT1\t%x\t(=%d)\n", 752 "AR5K_PHYERR_CNT1\t%x\t(=%d)\n",
749 ath5k_hw_reg_read(sc->ah, AR5K_PHYERR_CNT1), 753 ath5k_hw_reg_read(sc->ah, AR5K_PHYERR_CNT1),
750 ATH5K_ANI_OFDM_TRIG_HIGH - (ATH5K_PHYERR_CNT_MAX - 754 ATH5K_ANI_OFDM_TRIG_HIGH - (ATH5K_PHYERR_CNT_MAX -
751 ath5k_hw_reg_read(sc->ah, AR5K_PHYERR_CNT1))); 755 ath5k_hw_reg_read(sc->ah, AR5K_PHYERR_CNT1)));
752 len += snprintf(buf+len, sizeof(buf)-len, 756 len += snprintf(buf + len, sizeof(buf) - len,
753 "AR5K_PHYERR_CNT2\t%x\t(=%d)\n", 757 "AR5K_PHYERR_CNT2\t%x\t(=%d)\n",
754 ath5k_hw_reg_read(sc->ah, AR5K_PHYERR_CNT2), 758 ath5k_hw_reg_read(sc->ah, AR5K_PHYERR_CNT2),
755 ATH5K_ANI_CCK_TRIG_HIGH - (ATH5K_PHYERR_CNT_MAX - 759 ATH5K_ANI_CCK_TRIG_HIGH - (ATH5K_PHYERR_CNT_MAX -
@@ -827,13 +831,13 @@ static ssize_t read_file_queue(struct file *file, char __user *user_buf,
827 struct ath5k_buf *bf, *bf0; 831 struct ath5k_buf *bf, *bf0;
828 int i, n; 832 int i, n;
829 833
830 len += snprintf(buf+len, sizeof(buf)-len, 834 len += snprintf(buf + len, sizeof(buf) - len,
831 "available txbuffers: %d\n", sc->txbuf_len); 835 "available txbuffers: %d\n", sc->txbuf_len);
832 836
833 for (i = 0; i < ARRAY_SIZE(sc->txqs); i++) { 837 for (i = 0; i < ARRAY_SIZE(sc->txqs); i++) {
834 txq = &sc->txqs[i]; 838 txq = &sc->txqs[i];
835 839
836 len += snprintf(buf+len, sizeof(buf)-len, 840 len += snprintf(buf + len, sizeof(buf) - len,
837 "%02d: %ssetup\n", i, txq->setup ? "" : "not "); 841 "%02d: %ssetup\n", i, txq->setup ? "" : "not ");
838 842
839 if (!txq->setup) 843 if (!txq->setup)
@@ -845,9 +849,9 @@ static ssize_t read_file_queue(struct file *file, char __user *user_buf,
845 n++; 849 n++;
846 spin_unlock_bh(&txq->lock); 850 spin_unlock_bh(&txq->lock);
847 851
848 len += snprintf(buf+len, sizeof(buf)-len, 852 len += snprintf(buf + len, sizeof(buf) - len,
849 " len: %d bufs: %d\n", txq->txq_len, n); 853 " len: %d bufs: %d\n", txq->txq_len, n);
850 len += snprintf(buf+len, sizeof(buf)-len, 854 len += snprintf(buf + len, sizeof(buf) - len,
851 " stuck: %d\n", txq->txq_stuck); 855 " stuck: %d\n", txq->txq_stuck);
852 } 856 }
853 857
@@ -894,7 +898,7 @@ ath5k_debug_init_device(struct ath5k_softc *sc)
894 898
895 phydir = debugfs_create_dir("ath5k", sc->hw->wiphy->debugfsdir); 899 phydir = debugfs_create_dir("ath5k", sc->hw->wiphy->debugfsdir);
896 if (!phydir) 900 if (!phydir)
897 return; 901 return;
898 902
899 debugfs_create_file("debug", S_IWUSR | S_IRUSR, phydir, sc, 903 debugfs_create_file("debug", S_IWUSR | S_IRUSR, phydir, sc,
900 &fops_debug); 904 &fops_debug);
diff --git a/drivers/net/wireless/ath/ath5k/dma.c b/drivers/net/wireless/ath/ath5k/dma.c
index 21091c26a9a5..02e2e3f71b08 100644
--- a/drivers/net/wireless/ath/ath5k/dma.c
+++ b/drivers/net/wireless/ath/ath5k/dma.c
@@ -258,7 +258,7 @@ static int ath5k_hw_stop_tx_dma(struct ath5k_hw *ah, unsigned int queue)
258 /* For 2413+ order PCU to drop packets using 258 /* For 2413+ order PCU to drop packets using
259 * QUIET mechanism */ 259 * QUIET mechanism */
260 if (ah->ah_mac_version >= (AR5K_SREV_AR2414 >> 4) && 260 if (ah->ah_mac_version >= (AR5K_SREV_AR2414 >> 4) &&
261 pending){ 261 pending) {
262 /* Set periodicity and duration */ 262 /* Set periodicity and duration */
263 ath5k_hw_reg_write(ah, 263 ath5k_hw_reg_write(ah,
264 AR5K_REG_SM(100, AR5K_QUIET_CTL2_QT_PER)| 264 AR5K_REG_SM(100, AR5K_QUIET_CTL2_QT_PER)|
diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
index 0c9d8b189559..f2657bf34fea 100644
--- a/drivers/net/wireless/ath/ath5k/eeprom.c
+++ b/drivers/net/wireless/ath/ath5k/eeprom.c
@@ -255,7 +255,7 @@ static int ath5k_eeprom_read_modes(struct ath5k_hw *ah, u32 *offset,
255 ee->ee_n_piers[mode] = 0; 255 ee->ee_n_piers[mode] = 0;
256 AR5K_EEPROM_READ(o++, val); 256 AR5K_EEPROM_READ(o++, val);
257 ee->ee_adc_desired_size[mode] = (s8)((val >> 8) & 0xff); 257 ee->ee_adc_desired_size[mode] = (s8)((val >> 8) & 0xff);
258 switch(mode) { 258 switch (mode) {
259 case AR5K_EEPROM_MODE_11A: 259 case AR5K_EEPROM_MODE_11A:
260 ee->ee_ob[mode][3] = (val >> 5) & 0x7; 260 ee->ee_ob[mode][3] = (val >> 5) & 0x7;
261 ee->ee_db[mode][3] = (val >> 2) & 0x7; 261 ee->ee_db[mode][3] = (val >> 2) & 0x7;
@@ -349,7 +349,7 @@ static int ath5k_eeprom_read_modes(struct ath5k_hw *ah, u32 *offset,
349 /* Note: >= v5 have bg freq piers on another location 349 /* Note: >= v5 have bg freq piers on another location
350 * so these freq piers are ignored for >= v5 (should be 0xff 350 * so these freq piers are ignored for >= v5 (should be 0xff
351 * anyway) */ 351 * anyway) */
352 switch(mode) { 352 switch (mode) {
353 case AR5K_EEPROM_MODE_11A: 353 case AR5K_EEPROM_MODE_11A:
354 if (ah->ah_ee_version < AR5K_EEPROM_VERSION_4_1) 354 if (ah->ah_ee_version < AR5K_EEPROM_VERSION_4_1)
355 break; 355 break;
@@ -422,7 +422,7 @@ static int ath5k_eeprom_read_modes(struct ath5k_hw *ah, u32 *offset,
422 if (ee->ee_version < AR5K_EEPROM_VERSION_5_0) 422 if (ee->ee_version < AR5K_EEPROM_VERSION_5_0)
423 goto done; 423 goto done;
424 424
425 switch (mode){ 425 switch (mode) {
426 case AR5K_EEPROM_MODE_11A: 426 case AR5K_EEPROM_MODE_11A:
427 ee->ee_switch_settling_turbo[mode] = (val >> 6) & 0x7f; 427 ee->ee_switch_settling_turbo[mode] = (val >> 6) & 0x7f;
428 428
@@ -436,7 +436,7 @@ static int ath5k_eeprom_read_modes(struct ath5k_hw *ah, u32 *offset,
436 ee->ee_adc_desired_size_turbo[mode] |= (val & 0x1) << 7; 436 ee->ee_adc_desired_size_turbo[mode] |= (val & 0x1) << 7;
437 ee->ee_pga_desired_size_turbo[mode] = (val >> 1) & 0xff; 437 ee->ee_pga_desired_size_turbo[mode] = (val >> 1) & 0xff;
438 438
439 if (AR5K_EEPROM_EEMAP(ee->ee_misc0) >=2) 439 if (AR5K_EEPROM_EEMAP(ee->ee_misc0) >= 2)
440 ee->ee_pd_gain_overlap = (val >> 9) & 0xf; 440 ee->ee_pd_gain_overlap = (val >> 9) & 0xf;
441 break; 441 break;
442 case AR5K_EEPROM_MODE_11G: 442 case AR5K_EEPROM_MODE_11G:
@@ -516,7 +516,7 @@ ath5k_eeprom_read_freq_list(struct ath5k_hw *ah, int *offset, int max,
516 u16 val; 516 u16 val;
517 517
518 ee->ee_n_piers[mode] = 0; 518 ee->ee_n_piers[mode] = 0;
519 while(i < max) { 519 while (i < max) {
520 AR5K_EEPROM_READ(o++, val); 520 AR5K_EEPROM_READ(o++, val);
521 521
522 freq1 = val & 0xff; 522 freq1 = val & 0xff;
@@ -602,7 +602,7 @@ ath5k_eeprom_init_11bg_2413(struct ath5k_hw *ah, unsigned int mode, int offset)
602 struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; 602 struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
603 struct ath5k_chan_pcal_info *pcal; 603 struct ath5k_chan_pcal_info *pcal;
604 604
605 switch(mode) { 605 switch (mode) {
606 case AR5K_EEPROM_MODE_11B: 606 case AR5K_EEPROM_MODE_11B:
607 pcal = ee->ee_pwr_cal_b; 607 pcal = ee->ee_pwr_cal_b;
608 break; 608 break;
@@ -800,7 +800,7 @@ ath5k_eeprom_read_pcal_info_5111(struct ath5k_hw *ah, int mode)
800 u16 val; 800 u16 val;
801 801
802 offset = AR5K_EEPROM_GROUPS_START(ee->ee_version); 802 offset = AR5K_EEPROM_GROUPS_START(ee->ee_version);
803 switch(mode) { 803 switch (mode) {
804 case AR5K_EEPROM_MODE_11A: 804 case AR5K_EEPROM_MODE_11A:
805 if (!AR5K_EEPROM_HDR_11A(ee->ee_header)) 805 if (!AR5K_EEPROM_HDR_11A(ee->ee_header))
806 return 0; 806 return 0;
@@ -1167,7 +1167,7 @@ ath5k_cal_data_offset_2413(struct ath5k_eeprom_info *ee, int mode)
1167{ 1167{
1168 u32 offset = AR5K_EEPROM_CAL_DATA_START(ee->ee_misc4); 1168 u32 offset = AR5K_EEPROM_CAL_DATA_START(ee->ee_misc4);
1169 1169
1170 switch(mode) { 1170 switch (mode) {
1171 case AR5K_EEPROM_MODE_11G: 1171 case AR5K_EEPROM_MODE_11G:
1172 if (AR5K_EEPROM_HDR_11B(ee->ee_header)) 1172 if (AR5K_EEPROM_HDR_11B(ee->ee_header))
1173 offset += ath5k_pdgains_size_2413(ee, 1173 offset += ath5k_pdgains_size_2413(ee,
@@ -1624,8 +1624,8 @@ ath5k_eeprom_read_ctl_info(struct ath5k_hw *ah)
1624 offset += AR5K_EEPROM_GROUPS_START(ee->ee_version); 1624 offset += AR5K_EEPROM_GROUPS_START(ee->ee_version);
1625 1625
1626 rep = ee->ee_ctl_pwr; 1626 rep = ee->ee_ctl_pwr;
1627 for(i = 0; i < ee->ee_ctls; i++) { 1627 for (i = 0; i < ee->ee_ctls; i++) {
1628 switch(ee->ee_ctl[i] & AR5K_CTL_MODE_M) { 1628 switch (ee->ee_ctl[i] & AR5K_CTL_MODE_M) {
1629 case AR5K_CTL_11A: 1629 case AR5K_CTL_11A:
1630 case AR5K_CTL_TURBO: 1630 case AR5K_CTL_TURBO:
1631 ctl_mode = AR5K_EEPROM_MODE_11A; 1631 ctl_mode = AR5K_EEPROM_MODE_11A;
diff --git a/drivers/net/wireless/ath/ath5k/eeprom.h b/drivers/net/wireless/ath/ath5k/eeprom.h
index 6511c27d938e..6d440e0ba149 100644
--- a/drivers/net/wireless/ath/ath5k/eeprom.h
+++ b/drivers/net/wireless/ath/ath5k/eeprom.h
@@ -223,7 +223,7 @@
223#define AR5K_EEPROM_CCK_OFDM_DELTA 15 223#define AR5K_EEPROM_CCK_OFDM_DELTA 15
224#define AR5K_EEPROM_N_IQ_CAL 2 224#define AR5K_EEPROM_N_IQ_CAL 2
225/* 5GHz/2GHz */ 225/* 5GHz/2GHz */
226enum ath5k_eeprom_freq_bands{ 226enum ath5k_eeprom_freq_bands {
227 AR5K_EEPROM_BAND_5GHZ = 0, 227 AR5K_EEPROM_BAND_5GHZ = 0,
228 AR5K_EEPROM_BAND_2GHZ = 1, 228 AR5K_EEPROM_BAND_2GHZ = 1,
229 AR5K_EEPROM_N_FREQ_BANDS, 229 AR5K_EEPROM_N_FREQ_BANDS,
diff --git a/drivers/net/wireless/ath/ath5k/led.c b/drivers/net/wireless/ath/ath5k/led.c
index 56f1d95abb01..127bfbd35172 100644
--- a/drivers/net/wireless/ath/ath5k/led.c
+++ b/drivers/net/wireless/ath/ath5k/led.c
@@ -43,11 +43,11 @@
43#include "ath5k.h" 43#include "ath5k.h"
44#include "base.h" 44#include "base.h"
45 45
46#define ATH_SDEVICE(subv,subd) \ 46#define ATH_SDEVICE(subv, subd) \
47 .vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \ 47 .vendor = PCI_ANY_ID, .device = PCI_ANY_ID, \
48 .subvendor = (subv), .subdevice = (subd) 48 .subvendor = (subv), .subdevice = (subd)
49 49
50#define ATH_LED(pin,polarity) .driver_data = (((pin) << 8) | (polarity)) 50#define ATH_LED(pin, polarity) .driver_data = (((pin) << 8) | (polarity))
51#define ATH_PIN(data) ((data) >> 8) 51#define ATH_PIN(data) ((data) >> 8)
52#define ATH_POLARITY(data) ((data) & 0xff) 52#define ATH_POLARITY(data) ((data) & 0xff)
53 53
diff --git a/drivers/net/wireless/ath/ath5k/pci.c b/drivers/net/wireless/ath/ath5k/pci.c
index 296c316a8341..bb93796bfaf1 100644
--- a/drivers/net/wireless/ath/ath5k/pci.c
+++ b/drivers/net/wireless/ath/ath5k/pci.c
@@ -234,7 +234,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
234 234
235 mem = pci_iomap(pdev, 0, 0); 235 mem = pci_iomap(pdev, 0, 0);
236 if (!mem) { 236 if (!mem) {
237 dev_err(&pdev->dev, "cannot remap PCI memory region\n") ; 237 dev_err(&pdev->dev, "cannot remap PCI memory region\n");
238 ret = -EIO; 238 ret = -EIO;
239 goto err_reg; 239 goto err_reg;
240 } 240 }
diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index 0a0f63e9675b..aecd72417490 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -534,7 +534,7 @@ u64 ath5k_hw_get_tsf64(struct ath5k_hw *ah)
534 534
535 local_irq_restore(flags); 535 local_irq_restore(flags);
536 536
537 WARN_ON( i == ATH5K_MAX_TSF_READ ); 537 WARN_ON(i == ATH5K_MAX_TSF_READ);
538 538
539 return ((u64)tsf_upper1 << 32) | tsf_lower; 539 return ((u64)tsf_upper1 << 32) | tsf_lower;
540} 540}
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 4e982b65404a..7e2867689e11 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -173,7 +173,7 @@ static unsigned int ath5k_hw_rfb_op(struct ath5k_hw *ah,
173 data = ath5k_hw_bitswap(val, num_bits); 173 data = ath5k_hw_bitswap(val, num_bits);
174 174
175 for (bits_shifted = 0, bits_left = num_bits; bits_left > 0; 175 for (bits_shifted = 0, bits_left = num_bits; bits_left > 0;
176 position = 0, entry++) { 176 position = 0, entry++) {
177 177
178 last_bit = (position + bits_left > 8) ? 8 : 178 last_bit = (position + bits_left > 8) ? 8 :
179 position + bits_left; 179 position + bits_left;
@@ -472,7 +472,7 @@ static bool ath5k_hw_rf_check_gainf_readback(struct ath5k_hw *ah)
472 level[0] = 0; 472 level[0] = 0;
473 level[1] = (step == 63) ? 50 : step + 4; 473 level[1] = (step == 63) ? 50 : step + 4;
474 level[2] = (step != 63) ? 64 : level[0]; 474 level[2] = (step != 63) ? 64 : level[0];
475 level[3] = level[2] + 50 ; 475 level[3] = level[2] + 50;
476 476
477 ah->ah_gain.g_high = level[3] - 477 ah->ah_gain.g_high = level[3] -
478 (step == 63 ? AR5K_GAIN_DYN_ADJUST_HI_MARGIN : -5); 478 (step == 63 ? AR5K_GAIN_DYN_ADJUST_HI_MARGIN : -5);
@@ -549,7 +549,7 @@ static s8 ath5k_hw_rf_gainf_adjust(struct ath5k_hw *ah)
549 549
550 for (ah->ah_gain.g_target = ah->ah_gain.g_current; 550 for (ah->ah_gain.g_target = ah->ah_gain.g_current;
551 ah->ah_gain.g_target <= ah->ah_gain.g_low && 551 ah->ah_gain.g_target <= ah->ah_gain.g_low &&
552 ah->ah_gain.g_step_idx < go->go_steps_count-1; 552 ah->ah_gain.g_step_idx < go->go_steps_count - 1;
553 g_step = &go->go_step[ah->ah_gain.g_step_idx]) 553 g_step = &go->go_step[ah->ah_gain.g_step_idx])
554 ah->ah_gain.g_target -= 2 * 554 ah->ah_gain.g_target -= 2 *
555 (go->go_step[++ah->ah_gain.g_step_idx].gos_gain - 555 (go->go_step[++ah->ah_gain.g_step_idx].gos_gain -
@@ -614,7 +614,7 @@ enum ath5k_rfgain ath5k_hw_gainf_calibrate(struct ath5k_hw *ah)
614 ath5k_hw_rf_gainf_corr(ah); 614 ath5k_hw_rf_gainf_corr(ah);
615 ah->ah_gain.g_current = 615 ah->ah_gain.g_current =
616 ah->ah_gain.g_current >= ah->ah_gain.g_f_corr ? 616 ah->ah_gain.g_current >= ah->ah_gain.g_f_corr ?
617 (ah->ah_gain.g_current-ah->ah_gain.g_f_corr) : 617 (ah->ah_gain.g_current - ah->ah_gain.g_f_corr) :
618 0; 618 0;
619 } 619 }
620 620
@@ -1331,7 +1331,7 @@ void ath5k_hw_init_nfcal_hist(struct ath5k_hw *ah)
1331static void ath5k_hw_update_nfcal_hist(struct ath5k_hw *ah, s16 noise_floor) 1331static void ath5k_hw_update_nfcal_hist(struct ath5k_hw *ah, s16 noise_floor)
1332{ 1332{
1333 struct ath5k_nfcal_hist *hist = &ah->ah_nfcal_hist; 1333 struct ath5k_nfcal_hist *hist = &ah->ah_nfcal_hist;
1334 hist->index = (hist->index + 1) & (ATH5K_NF_CAL_HIST_MAX-1); 1334 hist->index = (hist->index + 1) & (ATH5K_NF_CAL_HIST_MAX - 1);
1335 hist->nfval[hist->index] = noise_floor; 1335 hist->nfval[hist->index] = noise_floor;
1336} 1336}
1337 1337
@@ -1344,10 +1344,10 @@ static s16 ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
1344 memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort)); 1344 memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort));
1345 for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) { 1345 for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) {
1346 for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) { 1346 for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) {
1347 if (sort[j] > sort[j-1]) { 1347 if (sort[j] > sort[j - 1]) {
1348 tmp = sort[j]; 1348 tmp = sort[j];
1349 sort[j] = sort[j-1]; 1349 sort[j] = sort[j - 1];
1350 sort[j-1] = tmp; 1350 sort[j - 1] = tmp;
1351 } 1351 }
1352 } 1352 }
1353 } 1353 }
@@ -1355,7 +1355,7 @@ static s16 ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah)
1355 ATH5K_DBG(ah->ah_sc, ATH5K_DEBUG_CALIBRATE, 1355 ATH5K_DBG(ah->ah_sc, ATH5K_DEBUG_CALIBRATE,
1356 "cal %d:%d\n", i, sort[i]); 1356 "cal %d:%d\n", i, sort[i]);
1357 } 1357 }
1358 return sort[(ATH5K_NF_CAL_HIST_MAX-1) / 2]; 1358 return sort[(ATH5K_NF_CAL_HIST_MAX - 1) / 2];
1359} 1359}
1360 1360
1361/* 1361/*
@@ -2080,7 +2080,7 @@ ath5k_get_interpolated_value(s16 target, s16 x_left, s16 x_right,
2080 * always 1 instead of 1.25, 1.75 etc). We scale up by 100 2080 * always 1 instead of 1.25, 1.75 etc). We scale up by 100
2081 * to have some accuracy both for 0.5 and 0.25 steps. 2081 * to have some accuracy both for 0.5 and 0.25 steps.
2082 */ 2082 */
2083 ratio = ((100 * y_right - 100 * y_left)/(x_right - x_left)); 2083 ratio = ((100 * y_right - 100 * y_left) / (x_right - x_left));
2084 2084
2085 /* Now scale down to be in range */ 2085 /* Now scale down to be in range */
2086 result = y_left + (ratio * (target - x_left) / 100); 2086 result = y_left + (ratio * (target - x_left) / 100);
@@ -2159,7 +2159,7 @@ ath5k_create_power_curve(s16 pmin, s16 pmax,
2159 u8 *vpd_table, u8 type) 2159 u8 *vpd_table, u8 type)
2160{ 2160{
2161 u8 idx[2] = { 0, 1 }; 2161 u8 idx[2] = { 0, 1 };
2162 s16 pwr_i = 2*pmin; 2162 s16 pwr_i = 2 * pmin;
2163 int i; 2163 int i;
2164 2164
2165 if (num_points < 2) 2165 if (num_points < 2)
@@ -2437,7 +2437,7 @@ ath5k_get_max_ctl_power(struct ath5k_hw *ah,
2437 } 2437 }
2438 2438
2439 if (edge_pwr) 2439 if (edge_pwr)
2440 ah->ah_txpower.txp_max_pwr = 4*min(edge_pwr, max_chan_pwr); 2440 ah->ah_txpower.txp_max_pwr = 4 * min(edge_pwr, max_chan_pwr);
2441} 2441}
2442 2442
2443 2443
@@ -2475,8 +2475,8 @@ ath5k_fill_pwr_to_pcdac_table(struct ath5k_hw *ah, s16* table_min,
2475 2475
2476 /* Copy values from pcdac_tmp */ 2476 /* Copy values from pcdac_tmp */
2477 pwr_idx = min_pwr; 2477 pwr_idx = min_pwr;
2478 for (i = 0 ; pwr_idx <= max_pwr && 2478 for (i = 0; pwr_idx <= max_pwr &&
2479 pcdac_i < AR5K_EEPROM_POWER_TABLE_SIZE; i++) { 2479 pcdac_i < AR5K_EEPROM_POWER_TABLE_SIZE; i++) {
2480 pcdac_out[pcdac_i++] = pcdac_tmp[i]; 2480 pcdac_out[pcdac_i++] = pcdac_tmp[i];
2481 pwr_idx++; 2481 pwr_idx++;
2482 } 2482 }
@@ -2552,7 +2552,7 @@ ath5k_combine_linear_pcdac_curves(struct ath5k_hw *ah, s16* table_min,
2552 } 2552 }
2553 2553
2554 /* This is used when setting tx power*/ 2554 /* This is used when setting tx power*/
2555 ah->ah_txpower.txp_min_idx = min_pwr_idx/2; 2555 ah->ah_txpower.txp_min_idx = min_pwr_idx / 2;
2556 2556
2557 /* Fill Power to PCDAC table backwards */ 2557 /* Fill Power to PCDAC table backwards */
2558 pwr = max_pwr_idx; 2558 pwr = max_pwr_idx;
@@ -2561,10 +2561,10 @@ ath5k_combine_linear_pcdac_curves(struct ath5k_hw *ah, s16* table_min,
2561 * edge flag and set pcdac_tmp to lower 2561 * edge flag and set pcdac_tmp to lower
2562 * power curve.*/ 2562 * power curve.*/
2563 if (edge_flag == 0x40 && 2563 if (edge_flag == 0x40 &&
2564 (2*pwr <= (table_max[1] - table_min[0]) || pwr == 0)) { 2564 (2 * pwr <= (table_max[1] - table_min[0]) || pwr == 0)) {
2565 edge_flag = 0x00; 2565 edge_flag = 0x00;
2566 pcdac_tmp = pcdac_low_pwr; 2566 pcdac_tmp = pcdac_low_pwr;
2567 pwr = mid_pwr_idx/2; 2567 pwr = mid_pwr_idx / 2;
2568 } 2568 }
2569 2569
2570 /* Don't go below 1, extrapolate below if we have 2570 /* Don't go below 1, extrapolate below if we have
@@ -2604,8 +2604,8 @@ ath5k_write_pcdac_table(struct ath5k_hw *ah)
2604 */ 2604 */
2605 for (i = 0; i < (AR5K_EEPROM_POWER_TABLE_SIZE / 2); i++) { 2605 for (i = 0; i < (AR5K_EEPROM_POWER_TABLE_SIZE / 2); i++) {
2606 ath5k_hw_reg_write(ah, 2606 ath5k_hw_reg_write(ah,
2607 (((pcdac_out[2*i + 0] << 8 | 0xff) & 0xffff) << 0) | 2607 (((pcdac_out[2 * i + 0] << 8 | 0xff) & 0xffff) << 0) |
2608 (((pcdac_out[2*i + 1] << 8 | 0xff) & 0xffff) << 16), 2608 (((pcdac_out[2 * i + 1] << 8 | 0xff) & 0xffff) << 16),
2609 AR5K_PHY_PCDAC_TXPOWER(i)); 2609 AR5K_PHY_PCDAC_TXPOWER(i));
2610 } 2610 }
2611} 2611}
@@ -2789,10 +2789,10 @@ ath5k_write_pwr_to_pdadc_table(struct ath5k_hw *ah, u8 ee_mode)
2789 */ 2789 */
2790 for (i = 0; i < (AR5K_EEPROM_POWER_TABLE_SIZE / 2); i++) { 2790 for (i = 0; i < (AR5K_EEPROM_POWER_TABLE_SIZE / 2); i++) {
2791 ath5k_hw_reg_write(ah, 2791 ath5k_hw_reg_write(ah,
2792 ((pdadc_out[4*i + 0] & 0xff) << 0) | 2792 ((pdadc_out[4 * i + 0] & 0xff) << 0) |
2793 ((pdadc_out[4*i + 1] & 0xff) << 8) | 2793 ((pdadc_out[4 * i + 1] & 0xff) << 8) |
2794 ((pdadc_out[4*i + 2] & 0xff) << 16) | 2794 ((pdadc_out[4 * i + 2] & 0xff) << 16) |
2795 ((pdadc_out[4*i + 3] & 0xff) << 24), 2795 ((pdadc_out[4 * i + 3] & 0xff) << 24),
2796 AR5K_PHY_PDADC_TXPOWER(i)); 2796 AR5K_PHY_PDADC_TXPOWER(i));
2797 } 2797 }
2798} 2798}
diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c
index bbeef3aac93f..19aefdb75416 100644
--- a/drivers/net/wireless/ath/ath5k/reset.c
+++ b/drivers/net/wireless/ath/ath5k/reset.c
@@ -142,10 +142,10 @@ static void ath5k_hw_init_core_clock(struct ath5k_hw *ah)
142 142
143 /* Set 32MHz USEC counter */ 143 /* Set 32MHz USEC counter */
144 if ((ah->ah_radio == AR5K_RF5112) || 144 if ((ah->ah_radio == AR5K_RF5112) ||
145 (ah->ah_radio == AR5K_RF5413) || 145 (ah->ah_radio == AR5K_RF5413) ||
146 (ah->ah_radio == AR5K_RF2316) || 146 (ah->ah_radio == AR5K_RF2316) ||
147 (ah->ah_radio == AR5K_RF2317)) 147 (ah->ah_radio == AR5K_RF2317))
148 /* Remain on 40MHz clock ? */ 148 /* Remain on 40MHz clock ? */
149 sclock = 40 - 1; 149 sclock = 40 - 1;
150 else 150 else
151 sclock = 32 - 1; 151 sclock = 32 - 1;