diff options
author | Senthil Balasubramanian <senthilkumar@atheros.com> | 2010-10-05 11:06:40 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2010-10-06 16:30:40 -0400 |
commit | fbab7390f954e3517c72d12cfd9a1502699aa368 (patch) | |
tree | 35c1a58ac086162531e06a5c8f9e3b0b3fb829c4 /drivers/net/wireless/ath/ath9k/xmit.c | |
parent | 95792178a58716a6afaeb5ab9654f1a0f17a5e8e (diff) |
ath9k: remove unnecessary power save flags.
drv_config callback is called only after the ack for the nullframe
is received and so driver need not do anything special for this.
So remove NULLFUNC_COMPLETED, PS_ENABLED flags and bf_isnullfunc
flags from ath9k as mac80211 already handles them properly.
Signed-off-by: Senthil Balasubramanian <senthilkumar@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath9k/xmit.c')
-rw-r--r-- | drivers/net/wireless/ath/ath9k/xmit.c | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index f7da6b20a925..aa447770eb2b 100644 --- a/drivers/net/wireless/ath/ath9k/xmit.c +++ b/drivers/net/wireless/ath/ath9k/xmit.c | |||
@@ -1648,13 +1648,6 @@ static int ath_tx_setup_buffer(struct ieee80211_hw *hw, struct ath_buf *bf, | |||
1648 | 1648 | ||
1649 | bf->bf_buf_addr = bf->bf_dmacontext; | 1649 | bf->bf_buf_addr = bf->bf_dmacontext; |
1650 | 1650 | ||
1651 | /* tag if this is a nullfunc frame to enable PS when AP acks it */ | ||
1652 | if (ieee80211_is_nullfunc(fc) && ieee80211_has_pm(fc)) { | ||
1653 | bf->bf_isnullfunc = true; | ||
1654 | sc->ps_flags &= ~PS_NULLFUNC_COMPLETED; | ||
1655 | } else | ||
1656 | bf->bf_isnullfunc = false; | ||
1657 | |||
1658 | bf->bf_tx_aborted = false; | 1651 | bf->bf_tx_aborted = false; |
1659 | 1652 | ||
1660 | return 0; | 1653 | return 0; |
@@ -2082,18 +2075,6 @@ static void ath_tx_processq(struct ath_softc *sc, struct ath_txq *txq) | |||
2082 | } | 2075 | } |
2083 | 2076 | ||
2084 | /* | 2077 | /* |
2085 | * We now know the nullfunc frame has been ACKed so we | ||
2086 | * can disable RX. | ||
2087 | */ | ||
2088 | if (bf->bf_isnullfunc && | ||
2089 | (ts.ts_status & ATH9K_TX_ACKED)) { | ||
2090 | if ((sc->ps_flags & PS_ENABLED)) | ||
2091 | ath9k_enable_ps(sc); | ||
2092 | else | ||
2093 | sc->ps_flags |= PS_NULLFUNC_COMPLETED; | ||
2094 | } | ||
2095 | |||
2096 | /* | ||
2097 | * Remove ath_buf's of the same transmit unit from txq, | 2078 | * Remove ath_buf's of the same transmit unit from txq, |
2098 | * however leave the last descriptor back as the holding | 2079 | * however leave the last descriptor back as the holding |
2099 | * descriptor for hw. | 2080 | * descriptor for hw. |
@@ -2236,17 +2217,6 @@ void ath_tx_edma_tasklet(struct ath_softc *sc) | |||
2236 | 2217 | ||
2237 | txok = !(txs.ts_status & ATH9K_TXERR_MASK); | 2218 | txok = !(txs.ts_status & ATH9K_TXERR_MASK); |
2238 | 2219 | ||
2239 | /* | ||
2240 | * Make sure null func frame is acked before configuring | ||
2241 | * hw into ps mode. | ||
2242 | */ | ||
2243 | if (bf->bf_isnullfunc && txok) { | ||
2244 | if ((sc->ps_flags & PS_ENABLED)) | ||
2245 | ath9k_enable_ps(sc); | ||
2246 | else | ||
2247 | sc->ps_flags |= PS_NULLFUNC_COMPLETED; | ||
2248 | } | ||
2249 | |||
2250 | if (!bf_isampdu(bf)) { | 2220 | if (!bf_isampdu(bf)) { |
2251 | if (txs.ts_status & ATH9K_TXERR_XRETRY) | 2221 | if (txs.ts_status & ATH9K_TXERR_XRETRY) |
2252 | bf->bf_state.bf_type |= BUF_XRETRY; | 2222 | bf->bf_state.bf_type |= BUF_XRETRY; |