diff options
author | John W. Linville <linville@tuxdriver.com> | 2011-04-14 10:38:22 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-04-14 15:29:06 -0400 |
commit | dfa8fc69d92f8418e1296d762f3b1624df59f0ac (patch) | |
tree | d511a8f09a447b8258625721f09cc2ce82242a9d /drivers/net/wireless/ath/ath9k/hif_usb.c | |
parent | a3e6b12c0232748658a602eda39f12fddb254ba8 (diff) |
ath9k: avoid using trinary operator w/ TX_STAT_INC
Otherwise, you get this:
CC [M] drivers/net/wireless/ath/ath9k/hif_usb.o
drivers/net/wireless/ath/ath9k/hif_usb.c: In function ‘ath9k_skb_queue_complete’:
drivers/net/wireless/ath/ath9k/hif_usb.c:230:12: error: expected expression before ‘do’
make[2]: *** [drivers/net/wireless/ath/ath9k/hif_usb.o] Error 1
make[1]: *** [drivers/net/wireless/ath/ath9k] Error 2
make: *** [drivers/net/wireless/ath/] Error 2
The TX_STAT_INC macro should probably be changed to accomodate such
usage, although using a trinary operator in place of an if-else seems
questionable to me anyway.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Sujith Manoharan <Sujith.Manoharan@Atheros.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath9k/hif_usb.c')
-rw-r--r-- | drivers/net/wireless/ath/ath9k/hif_usb.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c index 3b0efab65131..48bcc1a21076 100644 --- a/drivers/net/wireless/ath/ath9k/hif_usb.c +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c | |||
@@ -227,7 +227,10 @@ static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev, | |||
227 | while ((skb = __skb_dequeue(queue)) != NULL) { | 227 | while ((skb = __skb_dequeue(queue)) != NULL) { |
228 | ath9k_htc_txcompletion_cb(hif_dev->htc_handle, | 228 | ath9k_htc_txcompletion_cb(hif_dev->htc_handle, |
229 | skb, txok); | 229 | skb, txok); |
230 | (txok) ? TX_STAT_INC(skb_success) : TX_STAT_INC(skb_failed); | 230 | if (txok) |
231 | TX_STAT_INC(skb_success); | ||
232 | else | ||
233 | TX_STAT_INC(skb_failed); | ||
231 | } | 234 | } |
232 | } | 235 | } |
233 | 236 | ||