mac80211: clarify interface iteration and make it configurable

During hardware restart, all interfaces are iterated even
though they haven't been re-added to the driver, document
this behaviour. The same also happens during resume, which
is even more confusing since all of the interfaces were
previously removed from the driver. Make this optional so
drivers relying on the current behaviour can still use it,
but to let drivers that don't want this behaviour disable
it.

Also convert all API users, keeping the old semantics
except in hwsim, where the new normal ones are desired.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

2 files changed, 9 insertions, 6 deletions

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 9f31cfa56cc0..cdd19232960c 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -511,8 +511,9 @@ ath5k_update_bssid_mask_and_opmode(struct ath5k_hw *ah,
                 ath5k_vif_iter(&iter_data, vif->addr, vif);
 
         /* Get list of all active MAC addresses */
-        ieee80211_iterate_active_interfaces_atomic(ah->hw, ath5k_vif_iter,
-                                                   &iter_data);
+        ieee80211_iterate_active_interfaces_atomic(
+                ah->hw, IEEE80211_IFACE_ITER_RESUME_ALL,
+                ath5k_vif_iter, &iter_data);
         memcpy(ah->bssidmask, iter_data.mask, ETH_ALEN);
 
         ah->opmode = iter_data.opmode;
@@ -3045,8 +3046,9 @@ ath5k_any_vif_assoc(struct ath5k_hw *ah)
         iter_data.need_set_hw_addr = false;
         iter_data.found_active = true;
 
-        ieee80211_iterate_active_interfaces_atomic(ah->hw, ath5k_vif_iter,
-                                                   &iter_data);
+        ieee80211_iterate_active_interfaces_atomic(
+                ah->hw, IEEE80211_IFACE_ITER_RESUME_ALL,
+                ath5k_vif_iter, &iter_data);
         return iter_data.any_assoc;
 }
 
diff --git a/drivers/net/wireless/ath/ath5k/mac80211-ops.c b/drivers/net/wireless/ath/ath5k/mac80211-ops.c
index 7a28538e6e05..1ea8c8795c8e 100644
--- a/drivers/net/wireless/ath/ath5k/mac80211-ops.c
+++ b/drivers/net/wireless/ath/ath5k/mac80211-ops.c
@@ -452,8 +452,9 @@ ath5k_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags,
         iter_data.hw_macaddr = NULL;
         iter_data.n_stas = 0;
         iter_data.need_set_hw_addr = false;
-        ieee80211_iterate_active_interfaces_atomic(ah->hw, ath5k_vif_iter,
-                                                   &iter_data);
+        ieee80211_iterate_active_interfaces_atomic(
+                ah->hw, IEEE80211_IFACE_ITER_RESUME_ALL,
+                ath5k_vif_iter, &iter_data);
 
         /* Set up RX Filter */
         if (iter_data.n_stas > 1) {