aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wan
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2011-03-21 06:25:08 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2011-04-22 20:31:53 -0400
commitb1c43f82c5aa265442f82dba31ce985ebb7aa71c (patch)
tree8b344d8d5355b30e8deff901180edc708a653227 /drivers/net/wan
parente9a470f445271eb157ee860a93b062324402fc3a (diff)
tty: make receive_buf() return the amout of bytes received
it makes it simpler to keep track of the amount of bytes received and simplifies how flush_to_ldisc counts the remaining bytes. It also fixes a bug of lost bytes on n_tty when flushing too many bytes via the USB serial gadget driver. Tested-by: Stefan Bigler <stefan.bigler@keymile.com> Tested-by: Toby Gray <toby.gray@realvnc.com> Signed-off-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/net/wan')
-rw-r--r--drivers/net/wan/x25_asy.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
index 24297b274cd4..40398bf7d036 100644
--- a/drivers/net/wan/x25_asy.c
+++ b/drivers/net/wan/x25_asy.c
@@ -517,17 +517,18 @@ static int x25_asy_close(struct net_device *dev)
517 * and sent on to some IP layer for further processing. 517 * and sent on to some IP layer for further processing.
518 */ 518 */
519 519
520static void x25_asy_receive_buf(struct tty_struct *tty, 520static unsigned int x25_asy_receive_buf(struct tty_struct *tty,
521 const unsigned char *cp, char *fp, int count) 521 const unsigned char *cp, char *fp, int count)
522{ 522{
523 struct x25_asy *sl = tty->disc_data; 523 struct x25_asy *sl = tty->disc_data;
524 int bytes = count;
524 525
525 if (!sl || sl->magic != X25_ASY_MAGIC || !netif_running(sl->dev)) 526 if (!sl || sl->magic != X25_ASY_MAGIC || !netif_running(sl->dev))
526 return; 527 return;
527 528
528 529
529 /* Read the characters out of the buffer */ 530 /* Read the characters out of the buffer */
530 while (count--) { 531 while (bytes--) {
531 if (fp && *fp++) { 532 if (fp && *fp++) {
532 if (!test_and_set_bit(SLF_ERROR, &sl->flags)) 533 if (!test_and_set_bit(SLF_ERROR, &sl->flags))
533 sl->dev->stats.rx_errors++; 534 sl->dev->stats.rx_errors++;
@@ -536,6 +537,8 @@ static void x25_asy_receive_buf(struct tty_struct *tty,
536 } 537 }
537 x25_asy_unesc(sl, *cp++); 538 x25_asy_unesc(sl, *cp++);
538 } 539 }
540
541 return count;
539} 542}
540 543
541/* 544/*