diff options
author | Shreyas Bhatewara <sbhatewara@vmware.com> | 2012-02-28 17:08:39 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-03-04 21:37:51 -0500 |
commit | 4c1dc80a74384829e467ba078260094d1ffdd963 (patch) | |
tree | fcfa62d7d1f13f46d0f56efa89b31514ef28307a /drivers/net/vmxnet3 | |
parent | 0b471506712dd734964b3270d2aa88160712c262 (diff) |
vmxnet3: Fix log messages and corrects some typos
Fix log messages and corrects some typos
Change logging of failure to enable MSI/MSI-X to display device's PCI
address instead of eth%d. Rectify a typo.
Signed-off-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
Reviewed-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vmxnet3')
-rw-r--r-- | drivers/net/vmxnet3/vmxnet3_drv.c | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index adf527e27583..a9684a53af19 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c | |||
@@ -2704,8 +2704,8 @@ vmxnet3_acquire_msix_vectors(struct vmxnet3_adapter *adapter, | |||
2704 | adapter->intr.num_intrs = vectors; | 2704 | adapter->intr.num_intrs = vectors; |
2705 | return 0; | 2705 | return 0; |
2706 | } else if (err < 0) { | 2706 | } else if (err < 0) { |
2707 | printk(KERN_ERR "Failed to enable MSI-X for %s, error" | 2707 | netdev_err(adapter->netdev, |
2708 | " %d\n", adapter->netdev->name, err); | 2708 | "Failed to enable MSI-X, error: %d\n", err); |
2709 | vectors = 0; | 2709 | vectors = 0; |
2710 | } else if (err < vector_threshold) { | 2710 | } else if (err < vector_threshold) { |
2711 | break; | 2711 | break; |
@@ -2713,15 +2713,15 @@ vmxnet3_acquire_msix_vectors(struct vmxnet3_adapter *adapter, | |||
2713 | /* If fails to enable required number of MSI-x vectors | 2713 | /* If fails to enable required number of MSI-x vectors |
2714 | * try enabling minimum number of vectors required. | 2714 | * try enabling minimum number of vectors required. |
2715 | */ | 2715 | */ |
2716 | netdev_err(adapter->netdev, | ||
2717 | "Failed to enable %d MSI-X, trying %d instead\n", | ||
2718 | vectors, vector_threshold); | ||
2716 | vectors = vector_threshold; | 2719 | vectors = vector_threshold; |
2717 | printk(KERN_ERR "Failed to enable %d MSI-X for %s, try" | ||
2718 | " %d instead\n", vectors, adapter->netdev->name, | ||
2719 | vector_threshold); | ||
2720 | } | 2720 | } |
2721 | } | 2721 | } |
2722 | 2722 | ||
2723 | printk(KERN_INFO "Number of MSI-X interrupts which can be allocatedi" | 2723 | netdev_info(adapter->netdev, |
2724 | " are lower than min threshold required.\n"); | 2724 | "Number of MSI-X interrupts which can be allocated are lower than min threshold required.\n"); |
2725 | return err; | 2725 | return err; |
2726 | } | 2726 | } |
2727 | 2727 | ||
@@ -2787,8 +2787,9 @@ vmxnet3_alloc_intr_resources(struct vmxnet3_adapter *adapter) | |||
2787 | return; | 2787 | return; |
2788 | 2788 | ||
2789 | /* If we cannot allocate MSIx vectors use only one rx queue */ | 2789 | /* If we cannot allocate MSIx vectors use only one rx queue */ |
2790 | printk(KERN_INFO "Failed to enable MSI-X for %s, error %d." | 2790 | netdev_info(adapter->netdev, |
2791 | "#rx queues : 1, try MSI\n", adapter->netdev->name, err); | 2791 | "Failed to enable MSI-X, error %d . Limiting #rx queues to 1, try MSI.\n", |
2792 | err); | ||
2792 | 2793 | ||
2793 | adapter->intr.type = VMXNET3_IT_MSI; | 2794 | adapter->intr.type = VMXNET3_IT_MSI; |
2794 | } | 2795 | } |