diff options
author | Jiri Slaby <jslaby@suse.cz> | 2012-03-05 08:51:52 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-03-08 14:37:58 -0500 |
commit | 2f16669d322e05171c9e1cfd94f402f7399bd2a3 (patch) | |
tree | 6a036cd0352928dd7056976a5f457c229322d67f /drivers/net/usb | |
parent | 87cab16beb882d3f9e61a2c0184fa7cf76de1f90 (diff) |
TTY: remove re-assignments to tty_driver members
All num, magic and owner are set by alloc_tty_driver. No need to
re-set them on each allocation site.
pti driver sets something different to what it passes to
alloc_tty_driver. It is not a bug, since we don't use the lines
parameter in any way. Anyway this is fixed, and now we do the right
thing.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/usb')
-rw-r--r-- | drivers/net/usb/hso.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 304fe78ff60e..a73090f4c688 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c | |||
@@ -3313,7 +3313,6 @@ static int __init hso_init(void) | |||
3313 | 3313 | ||
3314 | /* fill in all needed values */ | 3314 | /* fill in all needed values */ |
3315 | tty_drv->magic = TTY_DRIVER_MAGIC; | 3315 | tty_drv->magic = TTY_DRIVER_MAGIC; |
3316 | tty_drv->owner = THIS_MODULE; | ||
3317 | tty_drv->driver_name = driver_name; | 3316 | tty_drv->driver_name = driver_name; |
3318 | tty_drv->name = tty_filename; | 3317 | tty_drv->name = tty_filename; |
3319 | 3318 | ||
@@ -3322,7 +3321,6 @@ static int __init hso_init(void) | |||
3322 | tty_drv->major = tty_major; | 3321 | tty_drv->major = tty_major; |
3323 | 3322 | ||
3324 | tty_drv->minor_start = 0; | 3323 | tty_drv->minor_start = 0; |
3325 | tty_drv->num = HSO_SERIAL_TTY_MINORS; | ||
3326 | tty_drv->type = TTY_DRIVER_TYPE_SERIAL; | 3324 | tty_drv->type = TTY_DRIVER_TYPE_SERIAL; |
3327 | tty_drv->subtype = SERIAL_TYPE_NORMAL; | 3325 | tty_drv->subtype = SERIAL_TYPE_NORMAL; |
3328 | tty_drv->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV; | 3326 | tty_drv->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV; |