Merge branch 'wip-2.6.34' into old-private-masterarchived-private-master

1 files changed, 6 insertions, 9 deletions

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index b091e20ca167..e85c89c6706d 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -270,7 +270,7 @@ static int read_mii_word(rtl8150_t * dev, u8 phy, __u8 indx, u16 * reg)
                 get_registers(dev, PHYCNT, 1, data);
         } while ((data[0] & PHY_GO) && (i++ < MII_TIMEOUT));
 
-        if (i < MII_TIMEOUT) {
+        if (i <= MII_TIMEOUT) {
                 get_registers(dev, PHYDAT, 2, data);
                 *reg = data[0] | (data[1] << 8);
                 return 0;
@@ -295,7 +295,7 @@ static int write_mii_word(rtl8150_t * dev, u8 phy, __u8 indx, u16 reg)
                 get_registers(dev, PHYCNT, 1, data);
         } while ((data[0] & PHY_GO) && (i++ < MII_TIMEOUT));
 
-        if (i < MII_TIMEOUT)
+        if (i <= MII_TIMEOUT)
                 return 0;
         else
                 return 1;
@@ -313,20 +313,17 @@ static int rtl8150_set_mac_address(struct net_device *netdev, void *p)
 {
         struct sockaddr *addr = p;
         rtl8150_t *dev = netdev_priv(netdev);
-        int i;
 
         if (netif_running(netdev))
                 return -EBUSY;
 
         memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
-        dbg("%s: Setting MAC address to ", netdev->name);
-        for (i = 0; i < 5; i++)
-                dbg("%02X:", netdev->dev_addr[i]);
-        dbg("%02X\n", netdev->dev_addr[i]);
+        dbg("%s: Setting MAC address to %pM\n", netdev->name, netdev->dev_addr);
         /* Set the IDR registers. */
-        set_registers(dev, IDR, sizeof(netdev->dev_addr), netdev->dev_addr);
+        set_registers(dev, IDR, netdev->addr_len, netdev->dev_addr);
 #ifdef EEPROM_WRITE
         {
+        int i;
         u8 cr;
         /* Get the CR contents. */
         get_registers(dev, CR, 1, &cr);
@@ -714,7 +711,7 @@ static void rtl8150_set_multicast(struct net_device *netdev)
         if (netdev->flags & IFF_PROMISC) {
                 dev->rx_creg |= cpu_to_le16(0x0001);
                 dev_info(&netdev->dev, "%s: promiscuous mode\n", netdev->name);
-        } else if (netdev->mc_count ||
+        } else if (!netdev_mc_empty(netdev) ||
                    (netdev->flags & IFF_ALLMULTI)) {
                 dev->rx_creg &= cpu_to_le16(0xfffe);
                 dev->rx_creg |= cpu_to_le16(0x0002);