diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 15:37:47 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 15:37:47 -0400 |
commit | 50c627c9c39f38c2c2f50b8b24c86d47324d28c1 (patch) | |
tree | c57c32fd60d59144d5b2a2c8c14ae6ffff7b7af8 /drivers/net/usb/catc.c | |
parent | 729be47735638c3441f67d8c7e99c20f6086e5df (diff) |
USB: catc.c: remove err() usage
err() was a very old USB-specific macro that I thought had
gone away. This patch removes it from being used in the
driver and uses dev_err() instead.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/usb/catc.c')
-rw-r--r-- | drivers/net/usb/catc.c | 25 |
1 files changed, 15 insertions, 10 deletions
diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 182cfb4aeb1d..5a73730b32eb 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c | |||
@@ -338,16 +338,18 @@ static void catc_irq_done(struct urb *urb) | |||
338 | } else { | 338 | } else { |
339 | catc->rx_urb->dev = catc->usbdev; | 339 | catc->rx_urb->dev = catc->usbdev; |
340 | if ((res = usb_submit_urb(catc->rx_urb, GFP_ATOMIC)) < 0) { | 340 | if ((res = usb_submit_urb(catc->rx_urb, GFP_ATOMIC)) < 0) { |
341 | err("submit(rx_urb) status %d", res); | 341 | dev_err(&catc->usbdev->dev, |
342 | "submit(rx_urb) status %d\n", res); | ||
342 | } | 343 | } |
343 | } | 344 | } |
344 | } | 345 | } |
345 | resubmit: | 346 | resubmit: |
346 | res = usb_submit_urb (urb, GFP_ATOMIC); | 347 | res = usb_submit_urb (urb, GFP_ATOMIC); |
347 | if (res) | 348 | if (res) |
348 | err ("can't resubmit intr, %s-%s, status %d", | 349 | dev_err(&catc->usbdev->dev, |
349 | catc->usbdev->bus->bus_name, | 350 | "can't resubmit intr, %s-%s, status %d\n", |
350 | catc->usbdev->devpath, res); | 351 | catc->usbdev->bus->bus_name, |
352 | catc->usbdev->devpath, res); | ||
351 | } | 353 | } |
352 | 354 | ||
353 | /* | 355 | /* |
@@ -366,7 +368,8 @@ static int catc_tx_run(struct catc *catc) | |||
366 | catc->tx_urb->dev = catc->usbdev; | 368 | catc->tx_urb->dev = catc->usbdev; |
367 | 369 | ||
368 | if ((status = usb_submit_urb(catc->tx_urb, GFP_ATOMIC)) < 0) | 370 | if ((status = usb_submit_urb(catc->tx_urb, GFP_ATOMIC)) < 0) |
369 | err("submit(tx_urb), status %d", status); | 371 | dev_err(&catc->usbdev->dev, "submit(tx_urb), status %d\n", |
372 | status); | ||
370 | 373 | ||
371 | catc->tx_idx = !catc->tx_idx; | 374 | catc->tx_idx = !catc->tx_idx; |
372 | catc->tx_ptr = 0; | 375 | catc->tx_ptr = 0; |
@@ -496,7 +499,8 @@ static void catc_ctrl_run(struct catc *catc) | |||
496 | memcpy(catc->ctrl_buf, q->buf, q->len); | 499 | memcpy(catc->ctrl_buf, q->buf, q->len); |
497 | 500 | ||
498 | if ((status = usb_submit_urb(catc->ctrl_urb, GFP_ATOMIC))) | 501 | if ((status = usb_submit_urb(catc->ctrl_urb, GFP_ATOMIC))) |
499 | err("submit(ctrl_urb) status %d", status); | 502 | dev_err(&catc->usbdev->dev, "submit(ctrl_urb) status %d\n", |
503 | status); | ||
500 | } | 504 | } |
501 | 505 | ||
502 | static void catc_ctrl_done(struct urb *urb) | 506 | static void catc_ctrl_done(struct urb *urb) |
@@ -555,7 +559,7 @@ static int catc_ctrl_async(struct catc *catc, u8 dir, u8 request, u16 value, | |||
555 | catc->ctrl_head = (catc->ctrl_head + 1) & (CTRL_QUEUE - 1); | 559 | catc->ctrl_head = (catc->ctrl_head + 1) & (CTRL_QUEUE - 1); |
556 | 560 | ||
557 | if (catc->ctrl_head == catc->ctrl_tail) { | 561 | if (catc->ctrl_head == catc->ctrl_tail) { |
558 | err("ctrl queue full"); | 562 | dev_err(&catc->usbdev->dev, "ctrl queue full\n"); |
559 | catc->ctrl_tail = (catc->ctrl_tail + 1) & (CTRL_QUEUE - 1); | 563 | catc->ctrl_tail = (catc->ctrl_tail + 1) & (CTRL_QUEUE - 1); |
560 | retval = -1; | 564 | retval = -1; |
561 | } | 565 | } |
@@ -714,7 +718,8 @@ static int catc_open(struct net_device *netdev) | |||
714 | 718 | ||
715 | catc->irq_urb->dev = catc->usbdev; | 719 | catc->irq_urb->dev = catc->usbdev; |
716 | if ((status = usb_submit_urb(catc->irq_urb, GFP_KERNEL)) < 0) { | 720 | if ((status = usb_submit_urb(catc->irq_urb, GFP_KERNEL)) < 0) { |
717 | err("submit(irq_urb) status %d", status); | 721 | dev_err(&catc->usbdev->dev, "submit(irq_urb) status %d\n", |
722 | status); | ||
718 | return -1; | 723 | return -1; |
719 | } | 724 | } |
720 | 725 | ||
@@ -769,7 +774,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id | |||
769 | 774 | ||
770 | if (usb_set_interface(usbdev, | 775 | if (usb_set_interface(usbdev, |
771 | intf->altsetting->desc.bInterfaceNumber, 1)) { | 776 | intf->altsetting->desc.bInterfaceNumber, 1)) { |
772 | err("Can't set altsetting 1."); | 777 | dev_err(&intf->dev, "Can't set altsetting 1.\n"); |
773 | return -EIO; | 778 | return -EIO; |
774 | } | 779 | } |
775 | 780 | ||
@@ -799,7 +804,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id | |||
799 | catc->irq_urb = usb_alloc_urb(0, GFP_KERNEL); | 804 | catc->irq_urb = usb_alloc_urb(0, GFP_KERNEL); |
800 | if ((!catc->ctrl_urb) || (!catc->tx_urb) || | 805 | if ((!catc->ctrl_urb) || (!catc->tx_urb) || |
801 | (!catc->rx_urb) || (!catc->irq_urb)) { | 806 | (!catc->rx_urb) || (!catc->irq_urb)) { |
802 | err("No free urbs available."); | 807 | dev_err(&intf->dev, "No free urbs available.\n"); |
803 | usb_free_urb(catc->ctrl_urb); | 808 | usb_free_urb(catc->ctrl_urb); |
804 | usb_free_urb(catc->tx_urb); | 809 | usb_free_urb(catc->tx_urb); |
805 | usb_free_urb(catc->rx_urb); | 810 | usb_free_urb(catc->rx_urb); |