Merge branch 'mpi-master' into wip-k-fmlpwip-k-fmlp

Conflicts:
	litmus/sched_cedf.c

20 files changed, 234 insertions, 236 deletions

diff --git a/drivers/net/skfp/Makefile b/drivers/net/skfp/Makefile
index cb23580fcffa..b0be0234abf6 100644
--- a/drivers/net/skfp/Makefile
+++ b/drivers/net/skfp/Makefile
@@ -17,4 +17,4 @@ skfp-objs :=  skfddi.o    hwmtm.o    fplustm.o  smt.o      cfm.o     \
 #   projects. To keep the source common for all those drivers (and
 #   thus simplify fixes to it), please do not clean it up!
 
-EXTRA_CFLAGS += -Idrivers/net/skfp -DPCI -DMEM_MAPPED_IO -Wno-strict-prototypes 
+ccflags-y := -Idrivers/net/skfp -DPCI -DMEM_MAPPED_IO -Wno-strict-prototypes
diff --git a/drivers/net/skfp/cfm.c b/drivers/net/skfp/cfm.c
index 5310d39b5737..e395ace3120b 100644
--- a/drivers/net/skfp/cfm.c
+++ b/drivers/net/skfp/cfm.c
@@ -542,8 +542,8 @@ static void cfm_fsm(struct s_smc *smc, int cmd)
  */
 int cfm_get_mac_input(struct s_smc *smc)
 {
-        return((smc->mib.fddiSMTCF_State == SC10_C_WRAP_B ||
-                smc->mib.fddiSMTCF_State == SC5_THRU_B) ? PB : PA) ;
+        return (smc->mib.fddiSMTCF_State == SC10_C_WRAP_B ||
+                smc->mib.fddiSMTCF_State == SC5_THRU_B) ? PB : PA;
 }
 
 /*
@@ -553,8 +553,8 @@ int cfm_get_mac_input(struct s_smc *smc)
  */
 int cfm_get_mac_output(struct s_smc *smc)
 {
-        return((smc->mib.fddiSMTCF_State == SC10_C_WRAP_B ||
-                smc->mib.fddiSMTCF_State == SC4_THRU_A) ? PB : PA) ;
+        return (smc->mib.fddiSMTCF_State == SC10_C_WRAP_B ||
+                smc->mib.fddiSMTCF_State == SC4_THRU_A) ? PB : PA;
 }
 
 static char path_iso[] = {
@@ -623,5 +623,5 @@ int cem_build_path(struct s_smc *smc, char *to, int path_index)
 
         LINT_USE(path_index);
 
-        return(len) ;
+        return len;
 }
diff --git a/drivers/net/skfp/drvfbi.c b/drivers/net/skfp/drvfbi.c
index c77cc14b3227..07da97c303d6 100644
--- a/drivers/net/skfp/drvfbi.c
+++ b/drivers/net/skfp/drvfbi.c
@@ -267,7 +267,7 @@ void timer_irq(struct s_smc *smc)
 int pcm_get_s_port(struct s_smc *smc)
 {
         SK_UNUSED(smc) ;
-        return(PS) ;
+        return PS;
 }
 
 /*
@@ -366,7 +366,7 @@ void sm_pm_bypass_req(struct s_smc *smc, int mode)
  */
 int sm_pm_bypass_present(struct s_smc *smc)
 {
-        return( (inp(ADDR(B0_DAS)) & DAS_BYP_ST) ? TRUE: FALSE) ;
+        return (inp(ADDR(B0_DAS)) & DAS_BYP_ST) ? TRUE : FALSE;
 }
 
 void plc_clear_irq(struct s_smc *smc, int p)
@@ -483,9 +483,9 @@ static int is_equal_num(char comp1[], char comp2[], int num)
 
         for (i = 0 ; i < num ; i++) {
                 if (comp1[i] != comp2[i])
-                        return (0) ;
+                        return 0;
         }
-                return (1) ;
+                return 1;
 }       /* is_equal_num */
 
 
@@ -522,18 +522,18 @@ int set_oi_id_def(struct s_smc *smc)
                         i++ ;
                         break ;                 /* entry ok */
                 default:
-                        return (1) ;            /* invalid oi_status */
+                        return 1;               /* invalid oi_status */
                 }
         }
 
         if (i == 0)
-                return (2) ;
+                return 2;
         if (!act_entries)
-                return (3) ;
+                return 3;
 
         /* ok, we have a valid OEM data base with an active entry */
         smc->hw.oem_id = (struct s_oem_ids *)  &oem_ids[sel_id] ;
-        return (0) ;
+        return 0;
 }
 #endif  /* MULT_OEM */
 
diff --git a/drivers/net/skfp/ess.c b/drivers/net/skfp/ess.c
index e8387d25f24a..2fc5987b41dc 100644
--- a/drivers/net/skfp/ess.c
+++ b/drivers/net/skfp/ess.c
@@ -135,7 +135,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
          */
         if (!(p = (void *) sm_to_para(smc,sm,SMT_P0015))) {
                 DB_ESS("ESS: RAF frame error, parameter type not found\n",0,0) ;
-                return(fs) ;
+                return fs;
         }
         msg_res_type = ((struct smt_p_0015 *)p)->res_type ;
 
@@ -147,7 +147,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  * error in frame: para ESS command was not found
                  */
                  DB_ESS("ESS: RAF frame error, parameter command not found\n",0,0);
-                 return(fs) ;
+                 return fs;
         }
 
         DB_ESSN(2,"fc %x        ft %x\n",sm->smt_class,sm->smt_type) ;
@@ -175,12 +175,12 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                          * local and no static allocation is used
                          */
                         if (!local || smc->mib.fddiESSPayload)
-                                return(fs) ;
+                                return fs;
                         
                         p = (void *) sm_to_para(smc,sm,SMT_P0019)  ;
                         for (i = 0; i < 5; i++) {
                                 if (((struct smt_p_0019 *)p)->alloc_addr.a[i]) {
-                                        return(fs) ;
+                                        return fs;
                                 }
                         }
 
@@ -199,10 +199,10 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                         sm->smt_dest = smt_sba_da ;
 
                         if (smc->ess.local_sba_active)
-                                return(fs | I_INDICATOR) ;
+                                return fs | I_INDICATOR;
 
                         if (!(db = smt_get_mbuf(smc)))
-                                return(fs) ;
+                                return fs;
 
                         db->sm_len = mb->sm_len ;
                         db->sm_off = mb->sm_off ;
@@ -212,7 +212,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                                 (struct smt_header *)(db->sm_data+db->sm_off),
                                 "RAF") ;
                         smt_send_frame(smc,db,FC_SMT_INFO,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 /*
@@ -221,7 +221,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 if (smt_check_para(smc,sm,plist_raf_alc_res)) {
                         DB_ESS("ESS: RAF with para problem, ignoring\n",0,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 /*
@@ -241,8 +241,8 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                         != SMT_RDF_SUCCESS) ||
                         (sm->smt_tid != smc->ess.alloc_trans_id)) {
 
-                        DB_ESS("ESS: Allocation Responce not accepted\n",0,0) ;
-                        return(fs) ;
+                        DB_ESS("ESS: Allocation Response not accepted\n",0,0) ;
+                        return fs;
                 }
 
                 /*
@@ -268,7 +268,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 (void)process_bw_alloc(smc,(long)payload,(long)overhead) ;
 
-                return(fs) ;
+                return fs;
                 /* end of Process Allocation Request */
 
         /*
@@ -280,7 +280,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 if (sm->smt_type != SMT_REQUEST) {
                         DB_ESS("ESS: Do not process Change Responses\n",0,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 /*
@@ -288,7 +288,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 if (smt_check_para(smc,sm,plist_raf_chg_req)) {
                         DB_ESS("ESS: RAF with para problem, ignoring\n",0,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 /*
@@ -300,7 +300,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                 if ((((struct smt_p_320b *)sm_to_para(smc,sm,SMT_P320B))->path_index
                         != PRIMARY_RING) || (msg_res_type != SYNC_BW)) {
                         DB_ESS("ESS: RAF frame with para problem, ignoring\n",0,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 /*
@@ -319,14 +319,14 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  * process the bandwidth allocation
                  */
                 if(!process_bw_alloc(smc,(long)payload,(long)overhead))
-                        return(fs) ;
+                        return fs;
 
                 /*
                  * send an RAF Change Reply
                  */
                 ess_send_response(smc,sm,CHANGE_ALLOCATION) ;
 
-                return(fs) ;
+                return fs;
                 /* end of Process Change Request */
 
         /*
@@ -338,7 +338,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 if (sm->smt_type != SMT_REQUEST) {
                         DB_ESS("ESS: Do not process a Report Reply\n",0,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 DB_ESSN(2,"ESS: Report Request from %s\n",
@@ -349,7 +349,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 if (msg_res_type != SYNC_BW) {
                         DB_ESS("ESS: ignoring RAF with para problem\n",0,0) ;
-                        return(fs) ;
+                        return fs;
                 }
 
                 /*
@@ -357,7 +357,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                  */
                 ess_send_response(smc,sm,REPORT_ALLOCATION) ;
 
-                return(fs) ;
+                return fs;
                 /* end of Process Report Request */
 
         default:
@@ -368,7 +368,7 @@ int ess_raf_received_pack(struct s_smc *smc, SMbuf *mb, struct smt_header *sm,
                 break ;
         }
 
-        return(fs) ;
+        return fs;
 }
 
 /*
@@ -393,7 +393,7 @@ static int process_bw_alloc(struct s_smc *smc, long int payload, long int overhe
          *                    |  T-NEG  |
          *                     -       -
          *
-         * T-NEG is discribed by the equation:
+         * T-NEG is described by the equation:
          *
          *                   (-) fddiMACT-NEG
          *      T-NEG =     -------------------
@@ -418,17 +418,17 @@ static int process_bw_alloc(struct s_smc *smc, long int payload, long int overhe
          */
 /*      if (smt_set_obj(smc,SMT_P320F,payload,S_SET)) {
                 DB_ESS("ESS: SMT does not accept the payload value\n",0,0) ;
-                return(FALSE) ;
+                return FALSE;
         }
         if (smt_set_obj(smc,SMT_P3210,overhead,S_SET)) {
                 DB_ESS("ESS: SMT does not accept the overhead value\n",0,0) ;
-                return(FALSE) ;
+                return FALSE;
         } */
 
         /* premliminary */
         if (payload > MAX_PAYLOAD || overhead > 5000) {
                 DB_ESS("ESS: payload / overhead not accepted\n",0,0) ;
-                return(FALSE) ;
+                return FALSE;
         }
 
         /*
@@ -468,7 +468,7 @@ static int process_bw_alloc(struct s_smc *smc, long int payload, long int overhe
 
         ess_config_fifo(smc) ;
         set_formac_tsync(smc,smc->ess.sync_bw) ;
-        return(TRUE) ;
+        return TRUE;
 }
 
 static void ess_send_response(struct s_smc *smc, struct smt_header *sm,
@@ -479,7 +479,7 @@ static void ess_send_response(struct s_smc *smc, struct smt_header *sm,
         void                    *p ;
 
         /*
-         * get and initialize the responce frame
+         * get and initialize the response frame
          */
         if (sba_cmd == CHANGE_ALLOCATION) {
                 if (!(mb=smt_build_frame(smc,SMT_RAF,SMT_REPLY,
@@ -578,7 +578,7 @@ static void ess_send_alc_req(struct s_smc *smc)
         }
         
         /*
-         * get and initialize the responce frame
+         * get and initialize the response frame
          */
         if (!(mb=smt_build_frame(smc,SMT_RAF,SMT_REQUEST,
                         sizeof(struct smt_sba_alc_req))))
diff --git a/drivers/net/skfp/fplustm.c b/drivers/net/skfp/fplustm.c
index 9d8d1ac48176..a20ed1a98099 100644
--- a/drivers/net/skfp/fplustm.c
+++ b/drivers/net/skfp/fplustm.c
@@ -112,8 +112,8 @@ static u_long mac_get_tneg(struct s_smc *smc)
         u_long  tneg ;
 
         tneg = (u_long)((long)inpw(FM_A(FM_TNEG))<<5) ;
-        return((u_long)((tneg + ((inpw(FM_A(FM_TMRS))>>10)&0x1f)) |
-                0xffe00000L)) ;
+        return (u_long)((tneg + ((inpw(FM_A(FM_TMRS))>>10)&0x1f)) |
+                0xffe00000L) ;
 }
 
 void mac_update_counter(struct s_smc *smc)
@@ -163,7 +163,7 @@ static u_long read_mdr(struct s_smc *smc, unsigned int addr)
                         /* is used */
         p = (u_long)inpw(FM_A(FM_MDRU))<<16 ;
         p += (u_long)inpw(FM_A(FM_MDRL)) ;
-        return(p) ;
+        return p;
 }
 #endif
 
@@ -340,7 +340,7 @@ static void mac_counter_init(struct s_smc *smc)
         outpw(FM_A(FM_LCNTR),0) ;
         outpw(FM_A(FM_ECNTR),0) ;
         /*
-         * clear internal error counter stucture
+         * clear internal error counter structure
          */
         ec = (u_long *)&smc->hw.fp.err_stats ;
         for (i = (sizeof(struct err_st)/sizeof(long)) ; i ; i--)
@@ -887,7 +887,7 @@ int init_fplus(struct s_smc *smc)
         /* make sure all PCI settings are correct */
         mac_do_pci_fix(smc) ;
 
-        return(init_mac(smc,1)) ;
+        return init_mac(smc, 1);
         /* enable_formac(smc) ; */
 }
 
@@ -989,7 +989,7 @@ static int init_mac(struct s_smc *smc, int all)
         }
         smc->hw.hw_state = STARTED ;
 
-        return(0) ;
+        return 0;
 }
 
 
@@ -1049,7 +1049,7 @@ void sm_ma_control(struct s_smc *smc, int mode)
 
 int sm_mac_get_tx_state(struct s_smc *smc)
 {
-        return((inpw(FM_A(FM_STMCHN))>>4)&7) ;
+        return (inpw(FM_A(FM_STMCHN))>>4) & 7;
 }
 
 /*
@@ -1084,9 +1084,9 @@ static struct s_fpmc* mac_get_mc_table(struct s_smc *smc,
                 }
                 if (memcmp((char *)&tb->a,(char *)own,6))
                         continue ;
-                return(tb) ;
+                return tb;
         }
-        return(slot) ;                  /* return first free or NULL */
+        return slot;                    /* return first free or NULL */
 }
 
 /*
@@ -1152,12 +1152,12 @@ int mac_add_multicast(struct s_smc *smc, struct fddi_addr *addr, int can)
          */
         if (can & 0x80) {
                 if (smc->hw.fp.smt_slots_used >= SMT_MAX_MULTI) {
-                        return(1) ;
+                        return 1;
                 }
         }
         else {
                 if (smc->hw.fp.os_slots_used >= FPMAX_MULTICAST-SMT_MAX_MULTI) {
-                        return(1) ;
+                        return 1;
                 }
         }
 
@@ -1165,7 +1165,7 @@ int mac_add_multicast(struct s_smc *smc, struct fddi_addr *addr, int can)
          * find empty slot
          */
         if (!(tb = mac_get_mc_table(smc,addr,&own,0,can & ~0x80)))
-                return(1) ;
+                return 1;
         tb->n++ ;
         tb->a = own ;
         tb->perm = (can & 0x80) ? 1 : 0 ;
@@ -1175,7 +1175,7 @@ int mac_add_multicast(struct s_smc *smc, struct fddi_addr *addr, int can)
         else
                 smc->hw.fp.os_slots_used++ ;
 
-        return(0) ;
+        return 0;
 }
 
 /*
@@ -1262,8 +1262,8 @@ Function	DOWNCALL/INTERN	(SMT, fplustm.c)
 
 Para    mode =  1       RX_ENABLE_ALLMULTI      enable all multicasts
                 2       RX_DISABLE_ALLMULTI     disable "enable all multicasts"
-                3       RX_ENABLE_PROMISC       enable promiscous
-                4       RX_DISABLE_PROMISC      disable promiscous
+                3       RX_ENABLE_PROMISC       enable promiscuous
+                4       RX_DISABLE_PROMISC      disable promiscuous
                 5       RX_ENABLE_NSA           enable reception of NSA frames
                 6       RX_DISABLE_NSA          disable reception of NSA frames
 
diff --git a/drivers/net/skfp/h/cmtdef.h b/drivers/net/skfp/h/cmtdef.h
index f2f771d8be76..5a6c6122ccb0 100644
--- a/drivers/net/skfp/h/cmtdef.h
+++ b/drivers/net/skfp/h/cmtdef.h
@@ -19,7 +19,7 @@
 
 /*
  * implementation specific constants
- * MODIIFY THE FOLLWOING THREE DEFINES
+ * MODIIFY THE FOLLOWING THREE DEFINES
  */
 #define AMDPLC                  /* if Amd PLC chip used */
 #ifdef  CONC
@@ -456,7 +456,7 @@ struct s_plc {
         u_long soft_err ;               /* error counter */
         u_long parity_err ;             /* error counter */
         u_long ebuf_err ;               /* error counter */
-        u_long ebuf_cont ;              /* continous error counter */
+        u_long ebuf_cont ;              /* continuous error counter */
         u_long phyinv ;                 /* error counter */
         u_long vsym_ctr ;               /* error counter */
         u_long mini_ctr ;               /* error counter */
diff --git a/drivers/net/skfp/h/fplustm.h b/drivers/net/skfp/h/fplustm.h
index 6d738e1e2393..d43191ed938b 100644
--- a/drivers/net/skfp/h/fplustm.h
+++ b/drivers/net/skfp/h/fplustm.h
@@ -237,8 +237,8 @@ struct s_smt_fp {
  */
 #define RX_ENABLE_ALLMULTI      1       /* enable all multicasts */
 #define RX_DISABLE_ALLMULTI     2       /* disable "enable all multicasts" */
-#define RX_ENABLE_PROMISC       3       /* enable promiscous */
-#define RX_DISABLE_PROMISC      4       /* disable promiscous */
+#define RX_ENABLE_PROMISC       3       /* enable promiscuous */
+#define RX_DISABLE_PROMISC      4       /* disable promiscuous */
 #define RX_ENABLE_NSA           5       /* enable reception of NSA frames */
 #define RX_DISABLE_NSA          6       /* disable reception of NSA frames */
 
diff --git a/drivers/net/skfp/h/smc.h b/drivers/net/skfp/h/smc.h
index 026a83b9f743..c774a95902f5 100644
--- a/drivers/net/skfp/h/smc.h
+++ b/drivers/net/skfp/h/smc.h
@@ -388,7 +388,7 @@ struct smt_config {
         u_long  rmt_t_poll ;            /* RMT : claim/beacon poller */
         u_long  rmt_dup_mac_behavior ;  /* Flag for the beavior of SMT if
                                          * a Duplicate MAC Address was detected.
-                                         * FALSE: SMT will leave finaly the ring
+                                         * FALSE: SMT will leave finally the ring
                                          * TRUE:  SMT will reinstert into the ring
                                          */
         u_long  mac_d_max ;             /* MAC : D_Max timer value */
diff --git a/drivers/net/skfp/h/smt.h b/drivers/net/skfp/h/smt.h
index 2976757a36fb..2030f9cbb24b 100644
--- a/drivers/net/skfp/h/smt.h
+++ b/drivers/net/skfp/h/smt.h
@@ -793,7 +793,7 @@ struct smt_rdf {
 } ;
 
 /*
- * SBA Request Allocation Responce Frame
+ * SBA Request Allocation Response Frame
  */
 struct smt_sba_alc_res {
         struct smt_header       smt ;           /* generic header */
diff --git a/drivers/net/skfp/h/supern_2.h b/drivers/net/skfp/h/supern_2.h
index 5ba0b8306753..0b73690280f6 100644
--- a/drivers/net/skfp/h/supern_2.h
+++ b/drivers/net/skfp/h/supern_2.h
@@ -14,7 +14,7 @@
 
 /*
         defines for AMD Supernet II chip set
-        the chips are refered to as
+        the chips are referred to as
                 FPLUS   Formac Plus
                 PLC     Physical Layer
 
@@ -386,7 +386,7 @@ struct tx_queue {
 #define FM_MDISRCV      (4<<8)          /* disable receive function */
 #define FM_MRES0        (5<<8)          /* reserve */
 #define FM_MLIMPROM     (6<<8)          /* limited-promiscuous mode */
-#define FM_MPROMISCOUS  (7<<8)          /* address detection : promiscous */
+#define FM_MPROMISCOUS  (7<<8)          /* address detection : promiscuous */
 
 #define FM_SELSA        0x0800          /* select-short-address bit */
 
diff --git a/drivers/net/skfp/hwmtm.c b/drivers/net/skfp/hwmtm.c
index d322f1b702ac..e26398b5a7dc 100644
--- a/drivers/net/skfp/hwmtm.c
+++ b/drivers/net/skfp/hwmtm.c
@@ -232,16 +232,16 @@ u_int mac_drv_check_space(void)
 #ifdef  COMMON_MB_POOL
         call_count++ ;
         if (call_count == 1) {
-                return(EXT_VIRT_MEM) ;
+                return EXT_VIRT_MEM;
         }
         else {
-                return(EXT_VIRT_MEM_2) ;
+                return EXT_VIRT_MEM_2;
         }
 #else
-        return (EXT_VIRT_MEM) ;
+        return EXT_VIRT_MEM;
 #endif
 #else
-        return (0) ;
+        return 0;
 #endif
 }
 
@@ -271,7 +271,7 @@ int mac_drv_init(struct s_smc *smc)
         if (!(smc->os.hwm.descr_p = (union s_fp_descr volatile *)
                 mac_drv_get_desc_mem(smc,(u_int)
                 (RXD_TXD_COUNT+1)*sizeof(struct s_smt_fp_txd)))) {
-                return(1) ;     /* no space the hwm modul can't work */
+                return 1;       /* no space the hwm modul can't work */
         }
 
         /*
@@ -283,18 +283,18 @@ int mac_drv_init(struct s_smc *smc)
 #ifndef COMMON_MB_POOL
         if (!(smc->os.hwm.mbuf_pool.mb_start = (SMbuf *) mac_drv_get_space(smc,
                 MAX_MBUF*sizeof(SMbuf)))) {
-                return(1) ;     /* no space the hwm modul can't work */
+                return 1;       /* no space the hwm modul can't work */
         }
 #else
         if (!mb_start) {
                 if (!(mb_start = (SMbuf *) mac_drv_get_space(smc,
                         MAX_MBUF*sizeof(SMbuf)))) {
-                        return(1) ;     /* no space the hwm modul can't work */
+                        return 1;       /* no space the hwm modul can't work */
                 }
         }
 #endif
 #endif
-        return (0) ;
+        return 0;
 }
 
 /*
@@ -349,7 +349,7 @@ static u_long init_descr_ring(struct s_smc *smc,
                 DRV_BUF_FLUSH(&d1->r,DDI_DMA_SYNC_FORDEV) ;
                 d1++;
         }
-        return(phys) ;
+        return phys;
 }
 
 static void init_txd_ring(struct s_smc *smc)
@@ -502,7 +502,7 @@ SMbuf *smt_get_mbuf(struct s_smc *smc)
                 mb->sm_use_count = 1 ;
         }
         DB_GEN("get SMbuf: mb = %x",(void *)mb,0,3) ;
-        return (mb) ;   /* May be NULL */
+        return mb;      /* May be NULL */
 }
 
 void smt_free_mbuf(struct s_smc *smc, SMbuf *mb)
@@ -621,7 +621,7 @@ static u_long repair_txd_ring(struct s_smc *smc, struct s_smt_tx_queue *queue)
                 t = t->txd_next ;
                 tx_used-- ;
         }
-        return(phys) ;
+        return phys;
 }
 
 /*
@@ -673,7 +673,7 @@ static u_long repair_rxd_ring(struct s_smc *smc, struct s_smt_rx_queue *queue)
                 r = r->rxd_next ;
                 rx_used-- ;
         }
-        return(phys) ;
+        return phys;
 }
 
 
@@ -691,7 +691,7 @@ static u_long repair_rxd_ring(struct s_smc *smc, struct s_smt_rx_queue *queue)
  *              interrupt service routine, handles the interrupt requests
  *              generated by the FDDI adapter.
  *
- * NOTE:        The operating system dependent module must garantee that the
+ * NOTE:        The operating system dependent module must guarantee that the
  *              interrupts of the adapter are disabled when it calls fddi_isr.
  *
  *      About the USE_BREAK_ISR mechanismn:
@@ -1595,7 +1595,7 @@ int hwm_tx_init(struct s_smc *smc, u_char fc, int frag_count, int frame_len,
         }
         DB_TX("frame_status = %x",frame_status,0,3) ;
         NDD_TRACE("THiE",frame_status,smc->os.hwm.tx_p->tx_free,0) ;
-        return(frame_status) ;
+        return frame_status;
 }
 
 /*
@@ -1764,7 +1764,7 @@ static SMbuf *get_llc_rx(struct s_smc *smc)
                 smc->os.hwm.llc_rx_pipe = mb->sm_next ;
         }
         DB_GEN("get_llc_rx: mb = 0x%x",(void *)mb,0,4) ;
-        return(mb) ;
+        return mb;
 }
 
 /*
@@ -1797,7 +1797,7 @@ static SMbuf *get_txd_mb(struct s_smc *smc)
                 smc->os.hwm.txd_tx_pipe = mb->sm_next ;
         }
         DB_GEN("get_txd_mb: mb = 0x%x",(void *)mb,0,4) ;
-        return(mb) ;
+        return mb;
 }
 
 /*
diff --git a/drivers/net/skfp/hwt.c b/drivers/net/skfp/hwt.c
index 053151468f93..c0798fd2ca69 100644
--- a/drivers/net/skfp/hwt.c
+++ b/drivers/net/skfp/hwt.c
@@ -179,7 +179,7 @@ u_long hwt_read(struct s_smc *smc)
                 else
                         smc->hw.t_stop = smc->hw.t_start - tr ;
         }
-        return (smc->hw.t_stop) ;
+        return smc->hw.t_stop;
 }
 
 #ifdef  PCI
@@ -208,7 +208,7 @@ u_long hwt_quick_read(struct s_smc *smc)
         outpw(ADDR(B2_TI_CRTL), TIM_START) ;
         outpd(ADDR(B2_TI_INI),interval) ;
 
-        return(time) ;
+        return time;
 }
 
 /************************
@@ -221,7 +221,7 @@ u_long hwt_quick_read(struct s_smc *smc)
  * para start           start time
  *      duration        time to wait
  *
- * NOTE: The fuction will return immediately, if the timer is not 
+ * NOTE: The function will return immediately, if the timer is not
  *       started
  ************************/
 void hwt_wait_time(struct s_smc *smc, u_long start, long int duration)
diff --git a/drivers/net/skfp/pcmplc.c b/drivers/net/skfp/pcmplc.c
index ba45bc794d77..88d02d0a42c4 100644
--- a/drivers/net/skfp/pcmplc.c
+++ b/drivers/net/skfp/pcmplc.c
@@ -504,7 +504,7 @@ int sm_pm_get_ls(struct s_smc *smc, int phy)
 
 #ifdef  CONCENTRATOR
         if (!plc_is_installed(smc,phy))
-                return(PC_QLS) ;
+                return PC_QLS;
 #endif
 
         state = inpw(PLC(phy,PL_STATUS_A)) & PL_LINE_ST ;
@@ -528,7 +528,7 @@ int sm_pm_get_ls(struct s_smc *smc, int phy)
         default :
                 state = PC_LS_NONE ;
         }
-        return(state) ;
+        return state;
 }
 
 static int plc_send_bits(struct s_smc *smc, struct s_phy *phy, int len)
@@ -547,7 +547,7 @@ static int plc_send_bits(struct s_smc *smc, struct s_phy *phy, int len)
 #if     0
                 printf("PL_PCM_SIGNAL is set\n") ;
 #endif
-                return(1) ;
+                return 1;
         }
         /* write bit[n] & length = 1 to regs */
         outpw(PLC(np,PL_VECTOR_LEN),len-1) ;    /* len=nr-1 */
@@ -562,7 +562,7 @@ static int plc_send_bits(struct s_smc *smc, struct s_phy *phy, int len)
                 printf("SIGNALING bit %d .. %d\n",phy->bitn,phy->bitn+len-1) ;
 #endif
 #endif
-        return(0) ;
+        return 0;
 }
 
 /*
@@ -1590,12 +1590,12 @@ int pcm_status_twisted(struct s_smc *smc)
 {
         int     twist = 0 ;
         if (smc->s.sas != SMT_DAS)
-                return(0) ;
+                return 0;
         if (smc->y[PA].twisted && (smc->y[PA].mib->fddiPORTPCMState == PC8_ACTIVE))
                 twist |= 1 ;
         if (smc->y[PB].twisted && (smc->y[PB].mib->fddiPORTPCMState == PC8_ACTIVE))
                 twist |= 2 ;
-        return(twist) ;
+        return twist;
 }
 
 /*
@@ -1636,9 +1636,9 @@ int pcm_rooted_station(struct s_smc *smc)
         for (n = 0 ; n < NUMPHYS ; n++) {
                 if (smc->y[n].mib->fddiPORTPCMState == PC8_ACTIVE &&
                     smc->y[n].mib->fddiPORTNeighborType == TM)
-                        return(0) ;
+                        return 0;
         }
-        return(1) ;
+        return 1;
 }
 
 /*
@@ -1680,7 +1680,7 @@ void plc_irq(struct s_smc *smc, int np, unsigned int cmd)
                          * Prevent counter from being wrapped after
                          * hanging years in that interrupt.
                          */
-                        plc->ebuf_cont++ ;      /* Ebuf continous error */
+                        plc->ebuf_cont++ ;      /* Ebuf continuous error */
                 }
 
 #ifdef  SUPERNET_3
@@ -1717,8 +1717,8 @@ void plc_irq(struct s_smc *smc, int np, unsigned int cmd)
                 }
 #endif  /* SUPERNET_3 */
         } else {
-                /* Reset the continous error variable */
-                plc->ebuf_cont = 0 ;    /* reset Ebuf continous error */
+                /* Reset the continuous error variable */
+                plc->ebuf_cont = 0 ;    /* reset Ebuf continuous error */
         }
         if (cmd & PL_PHYINV) {          /* physical layer invalid signal */
                 plc->phyinv++ ;
@@ -1915,7 +1915,7 @@ int get_pcm_state(struct s_smc *smc, int np)
                 case PL_PC9 :   pcs = PC_MAINT ;        break ;
                 default :       pcs = PC_DISABLE ;      break ;
         }
-        return(pcs) ;
+        return pcs;
 }
 
 char *get_linestate(struct s_smc *smc, int np)
@@ -1937,7 +1937,7 @@ char *get_linestate(struct s_smc *smc, int np)
                 default:        ls = "unknown" ; break ;
 #endif
         }
-        return(ls) ;
+        return ls;
 }
 
 char *get_pcmstate(struct s_smc *smc, int np)
@@ -1959,7 +1959,7 @@ char *get_pcmstate(struct s_smc *smc, int np)
                 case PL_PC9 :   pcs = "MAINT" ;         break ;
                 default :       pcs = "UNKNOWN" ;       break ;
         }
-        return(pcs) ;
+        return pcs;
 }
 
 void list_phy(struct s_smc *smc)
diff --git a/drivers/net/skfp/pmf.c b/drivers/net/skfp/pmf.c
index a320fdb3727d..9ac4665d7411 100644
--- a/drivers/net/skfp/pmf.c
+++ b/drivers/net/skfp/pmf.c
@@ -328,7 +328,7 @@ static SMbuf *smt_build_pmf_response(struct s_smc *smc, struct smt_header *req,
          * build SMT header
          */
         if (!(mb = smt_get_mbuf(smc)))
-                return(mb) ;
+                return mb;
 
         smt = smtod(mb, struct smt_header *) ;
         smt->smt_dest = req->smt_source ;       /* DA == source of request */
@@ -493,7 +493,7 @@ static SMbuf *smt_build_pmf_response(struct s_smc *smc, struct smt_header *req,
                 smt_add_para(smc,&set_pcon,(u_short) SMT_P1035,0,0) ;
                 smt_add_para(smc,&set_pcon,(u_short) SMT_P1036,0,0) ;
         }
-        return(mb) ;
+        return mb;
 }
 
 static int smt_authorize(struct s_smc *smc, struct smt_header *sm)
@@ -511,7 +511,7 @@ static int smt_authorize(struct s_smc *smc, struct smt_header *sm)
         if (i != 8) {
                 if (memcmp((char *) &sm->smt_sid,
                         (char *) &smc->mib.fddiPRPMFStation,8))
-                        return(1) ;
+                        return 1;
         }
         /*
          * check authoriziation parameter if passwd not zero
@@ -522,13 +522,13 @@ static int smt_authorize(struct s_smc *smc, struct smt_header *sm)
         if (i != 8) {
                 pa = (struct smt_para *) sm_to_para(smc,sm,SMT_P_AUTHOR) ;
                 if (!pa)
-                        return(1) ;
+                        return 1;
                 if (pa->p_len != 8)
-                        return(1) ;
+                        return 1;
                 if (memcmp((char *)(pa+1),(char *)smc->mib.fddiPRPMFPasswd,8))
-                        return(1) ;
+                        return 1;
         }
-        return(0) ;
+        return 0;
 }
 
 static int smt_check_set_count(struct s_smc *smc, struct smt_header *sm)
@@ -542,9 +542,9 @@ static int smt_check_set_count(struct s_smc *smc, struct smt_header *sm)
                 if ((smc->mib.fddiSMTSetCount.count != sc->count) ||
                         memcmp((char *) smc->mib.fddiSMTSetCount.timestamp,
                         (char *)sc->timestamp,8))
-                        return(1) ;
+                        return 1;
         }
-        return(0) ;
+        return 0;
 }
 
 void smt_add_para(struct s_smc *smc, struct s_pcon *pcon, u_short para,
@@ -1109,7 +1109,7 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
                 break ;
         case 0x2000 :
                 if (mac < 0 || mac >= NUMMACS) {
-                        return(SMT_RDF_NOPARAM) ;
+                        return SMT_RDF_NOPARAM;
                 }
                 mib_m = &smc->mib.m[mac] ;
                 mib_addr = (char *) mib_m ;
@@ -1118,7 +1118,7 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
                 break ;
         case 0x3000 :
                 if (path < 0 || path >= NUMPATHS) {
-                        return(SMT_RDF_NOPARAM) ;
+                        return SMT_RDF_NOPARAM;
                 }
                 mib_a = &smc->mib.a[path] ;
                 mib_addr = (char *) mib_a ;
@@ -1127,7 +1127,7 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
                 break ;
         case 0x4000 :
                 if (port < 0 || port >= smt_mib_phys(smc)) {
-                        return(SMT_RDF_NOPARAM) ;
+                        return SMT_RDF_NOPARAM;
                 }
                 mib_p = &smc->mib.p[port_to_mib(smc,port)] ;
                 mib_addr = (char *) mib_p ;
@@ -1151,22 +1151,20 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
         case SMT_P10F9 :
 #endif
         case SMT_P20F1 :
-                if (!local) {
-                        return(SMT_RDF_NOPARAM) ;
-                }
+                if (!local)
+                        return SMT_RDF_NOPARAM;
                 break ;
         }
         pt = smt_get_ptab(pa->p_type) ;
-        if (!pt) {
-                return( (pa->p_type & 0xff00) ? SMT_RDF_NOPARAM :
-                                                SMT_RDF_ILLEGAL ) ;
-        }
+        if (!pt)
+                return (pa->p_type & 0xff00) ? SMT_RDF_NOPARAM :
+                                               SMT_RDF_ILLEGAL;
         switch (pt->p_access) {
         case AC_GR :
         case AC_S :
                 break ;
         default :
-                return(SMT_RDF_ILLEGAL) ;
+                return SMT_RDF_ILLEGAL;
         }
         to = mib_addr + pt->p_offset ;
         swap = pt->p_swap ;             /* pointer to swap string */
@@ -1292,7 +1290,7 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
                         break ;
                 default :
                         SMT_PANIC(smc,SMT_E0120, SMT_E0120_MSG) ;
-                        return(SMT_RDF_ILLEGAL) ;
+                        return SMT_RDF_ILLEGAL;
                 }
         }
         /*
@@ -1501,15 +1499,15 @@ change_mac_para:
         default :
                 break ;
         }
-        return(0) ;
+        return 0;
 
 val_error:
         /* parameter value in frame is out of range */
-        return(SMT_RDF_RANGE) ;
+        return SMT_RDF_RANGE;
 
 len_error:
         /* parameter value in frame is too short */
-        return(SMT_RDF_LENGTH) ;
+        return SMT_RDF_LENGTH;
 
 #if     0
 no_author_error:
@@ -1518,7 +1516,7 @@ no_author_error:
          *  because SBA denied is not a valid return code in the
          * PMF protocol.
          */
-        return(SMT_RDF_AUTHOR) ;
+        return SMT_RDF_AUTHOR;
 #endif
 }
 
@@ -1527,7 +1525,7 @@ static const struct s_p_tab *smt_get_ptab(u_short para)
         const struct s_p_tab    *pt ;
         for (pt = p_tab ; pt->p_num && pt->p_num != para ; pt++)
                 ;
-        return(pt->p_num ? pt : NULL) ;
+        return pt->p_num ? pt : NULL;
 }
 
 static int smt_mib_phys(struct s_smc *smc)
@@ -1535,11 +1533,11 @@ static int smt_mib_phys(struct s_smc *smc)
 #ifdef  CONCENTRATOR
         SK_UNUSED(smc) ;
 
-        return(NUMPHYS) ;
+        return NUMPHYS;
 #else
         if (smc->s.sas == SMT_SAS)
-                return(1) ;
-        return(NUMPHYS) ;
+                return 1;
+        return NUMPHYS;
 #endif
 }
 
@@ -1548,11 +1546,11 @@ static int port_to_mib(struct s_smc *smc, int p)
 #ifdef  CONCENTRATOR
         SK_UNUSED(smc) ;
 
-        return(p) ;
+        return p;
 #else
         if (smc->s.sas == SMT_SAS)
-                return(PS) ;
-        return(p) ;
+                return PS;
+        return p;
 #endif
 }
 
diff --git a/drivers/net/skfp/queue.c b/drivers/net/skfp/queue.c
index 09adb3d68b7c..c1a0df455a59 100644
--- a/drivers/net/skfp/queue.c
+++ b/drivers/net/skfp/queue.c
@@ -128,7 +128,7 @@ u_short smt_online(struct s_smc *smc, int on)
 {
         queue_event(smc,EVENT_ECM,on ? EC_CONNECT : EC_DISCONNECT) ;
         ev_dispatcher(smc) ;
-        return(smc->mib.fddiSMTCF_State) ;
+        return smc->mib.fddiSMTCF_State;
 }
 
 /*
diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c
index 31b2dabf094c..16c62659cdd9 100644
--- a/drivers/net/skfp/skfddi.c
+++ b/drivers/net/skfp/skfddi.c
@@ -33,7 +33,7 @@
  *   The driver architecture is based on the DEC FDDI driver by
  *   Lawrence V. Stefani and several ethernet drivers.
  *   I also used an existing Windows NT miniport driver.
- *   All hardware dependent fuctions are handled by the SysKonnect
+ *   All hardware dependent functions are handled by the SysKonnect
  *   Hardware Module.
  *   The only headerfiles that are directly related to this source
  *   are skfddi.c, h/types.h, h/osdef1st.h, h/targetos.h.
@@ -209,7 +209,7 @@ static int skfp_init_one(struct pci_dev *pdev,
         void __iomem *mem;
         int err;
 
-        pr_debug(KERN_INFO "entering skfp_init_one\n");
+        pr_debug("entering skfp_init_one\n");
 
         if (num_boards == 0) 
                 printk("%s\n", boot_msg);
@@ -385,7 +385,7 @@ static  int skfp_driver_init(struct net_device *dev)
         skfddi_priv *bp = &smc->os;
         int err = -EIO;
 
-        pr_debug(KERN_INFO "entering skfp_driver_init\n");
+        pr_debug("entering skfp_driver_init\n");
 
         // set the io address in private structures
         bp->base_addr = dev->base_addr;
@@ -405,14 +405,14 @@ static  int skfp_driver_init(struct net_device *dev)
 
         // Determine the required size of the 'shared' memory area.
         bp->SharedMemSize = mac_drv_check_space();
-        pr_debug(KERN_INFO "Memory for HWM: %ld\n", bp->SharedMemSize);
+        pr_debug("Memory for HWM: %ld\n", bp->SharedMemSize);
         if (bp->SharedMemSize > 0) {
                 bp->SharedMemSize += 16;        // for descriptor alignment
 
                 bp->SharedMemAddr = pci_alloc_consistent(&bp->pdev,
                                                          bp->SharedMemSize,
                                                          &bp->SharedMemDMA);
-                if (!bp->SharedMemSize) {
+                if (!bp->SharedMemAddr) {
                         printk("could not allocate mem for ");
                         printk("hardware module: %ld byte\n",
                                bp->SharedMemSize);
@@ -429,18 +429,18 @@ static  int skfp_driver_init(struct net_device *dev)
 
         card_stop(smc);         // Reset adapter.
 
-        pr_debug(KERN_INFO "mac_drv_init()..\n");
+        pr_debug("mac_drv_init()..\n");
         if (mac_drv_init(smc) != 0) {
-                pr_debug(KERN_INFO "mac_drv_init() failed.\n");
+                pr_debug("mac_drv_init() failed\n");
                 goto fail;
         }
         read_address(smc, NULL);
-        pr_debug(KERN_INFO "HW-Addr: %pMF\n", smc->hw.fddi_canon_addr.a);
+        pr_debug("HW-Addr: %pMF\n", smc->hw.fddi_canon_addr.a);
         memcpy(dev->dev_addr, smc->hw.fddi_canon_addr.a, 6);
 
         smt_reset_defaults(smc, 0);
 
-        return (0);
+        return 0;
 
 fail:
         if (bp->SharedMemAddr) {
@@ -485,7 +485,7 @@ static int skfp_open(struct net_device *dev)
         struct s_smc *smc = netdev_priv(dev);
         int err;
 
-        pr_debug(KERN_INFO "entering skfp_open\n");
+        pr_debug("entering skfp_open\n");
         /* Register IRQ - support shared interrupts by passing device ptr */
         err = request_irq(dev->irq, skfp_interrupt, IRQF_SHARED,
                           dev->name, dev);
@@ -516,7 +516,7 @@ static int skfp_open(struct net_device *dev)
         mac_drv_rx_mode(smc, RX_DISABLE_PROMISC);
 
         netif_start_queue(dev);
-        return (0);
+        return 0;
 }                               // skfp_open
 
 
@@ -565,7 +565,7 @@ static int skfp_close(struct net_device *dev)
         skb_queue_purge(&bp->SendSkbQueue);
         bp->QueueSkb = MAX_TX_QUEUE_LEN;
 
-        return (0);
+        return 0;
 }                               // skfp_close
 
 
@@ -794,7 +794,7 @@ static struct net_device_stats *skfp_ctl_get_stats(struct net_device *dev)
         bp->stats.port_lem_cts[1] = bp->cmd_rsp_virt->cntrs_get.cntrs.link_errors[1].ls;
 
 #endif
-        return ((struct net_device_stats *) &bp->os.MacStat);
+        return (struct net_device_stats *)&bp->os.MacStat;
 }                               // ctl_get_stat
 
 
@@ -856,12 +856,12 @@ static void skfp_ctl_set_multicast_list_wo_lock(struct net_device *dev)
         /* Enable promiscuous mode, if necessary */
         if (dev->flags & IFF_PROMISC) {
                 mac_drv_rx_mode(smc, RX_ENABLE_PROMISC);
-                pr_debug(KERN_INFO "PROMISCUOUS MODE ENABLED\n");
+                pr_debug("PROMISCUOUS MODE ENABLED\n");
         }
         /* Else, update multicast address table */
         else {
                 mac_drv_rx_mode(smc, RX_DISABLE_PROMISC);
-                pr_debug(KERN_INFO "PROMISCUOUS MODE DISABLED\n");
+                pr_debug("PROMISCUOUS MODE DISABLED\n");
 
                 // Reset all MC addresses
                 mac_clear_multicast(smc);
@@ -869,7 +869,7 @@ static void skfp_ctl_set_multicast_list_wo_lock(struct net_device *dev)
 
                 if (dev->flags & IFF_ALLMULTI) {
                         mac_drv_rx_mode(smc, RX_ENABLE_ALLMULTI);
-                        pr_debug(KERN_INFO "ENABLE ALL MC ADDRESSES\n");
+                        pr_debug("ENABLE ALL MC ADDRESSES\n");
                 } else if (!netdev_mc_empty(dev)) {
                         if (netdev_mc_count(dev) <= FPMAX_MULTICAST) {
                                 /* use exact filtering */
@@ -880,18 +880,18 @@ static void skfp_ctl_set_multicast_list_wo_lock(struct net_device *dev)
                                                 (struct fddi_addr *)ha->addr,
                                                 1);
 
-                                        pr_debug(KERN_INFO "ENABLE MC ADDRESS: %pMF\n",
-                                                ha->addr);
+                                        pr_debug("ENABLE MC ADDRESS: %pMF\n",
+                                                 ha->addr);
                                 }
 
                         } else {        // more MC addresses than HW supports
 
                                 mac_drv_rx_mode(smc, RX_ENABLE_ALLMULTI);
-                                pr_debug(KERN_INFO "ENABLE ALL MC ADDRESSES\n");
+                                pr_debug("ENABLE ALL MC ADDRESSES\n");
                         }
                 } else {        // no MC addresses
 
-                        pr_debug(KERN_INFO "DISABLE ALL MC ADDRESSES\n");
+                        pr_debug("DISABLE ALL MC ADDRESSES\n");
                 }
 
                 /* Update adapter filters */
@@ -932,7 +932,7 @@ static int skfp_ctl_set_mac_address(struct net_device *dev, void *addr)
         ResetAdapter(smc);
         spin_unlock_irqrestore(&bp->DriverLock, Flags);
 
-        return (0);             /* always return zero */
+        return 0;               /* always return zero */
 }                               // skfp_ctl_set_mac_address
 
 
@@ -1045,7 +1045,7 @@ static netdev_tx_t skfp_send_pkt(struct sk_buff *skb,
         struct s_smc *smc = netdev_priv(dev);
         skfddi_priv *bp = &smc->os;
 
-        pr_debug(KERN_INFO "skfp_send_pkt\n");
+        pr_debug("skfp_send_pkt\n");
 
         /*
          * Verify that incoming transmit request is OK
@@ -1114,13 +1114,13 @@ static void send_queued_packets(struct s_smc *smc)
 
         int frame_status;       // HWM tx frame status.
 
-        pr_debug(KERN_INFO "send queued packets\n");
+        pr_debug("send queued packets\n");
         for (;;) {
                 // send first buffer from queue
                 skb = skb_dequeue(&bp->SendSkbQueue);
 
                 if (!skb) {
-                        pr_debug(KERN_INFO "queue empty\n");
+                        pr_debug("queue empty\n");
                         return;
                 }               // queue empty !
 
@@ -1232,7 +1232,7 @@ static void CheckSourceAddress(unsigned char *frame, unsigned char *hw_addr)
 static void ResetAdapter(struct s_smc *smc)
 {
 
-        pr_debug(KERN_INFO "[fddi: ResetAdapter]\n");
+        pr_debug("[fddi: ResetAdapter]\n");
 
         // Stop the adapter.
 
@@ -1278,7 +1278,7 @@ void llc_restart_tx(struct s_smc *smc)
 {
         skfddi_priv *bp = &smc->os;
 
-        pr_debug(KERN_INFO "[llc_restart_tx]\n");
+        pr_debug("[llc_restart_tx]\n");
 
         // Try to send queued packets
         spin_unlock(&bp->DriverLock);
@@ -1308,21 +1308,21 @@ void *mac_drv_get_space(struct s_smc *smc, unsigned int size)
 {
         void *virt;
 
-        pr_debug(KERN_INFO "mac_drv_get_space (%d bytes), ", size);
+        pr_debug("mac_drv_get_space (%d bytes), ", size);
         virt = (void *) (smc->os.SharedMemAddr + smc->os.SharedMemHeap);
 
         if ((smc->os.SharedMemHeap + size) > smc->os.SharedMemSize) {
                 printk("Unexpected SMT memory size requested: %d\n", size);
-                return (NULL);
+                return NULL;
         }
         smc->os.SharedMemHeap += size;  // Move heap pointer.
 
-        pr_debug(KERN_INFO "mac_drv_get_space end\n");
-        pr_debug(KERN_INFO "virt addr: %lx\n", (ulong) virt);
-        pr_debug(KERN_INFO "bus  addr: %lx\n", (ulong)
+        pr_debug("mac_drv_get_space end\n");
+        pr_debug("virt addr: %lx\n", (ulong) virt);
+        pr_debug("bus  addr: %lx\n", (ulong)
                (smc->os.SharedMemDMA +
                 ((char *) virt - (char *)smc->os.SharedMemAddr)));
-        return (virt);
+        return virt;
 }                               // mac_drv_get_space
 
 
@@ -1349,7 +1349,7 @@ void *mac_drv_get_desc_mem(struct s_smc *smc, unsigned int size)
 
         char *virt;
 
-        pr_debug(KERN_INFO "mac_drv_get_desc_mem\n");
+        pr_debug("mac_drv_get_desc_mem\n");
 
         // Descriptor memory must be aligned on 16-byte boundary.
 
@@ -1363,9 +1363,9 @@ void *mac_drv_get_desc_mem(struct s_smc *smc, unsigned int size)
 
         if (!mac_drv_get_space(smc, size)) {
                 printk("fddi: Unable to align descriptor memory.\n");
-                return (NULL);
+                return NULL;
         }
-        return (virt + size);
+        return virt + size;
 }                               // mac_drv_get_desc_mem
 
 
@@ -1384,8 +1384,8 @@ void *mac_drv_get_desc_mem(struct s_smc *smc, unsigned int size)
  ************************/
 unsigned long mac_drv_virt2phys(struct s_smc *smc, void *virt)
 {
-        return (smc->os.SharedMemDMA +
-                ((char *) virt - (char *)smc->os.SharedMemAddr));
+        return smc->os.SharedMemDMA +
+                ((char *) virt - (char *)smc->os.SharedMemAddr);
 }                               // mac_drv_virt2phys
 
 
@@ -1419,8 +1419,8 @@ unsigned long mac_drv_virt2phys(struct s_smc *smc, void *virt)
  ************************/
 u_long dma_master(struct s_smc * smc, void *virt, int len, int flag)
 {
-        return (smc->os.SharedMemDMA +
-                ((char *) virt - (char *)smc->os.SharedMemAddr));
+        return smc->os.SharedMemDMA +
+                ((char *) virt - (char *)smc->os.SharedMemAddr);
 }                               // dma_master
 
 
@@ -1493,7 +1493,7 @@ void mac_drv_tx_complete(struct s_smc *smc, volatile struct s_smt_fp_txd *txd)
 {
         struct sk_buff *skb;
 
-        pr_debug(KERN_INFO "entering mac_drv_tx_complete\n");
+        pr_debug("entering mac_drv_tx_complete\n");
         // Check if this TxD points to a skb
 
         if (!(skb = txd->txd_os.skb)) {
@@ -1513,7 +1513,7 @@ void mac_drv_tx_complete(struct s_smc *smc, volatile struct s_smt_fp_txd *txd)
         // free the skb
         dev_kfree_skb_irq(skb);
 
-        pr_debug(KERN_INFO "leaving mac_drv_tx_complete\n");
+        pr_debug("leaving mac_drv_tx_complete\n");
 }                               // mac_drv_tx_complete
 
 
@@ -1580,7 +1580,7 @@ void mac_drv_rx_complete(struct s_smc *smc, volatile struct s_smt_fp_rxd *rxd,
         unsigned short ri;
         u_int RifLength;
 
-        pr_debug(KERN_INFO "entering mac_drv_rx_complete (len=%d)\n", len);
+        pr_debug("entering mac_drv_rx_complete (len=%d)\n", len);
         if (frag_count != 1) {  // This is not allowed to happen.
 
                 printk("fddi: Multi-fragment receive!\n");
@@ -1589,7 +1589,7 @@ void mac_drv_rx_complete(struct s_smc *smc, volatile struct s_smt_fp_rxd *rxd,
         }
         skb = rxd->rxd_os.skb;
         if (!skb) {
-                pr_debug(KERN_INFO "No skb in rxd\n");
+                pr_debug("No skb in rxd\n");
                 smc->os.MacStat.gen.rx_errors++;
                 goto RequeueRxd;
         }
@@ -1619,7 +1619,7 @@ void mac_drv_rx_complete(struct s_smc *smc, volatile struct s_smt_fp_rxd *rxd,
         else {
                 int n;
 // goos: RIF removal has still to be tested
-                pr_debug(KERN_INFO "RIF found\n");
+                pr_debug("RIF found\n");
                 // Get RIF length from Routing Control (RC) field.
                 cp = virt + FDDI_MAC_HDR_LEN;   // Point behind MAC header.
 
@@ -1664,7 +1664,7 @@ void mac_drv_rx_complete(struct s_smc *smc, volatile struct s_smt_fp_rxd *rxd,
         return;
 
       RequeueRxd:
-        pr_debug(KERN_INFO "Rx: re-queue RXD.\n");
+        pr_debug("Rx: re-queue RXD.\n");
         mac_drv_requeue_rxd(smc, rxd, frag_count);
         smc->os.MacStat.gen.rx_errors++;        // Count receive packets
                                                 // not indicated.
@@ -1775,7 +1775,7 @@ void mac_drv_fill_rxd(struct s_smc *smc)
         struct sk_buff *skb;
         volatile struct s_smt_fp_rxd *rxd;
 
-        pr_debug(KERN_INFO "entering mac_drv_fill_rxd\n");
+        pr_debug("entering mac_drv_fill_rxd\n");
 
         // Walk through the list of free receive buffers, passing receive
         // buffers to the HWM as long as RXDs are available.
@@ -1783,7 +1783,7 @@ void mac_drv_fill_rxd(struct s_smc *smc)
         MaxFrameSize = smc->os.MaxFrameSize;
         // Check if there is any RXD left.
         while (HWM_GET_RX_FREE(smc) > 0) {
-                pr_debug(KERN_INFO ".\n");
+                pr_debug(".\n");
 
                 rxd = HWM_GET_CURR_RXD(smc);
                 skb = alloc_skb(MaxFrameSize + 3, GFP_ATOMIC);
@@ -1814,7 +1814,7 @@ void mac_drv_fill_rxd(struct s_smc *smc)
                 hwm_rx_frag(smc, v_addr, b_addr, MaxFrameSize,
                             FIRST_FRAG | LAST_FRAG);
         }
-        pr_debug(KERN_INFO "leaving mac_drv_fill_rxd\n");
+        pr_debug("leaving mac_drv_fill_rxd\n");
 }                               // mac_drv_fill_rxd
 
 
@@ -1904,12 +1904,12 @@ int mac_drv_rx_init(struct s_smc *smc, int len, int fc,
                 pr_debug("fddi: Discard invalid local SMT frame\n");
                 pr_debug("  len=%d, la_len=%d, (ULONG) look_ahead=%08lXh.\n",
                        len, la_len, (unsigned long) look_ahead);
-                return (0);
+                return 0;
         }
         skb = alloc_skb(len + 3, GFP_ATOMIC);
         if (!skb) {
                 pr_debug("fddi: Local SMT: skb memory exhausted.\n");
-                return (0);
+                return 0;
         }
         skb_reserve(skb, 3);
         skb_put(skb, len);
@@ -1919,7 +1919,7 @@ int mac_drv_rx_init(struct s_smc *smc, int len, int fc,
         skb->protocol = fddi_type_trans(skb, smc->os.dev);
         netif_rx(skb);
 
-        return (0);
+        return 0;
 }                               // mac_drv_rx_init
 
 
@@ -2034,17 +2034,17 @@ void smt_stat_counter(struct s_smc *smc, int stat)
 {
 //      BOOLEAN RingIsUp ;
 
-        pr_debug(KERN_INFO "smt_stat_counter\n");
+        pr_debug("smt_stat_counter\n");
         switch (stat) {
         case 0:
-                pr_debug(KERN_INFO "Ring operational change.\n");
+                pr_debug("Ring operational change.\n");
                 break;
         case 1:
-                pr_debug(KERN_INFO "Receive fifo overflow.\n");
+                pr_debug("Receive fifo overflow.\n");
                 smc->os.MacStat.gen.rx_errors++;
                 break;
         default:
-                pr_debug(KERN_INFO "Unknown status (%d).\n", stat);
+                pr_debug("Unknown status (%d).\n", stat);
                 break;
         }
 }                               // smt_stat_counter
@@ -2100,10 +2100,10 @@ void cfm_state_change(struct s_smc *smc, int c_state)
                 s = "SC11_C_WRAP_S";
                 break;
         default:
-                pr_debug(KERN_INFO "cfm_state_change: unknown %d\n", c_state);
+                pr_debug("cfm_state_change: unknown %d\n", c_state);
                 return;
         }
-        pr_debug(KERN_INFO "cfm_state_change: %s\n", s);
+        pr_debug("cfm_state_change: %s\n", s);
 #endif                          // DRIVERDEBUG
 }                               // cfm_state_change
 
@@ -2158,7 +2158,7 @@ void ecm_state_change(struct s_smc *smc, int e_state)
                 s = "unknown";
                 break;
         }
-        pr_debug(KERN_INFO "ecm_state_change: %s\n", s);
+        pr_debug("ecm_state_change: %s\n", s);
 #endif                          //DRIVERDEBUG
 }                               // ecm_state_change
 
@@ -2213,7 +2213,7 @@ void rmt_state_change(struct s_smc *smc, int r_state)
                 s = "unknown";
                 break;
         }
-        pr_debug(KERN_INFO "[rmt_state_change: %s]\n", s);
+        pr_debug("[rmt_state_change: %s]\n", s);
 #endif                          // DRIVERDEBUG
 }                               // rmt_state_change
 
@@ -2233,7 +2233,7 @@ void rmt_state_change(struct s_smc *smc, int r_state)
  ************************/
 void drv_reset_indication(struct s_smc *smc)
 {
-        pr_debug(KERN_INFO "entering drv_reset_indication\n");
+        pr_debug("entering drv_reset_indication\n");
 
         smc->os.ResetRequested = TRUE;  // Set flag.
 
diff --git a/drivers/net/skfp/smt.c b/drivers/net/skfp/smt.c
index 6f35bb77595f..08d94329c12f 100644
--- a/drivers/net/skfp/smt.c
+++ b/drivers/net/skfp/smt.c
@@ -127,22 +127,22 @@ static inline int is_my_addr(const struct s_smc *smc,
 
 static inline int is_broadcast(const struct fddi_addr *addr)
 {
-        return(*(u_short *)(&addr->a[0]) == 0xffff &&
+        return *(u_short *)(&addr->a[0]) == 0xffff &&
                *(u_short *)(&addr->a[2]) == 0xffff &&
-               *(u_short *)(&addr->a[4]) == 0xffff ) ;
+               *(u_short *)(&addr->a[4]) == 0xffff;
 }
 
 static inline int is_individual(const struct fddi_addr *addr)
 {
-        return(!(addr->a[0] & GROUP_ADDR)) ;
+        return !(addr->a[0] & GROUP_ADDR);
 }
 
 static inline int is_equal(const struct fddi_addr *addr1, 
                            const struct fddi_addr *addr2)
 {
-        return(*(u_short *)(&addr1->a[0]) == *(u_short *)(&addr2->a[0]) &&
+        return *(u_short *)(&addr1->a[0]) == *(u_short *)(&addr2->a[0]) &&
                *(u_short *)(&addr1->a[2]) == *(u_short *)(&addr2->a[2]) &&
-               *(u_short *)(&addr1->a[4]) == *(u_short *)(&addr2->a[4]) ) ;
+               *(u_short *)(&addr1->a[4]) == *(u_short *)(&addr2->a[4]);
 }
 
 /*
@@ -219,7 +219,7 @@ void smt_emulate_token_ct(struct s_smc *smc, int mac_index)
 
         /*
          * Only when ring is up we will have a token count. The
-         * flag is unfortunatly a single instance value. This
+         * flag is unfortunately a single instance value. This
          * doesn't matter now, because we currently have only
          * one MAC instance.
          */
@@ -457,8 +457,8 @@ static int div_ratio(u_long upper, u_long lower)
         else
                 upper <<= 16L ;
         if (!lower)
-                return(0) ;
-        return((int)(upper/lower)) ;
+                return 0;
+        return (int)(upper/lower) ;
 }
 
 #ifndef SLIM_SMT
@@ -1111,11 +1111,11 @@ SMbuf *smt_build_frame(struct s_smc *smc, int class, int type,
 
 #if     0
         if (!smc->r.sm_ma_avail) {
-                return(0) ;
+                return 0;
         }
 #endif
         if (!(mb = smt_get_mbuf(smc)))
-                return(mb) ;
+                return mb;
 
         mb->sm_len = length ;
         smt = smtod(mb, struct smt_header *) ;
@@ -1136,7 +1136,7 @@ SMbuf *smt_build_frame(struct s_smc *smc, int class, int type,
         smt->smt_tid = smt_get_tid(smc) ;       /* set transaction ID */
         smt->smt_pad = 0 ;
         smt->smt_len = length - sizeof(struct smt_header) ;
-        return(mb) ;
+        return mb;
 }
 
 static void smt_add_frame_len(SMbuf *mb, int len)
@@ -1263,7 +1263,7 @@ void smt_set_timestamp(struct s_smc *smc, u_char *p)
 static void smt_fill_policy(struct s_smc *smc, struct smt_p_policy *policy)
 {
         int     i ;
-        u_char  *map ;
+        const u_char *map ;
         u_short in ;
         u_short out ;
 
@@ -1271,7 +1271,7 @@ static void smt_fill_policy(struct s_smc *smc, struct smt_p_policy *policy)
          * MIB para 101b (fddiSMTConnectionPolicy) coding
          * is different from 0005 coding
          */
-        static u_char   ansi_weirdness[16] = {
+        static const u_char ansi_weirdness[16] = {
                 0,7,5,3,8,1,6,4,9,10,2,11,12,13,14,15
         } ;
         SMTSETPARA(policy,SMT_P_POLICY) ;
@@ -1375,7 +1375,7 @@ static int smt_fill_path(struct s_smc *smc, struct smt_p_path *path)
         pd_mac = (struct smt_mac_rec *) phy ;
         pd_mac->mac_addr = smc->mib.m[MAC0].fddiMACSMTAddress ;
         pd_mac->mac_resource_idx = mac_con_resource_index(smc,1) ;
-        return(len) ;
+        return len;
 }
 
 /*
@@ -1563,7 +1563,7 @@ u_long smt_get_tid(struct s_smc *smc)
         u_long  tid ;
         while ((tid = ++(smc->sm.smt_tid) ^ SMT_TID_MAGIC) == 0)
                 ;
-        return(tid & 0x3fffffffL) ;
+        return tid & 0x3fffffffL;
 }
 
 
@@ -1654,11 +1654,11 @@ int smt_check_para(struct s_smc *smc, struct smt_header	*sm,
         while (*p) {
                 if (!sm_to_para(smc,sm,(int) *p)) {
                         DB_SMT("SMT: smt_check_para - missing para %x\n",*p,0);
-                        return(-1) ;
+                        return -1;
                 }
                 p++ ;
         }
-        return(0) ;
+        return 0;
 }
 
 void *sm_to_para(struct s_smc *smc, struct smt_header *sm, int para)
@@ -1687,7 +1687,7 @@ void *sm_to_para(struct s_smc *smc, struct smt_header *sm, int para)
                         return NULL;
                 }
                 if (found)
-                        return(found) ;
+                        return found;
         }
         return NULL;
 }
@@ -1732,7 +1732,7 @@ char *addr_to_string(struct fddi_addr *addr)
                 string[i * 3 + 2] = ':';
         }
         string[5 * 3 + 2] = 0;
-        return(string);
+        return string;
 }
 #endif
 
@@ -1742,9 +1742,9 @@ int smt_ifconfig(int argc, char *argv[])
         if (argc >= 2 && !strcmp(argv[0],"opt_bypass") &&
             !strcmp(argv[1],"yes")) {
                 smc->mib.fddiSMTBypassPresent = 1 ;
-                return(0) ;
+                return 0;
         }
-        return(amdfddi_config(0,argc,argv)) ;
+        return amdfddi_config(0, argc, argv);
 }
 #endif
 
@@ -1756,9 +1756,9 @@ static int mac_index(struct s_smc *smc, int mac)
         SK_UNUSED(mac) ;
 #ifdef  CONCENTRATOR
         SK_UNUSED(smc) ;
-        return(NUMPHYS+1) ;
+        return NUMPHYS + 1;
 #else
-        return((smc->s.sas == SMT_SAS) ? 2 : 3) ;
+        return (smc->s.sas == SMT_SAS) ? 2 : 3;
 #endif
 }
 
@@ -1768,7 +1768,7 @@ static int mac_index(struct s_smc *smc, int mac)
 static int phy_index(struct s_smc *smc, int phy)
 {
         SK_UNUSED(smc) ;
-        return(phy+1);
+        return phy + 1;
 }
 
 /*
@@ -1779,19 +1779,19 @@ static int mac_con_resource_index(struct s_smc *smc, int mac)
 #ifdef  CONCENTRATOR
         SK_UNUSED(smc) ;
         SK_UNUSED(mac) ;
-        return(entity_to_index(smc,cem_get_downstream(smc,ENTITY_MAC))) ;
+        return entity_to_index(smc, cem_get_downstream(smc, ENTITY_MAC));
 #else
         SK_UNUSED(mac) ;
         switch (smc->mib.fddiSMTCF_State) {
         case SC9_C_WRAP_A :
         case SC5_THRU_B :
         case SC11_C_WRAP_S :
-                return(1) ;
+                return 1;
         case SC10_C_WRAP_B :
         case SC4_THRU_A :
-                return(2) ;
+                return 2;
         }
-        return(smc->s.sas == SMT_SAS ? 2 : 3) ;
+        return smc->s.sas == SMT_SAS ? 2 : 3;
 #endif
 }
 
@@ -1801,21 +1801,21 @@ static int mac_con_resource_index(struct s_smc *smc, int mac)
 static int phy_con_resource_index(struct s_smc *smc, int phy)
 {
 #ifdef  CONCENTRATOR
-        return(entity_to_index(smc,cem_get_downstream(smc,ENTITY_PHY(phy)))) ;
+        return entity_to_index(smc, cem_get_downstream(smc, ENTITY_PHY(phy))) ;
 #else
         switch (smc->mib.fddiSMTCF_State) {
         case SC9_C_WRAP_A :
-                return(phy == PA ? 3 : 2) ;
+                return phy == PA ? 3 : 2;
         case SC10_C_WRAP_B :
-                return(phy == PA ? 1 : 3) ;
+                return phy == PA ? 1 : 3;
         case SC4_THRU_A :
-                return(phy == PA ? 3 : 1) ;
+                return phy == PA ? 3 : 1;
         case SC5_THRU_B :
-                return(phy == PA ? 2 : 3) ;
+                return phy == PA ? 2 : 3;
         case SC11_C_WRAP_S :
-                return(2) ;
+                return 2;
         }
-        return(phy) ;
+        return phy;
 #endif
 }
 
@@ -1823,16 +1823,16 @@ static int phy_con_resource_index(struct s_smc *smc, int phy)
 static int entity_to_index(struct s_smc *smc, int e)
 {
         if (e == ENTITY_MAC)
-                return(mac_index(smc,1)) ;
+                return mac_index(smc, 1);
         else
-                return(phy_index(smc,e - ENTITY_PHY(0))) ;
+                return phy_index(smc, e - ENTITY_PHY(0));
 }
 #endif
 
 #ifdef  LITTLE_ENDIAN
 static int smt_swap_short(u_short s)
 {
-        return(((s>>8)&0xff)|((s&0xff)<<8)) ;
+        return ((s>>8)&0xff) | ((s&0xff)<<8);
 }
 
 void smt_swap_para(struct smt_header *sm, int len, int direction)
@@ -1996,7 +1996,7 @@ int smt_action(struct s_smc *smc, int class, int code, int index)
                         }
                         break ;
                 default :
-                        return(1) ;
+                        return 1;
                 }
                 break ;
         case SMT_PORT_ACTION :
@@ -2017,14 +2017,14 @@ int smt_action(struct s_smc *smc, int class, int code, int index)
                         event = PC_STOP ;
                         break ;
                 default :
-                        return(1) ;
+                        return 1;
                 }
                 queue_event(smc,EVENT_PCM+index,event) ;
                 break ;
         default :
-                return(1) ;
+                return 1;
         }
-        return(0) ;
+        return 0;
 }
 
 /*
diff --git a/drivers/net/skfp/smtdef.c b/drivers/net/skfp/smtdef.c
index 4e07ff7073f1..1acab0b368e3 100644
--- a/drivers/net/skfp/smtdef.c
+++ b/drivers/net/skfp/smtdef.c
@@ -303,7 +303,7 @@ int smt_set_mac_opvalues(struct s_smc *smc)
                         FDDI_SMT_EVENT, (u_long) FDDI_REMOTE_T_REQ,
                         smt_get_event_word(smc));
         }
-        return(st) ;
+        return st;
 }
 
 void smt_fixup_mib(struct s_smc *smc)
@@ -350,6 +350,6 @@ static int set_min_max(int maxflag, u_long mib, u_long limit, u_long *oper)
                 *oper = limit ;
         else
                 *oper = mib ;
-        return(old != *oper) ;
+        return old != *oper;
 }
 
diff --git a/drivers/net/skfp/smtinit.c b/drivers/net/skfp/smtinit.c
index 3c8964ce1837..e3a0c0bc2233 100644
--- a/drivers/net/skfp/smtinit.c
+++ b/drivers/net/skfp/smtinit.c
@@ -120,6 +120,6 @@ int init_smt(struct s_smc *smc, u_char *mac_addr)
 
         PNMI_INIT(smc) ;                /* PNMI initialization */
 
-        return(0) ;
+        return 0;
 }
 
diff --git a/drivers/net/skfp/srf.c b/drivers/net/skfp/srf.c
index 40882b3faba6..f6f7baf9f27a 100644
--- a/drivers/net/skfp/srf.c
+++ b/drivers/net/skfp/srf.c
@@ -165,7 +165,7 @@ static struct s_srf_evc *smt_get_evc(struct s_smc *smc, int code, int index)
 
         for (i = 0, evc = smc->evcs ; (unsigned) i < MAX_EVCS ; i++, evc++) {
                 if (evc->evc_code == code && evc->evc_index == index)
-                        return(evc) ;
+                        return evc;
         }
         return NULL;
 }