diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-09-02 16:07:41 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-02 22:06:22 -0400 |
commit | bc8acf2c8c3e43fcc192762a9f964b3e9a17748b (patch) | |
tree | e3a91392771a22390e59c24fcb7bad3045ce17d1 /drivers/net/qlge | |
parent | 7162f6691e9d39d8d866574687cddb3f1ec65d72 (diff) |
drivers/net: avoid some skb->ip_summed initializations
fresh skbs have ip_summed set to CHECKSUM_NONE (0)
We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.
Introduce skb_checksum_none_assert() helper so that we keep this
assertion documented in driver sources.
Change most occurrences of :
skb->ip_summed = CHECKSUM_NONE;
by :
skb_checksum_none_assert(skb);
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/qlge')
-rw-r--r-- | drivers/net/qlge/qlge_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c index 5a245211fc53..e2d0e108b9aa 100644 --- a/drivers/net/qlge/qlge_main.c +++ b/drivers/net/qlge/qlge_main.c | |||
@@ -1566,7 +1566,7 @@ static void ql_process_mac_rx_page(struct ql_adapter *qdev, | |||
1566 | rx_ring->rx_packets++; | 1566 | rx_ring->rx_packets++; |
1567 | rx_ring->rx_bytes += skb->len; | 1567 | rx_ring->rx_bytes += skb->len; |
1568 | skb->protocol = eth_type_trans(skb, ndev); | 1568 | skb->protocol = eth_type_trans(skb, ndev); |
1569 | skb->ip_summed = CHECKSUM_NONE; | 1569 | skb_checksum_none_assert(skb); |
1570 | 1570 | ||
1571 | if (qdev->rx_csum && | 1571 | if (qdev->rx_csum && |
1572 | !(ib_mac_rsp->flags1 & IB_MAC_CSUM_ERR_MASK)) { | 1572 | !(ib_mac_rsp->flags1 & IB_MAC_CSUM_ERR_MASK)) { |
@@ -1676,7 +1676,7 @@ static void ql_process_mac_rx_skb(struct ql_adapter *qdev, | |||
1676 | rx_ring->rx_packets++; | 1676 | rx_ring->rx_packets++; |
1677 | rx_ring->rx_bytes += skb->len; | 1677 | rx_ring->rx_bytes += skb->len; |
1678 | skb->protocol = eth_type_trans(skb, ndev); | 1678 | skb->protocol = eth_type_trans(skb, ndev); |
1679 | skb->ip_summed = CHECKSUM_NONE; | 1679 | skb_checksum_none_assert(skb); |
1680 | 1680 | ||
1681 | /* If rx checksum is on, and there are no | 1681 | /* If rx checksum is on, and there are no |
1682 | * csum or frame errors. | 1682 | * csum or frame errors. |
@@ -1996,7 +1996,7 @@ static void ql_process_mac_split_rx_intr(struct ql_adapter *qdev, | |||
1996 | } | 1996 | } |
1997 | 1997 | ||
1998 | skb->protocol = eth_type_trans(skb, ndev); | 1998 | skb->protocol = eth_type_trans(skb, ndev); |
1999 | skb->ip_summed = CHECKSUM_NONE; | 1999 | skb_checksum_none_assert(skb); |
2000 | 2000 | ||
2001 | /* If rx checksum is on, and there are no | 2001 | /* If rx checksum is on, and there are no |
2002 | * csum or frame errors. | 2002 | * csum or frame errors. |