aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/qlcnic
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2010-06-29 22:46:56 -0400
committerDavid S. Miller <davem@davemloft.net>2010-06-30 17:09:36 -0400
commit97d1935a61b7fe7a65f98f154c7f3301cfe746f3 (patch)
tree5c4586fd94e18935a9022f5c440f503daa32c636 /drivers/net/qlcnic
parent1437ce3983bcbc0447a0dedcd644c14fe833d266 (diff)
netdev: Make ethtool_ops::set_flags() return -EINVAL for unsupported flags
The documented error code for attempts to set unsupported flags (or to clear flags that cannot be disabled) is EINVAL, not EOPNOTSUPP. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Acked-by: Eilon Greenstein <eilong@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/qlcnic')
-rw-r--r--drivers/net/qlcnic/qlcnic_ethtool.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c
index b9d5acbaf540..f8e39e4cfe0f 100644
--- a/drivers/net/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/qlcnic/qlcnic_ethtool.c
@@ -984,7 +984,7 @@ static int qlcnic_set_flags(struct net_device *netdev, u32 data)
984 int hw_lro; 984 int hw_lro;
985 985
986 if (data & ~ETH_FLAG_LRO) 986 if (data & ~ETH_FLAG_LRO)
987 return -EOPNOTSUPP; 987 return -EINVAL;
988 988
989 if (!(adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO)) 989 if (!(adapter->capabilities & QLCNIC_FW_CAPABILITY_HW_LRO))
990 return -EINVAL; 990 return -EINVAL;