diff options
author | Dhananjay Phadke <dhananjay@netxen.com> | 2009-07-26 16:07:42 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-07-27 14:15:25 -0400 |
commit | 4f96b988e8d404b8b32aefed27503b4538949a3c (patch) | |
tree | 22d6aa87665cd02c4f3815357e9242bc50ff428e /drivers/net/netxen/netxen_nic_main.c | |
parent | 24767ab16913bc27ba7a85698e5c0f591368647d (diff) |
netxen: clean up firmware version checks
NX2031 firmware version will never be > 4.0.0, so replace
(adapter->fw_major < 4) checks with pci revision ID check.
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/netxen/netxen_nic_main.c')
-rw-r--r-- | drivers/net/netxen/netxen_nic_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 1aa850a0b895..5d52630ecd88 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c | |||
@@ -932,7 +932,7 @@ netxen_nic_attach(struct netxen_adapter *adapter) | |||
932 | goto err_out_free_sw; | 932 | goto err_out_free_sw; |
933 | } | 933 | } |
934 | 934 | ||
935 | if (adapter->fw_major < 4) { | 935 | if (NX_IS_REVISION_P2(adapter->ahw.revision_id)) { |
936 | tx_ring = adapter->tx_ring; | 936 | tx_ring = adapter->tx_ring; |
937 | tx_ring->crb_cmd_producer = crb_cmd_producer[adapter->portnum]; | 937 | tx_ring->crb_cmd_producer = crb_cmd_producer[adapter->portnum]; |
938 | tx_ring->crb_cmd_consumer = crb_cmd_consumer[adapter->portnum]; | 938 | tx_ring->crb_cmd_consumer = crb_cmd_consumer[adapter->portnum]; |
@@ -1103,7 +1103,7 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1103 | * See if the firmware gave us a virtual-physical port mapping. | 1103 | * See if the firmware gave us a virtual-physical port mapping. |
1104 | */ | 1104 | */ |
1105 | adapter->physical_port = adapter->portnum; | 1105 | adapter->physical_port = adapter->portnum; |
1106 | if (adapter->fw_major < 4) { | 1106 | if (NX_IS_REVISION_P2(adapter->ahw.revision_id)) { |
1107 | i = NXRD32(adapter, CRB_V2P(adapter->portnum)); | 1107 | i = NXRD32(adapter, CRB_V2P(adapter->portnum)); |
1108 | if (i != 0x55555555) | 1108 | if (i != 0x55555555) |
1109 | adapter->physical_port = i; | 1109 | adapter->physical_port = i; |
@@ -1727,7 +1727,7 @@ static irqreturn_t netxen_intr(int irq, void *data) | |||
1727 | } | 1727 | } |
1728 | 1728 | ||
1729 | /* clear interrupt */ | 1729 | /* clear interrupt */ |
1730 | if (adapter->fw_major < 4) | 1730 | if (NX_IS_REVISION_P2(adapter->ahw.revision_id)) |
1731 | netxen_nic_disable_int(sds_ring); | 1731 | netxen_nic_disable_int(sds_ring); |
1732 | 1732 | ||
1733 | adapter->pci_write_immediate(adapter, | 1733 | adapter->pci_write_immediate(adapter, |