aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/netxen/netxen_nic_main.c
diff options
context:
space:
mode:
authorDhananjay Phadke <dhananjay@netxen.com>2009-05-05 15:05:06 -0400
committerDavid S. Miller <davem@davemloft.net>2009-05-06 18:33:35 -0400
commit22527864ed7ee6c50f3c4d4b03c83c963caf5c0b (patch)
tree074c3dce3fe61b54aec6c7d8a829c4fa7592a6c0 /drivers/net/netxen/netxen_nic_main.c
parent78a658d9720ce1b3dd71af3ee6d207ca751a48f5 (diff)
netxen: fix race in tx ring acccess
Fix the distance check between tx ring producer and consumer that could lead to tx ring wrap around. Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/netxen/netxen_nic_main.c')
-rw-r--r--drivers/net/netxen/netxen_nic_main.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 5d79c19a6ec0..6a496b1909eb 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -809,6 +809,7 @@ netxen_nic_down(struct netxen_adapter *adapter, struct net_device *netdev)
809{ 809{
810 netif_carrier_off(netdev); 810 netif_carrier_off(netdev);
811 netif_stop_queue(netdev); 811 netif_stop_queue(netdev);
812 smp_mb();
812 netxen_napi_disable(adapter); 813 netxen_napi_disable(adapter);
813 814
814 if (adapter->stop_port) 815 if (adapter->stop_port)
@@ -1340,7 +1341,7 @@ netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
1340 producer = tx_ring->producer; 1341 producer = tx_ring->producer;
1341 smp_mb(); 1342 smp_mb();
1342 consumer = tx_ring->sw_consumer; 1343 consumer = tx_ring->sw_consumer;
1343 if ((no_of_desc+2) > find_diff_among(producer, consumer, num_txd)) { 1344 if ((no_of_desc+2) >= find_diff_among(producer, consumer, num_txd)) {
1344 netif_stop_queue(netdev); 1345 netif_stop_queue(netdev);
1345 smp_mb(); 1346 smp_mb();
1346 return NETDEV_TX_BUSY; 1347 return NETDEV_TX_BUSY;