aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/irda
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2012-05-22 18:50:46 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-05-22 18:50:46 -0400
commita481991467d38afb43c3921d5b5b59ccb61b04ba (patch)
treea4b0b9a14da6fd5ef7b9b512bb32dbfcfcf2cd71 /drivers/net/irda
parentf6a26ae7699416d86bea8cb68ce413571e9cab3c (diff)
parentcda4db53e9c28061c100400e1a4d273ea61dfba9 (diff)
Merge tag 'usb-3.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
Pull USB 3.5-rc1 changes from Greg Kroah-Hartman: "Here is the big USB 3.5-rc1 pull request for the 3.5-rc1 merge window. It's touches a lot of different parts of the kernel, all USB drivers, due to some API cleanups (getting rid of the ancient err() macro) and some changes that are needed for USB 3.0 power management updates. There are also lots of new drivers, pimarily gadget, but others as well. We deleted a staging driver, which was nice, and finally dropped the obsolete usbfs code, which will make Al happy to never have to touch that again. There were some build errors in the tree that linux-next found a few days ago, but those were fixed by the most recent changes (all were due to us not building with CONFIG_PM disabled.) Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>" * tag 'usb-3.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (477 commits) xhci: Fix DIV_ROUND_UP compile error. xhci: Fix compile with CONFIG_USB_SUSPEND=n USB: Fix core compile with CONFIG_USB_SUSPEND=n brcm80211: Fix compile error for .disable_hub_initiated_lpm. Revert "USB: EHCI: work around bug in the Philips ISP1562 controller" MAINTAINERS: Add myself as maintainer to the USB PHY Layer USB: EHCI: fix command register configuration lost problem USB: Remove races in devio.c USB: ehci-platform: remove update_device USB: Disable hub-initiated LPM for comms devices. xhci: Add Intel U1/U2 timeout policy. xhci: Add infrastructure for host-specific LPM policies. USB: Add macros for interrupt endpoint types. xhci: Reserve one command for USB3 LPM disable. xhci: Some Evaluate Context commands must succeed. USB: Disable USB 3.0 LPM in critical sections. USB: Add support to enable/disable USB3 link states. USB: Allow drivers to disable hub-initiated LPM. USB: Calculate USB 3.0 exit latencies for LPM. USB: Refactor code to set LPM support flag. ... Conflicts: arch/arm/mach-exynos/mach-nuri.c arch/arm/mach-exynos/mach-universal_c210.c drivers/net/wireless/ath/ath6kl/usb.c
Diffstat (limited to 'drivers/net/irda')
-rw-r--r--drivers/net/irda/irda-usb.c2
-rw-r--r--drivers/net/irda/kingsun-sir.c42
-rw-r--r--drivers/net/irda/ks959-sir.c31
-rw-r--r--drivers/net/irda/ksdazzle-sir.c46
-rw-r--r--drivers/net/irda/stir4200.c6
5 files changed, 77 insertions, 50 deletions
diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c
index 72f687b40d66..f9a86bdb12fa 100644
--- a/drivers/net/irda/irda-usb.c
+++ b/drivers/net/irda/irda-usb.c
@@ -1671,7 +1671,7 @@ static int irda_usb_probe(struct usb_interface *intf,
1671 1671
1672 /* Is this really necessary? (no, except maybe for broken devices) */ 1672 /* Is this really necessary? (no, except maybe for broken devices) */
1673 if (usb_reset_configuration (dev) < 0) { 1673 if (usb_reset_configuration (dev) < 0) {
1674 err("reset_configuration failed"); 1674 dev_err(&intf->dev, "reset_configuration failed\n");
1675 ret = -EIO; 1675 ret = -EIO;
1676 goto err_out_3; 1676 goto err_out_3;
1677 } 1677 }
diff --git a/drivers/net/irda/kingsun-sir.c b/drivers/net/irda/kingsun-sir.c
index 79aebeee928c..7b4833874ef5 100644
--- a/drivers/net/irda/kingsun-sir.c
+++ b/drivers/net/irda/kingsun-sir.c
@@ -134,14 +134,16 @@ static void kingsun_send_irq(struct urb *urb)
134 134
135 /* in process of stopping, just drop data */ 135 /* in process of stopping, just drop data */
136 if (!netif_running(kingsun->netdev)) { 136 if (!netif_running(kingsun->netdev)) {
137 err("kingsun_send_irq: Network not running!"); 137 dev_err(&kingsun->usbdev->dev,
138 "kingsun_send_irq: Network not running!\n");
138 return; 139 return;
139 } 140 }
140 141
141 /* unlink, shutdown, unplug, other nasties */ 142 /* unlink, shutdown, unplug, other nasties */
142 if (urb->status != 0) { 143 if (urb->status != 0) {
143 err("kingsun_send_irq: urb asynchronously failed - %d", 144 dev_err(&kingsun->usbdev->dev,
144 urb->status); 145 "kingsun_send_irq: urb asynchronously failed - %d\n",
146 urb->status);
145 } 147 }
146 netif_wake_queue(netdev); 148 netif_wake_queue(netdev);
147} 149}
@@ -177,7 +179,8 @@ static netdev_tx_t kingsun_hard_xmit(struct sk_buff *skb,
177 kingsun, 1); 179 kingsun, 1);
178 180
179 if ((ret = usb_submit_urb(kingsun->tx_urb, GFP_ATOMIC))) { 181 if ((ret = usb_submit_urb(kingsun->tx_urb, GFP_ATOMIC))) {
180 err("kingsun_hard_xmit: failed tx_urb submit: %d", ret); 182 dev_err(&kingsun->usbdev->dev,
183 "kingsun_hard_xmit: failed tx_urb submit: %d\n", ret);
181 switch (ret) { 184 switch (ret) {
182 case -ENODEV: 185 case -ENODEV:
183 case -EPIPE: 186 case -EPIPE:
@@ -211,8 +214,9 @@ static void kingsun_rcv_irq(struct urb *urb)
211 214
212 /* unlink, shutdown, unplug, other nasties */ 215 /* unlink, shutdown, unplug, other nasties */
213 if (urb->status != 0) { 216 if (urb->status != 0) {
214 err("kingsun_rcv_irq: urb asynchronously failed - %d", 217 dev_err(&kingsun->usbdev->dev,
215 urb->status); 218 "kingsun_rcv_irq: urb asynchronously failed - %d\n",
219 urb->status);
216 kingsun->receiving = 0; 220 kingsun->receiving = 0;
217 return; 221 return;
218 } 222 }
@@ -238,8 +242,9 @@ static void kingsun_rcv_irq(struct urb *urb)
238 ? 1 : 0; 242 ? 1 : 0;
239 } 243 }
240 } else if (urb->actual_length > 0) { 244 } else if (urb->actual_length > 0) {
241 err("%s(): Unexpected response length, expected %d got %d", 245 dev_err(&kingsun->usbdev->dev,
242 __func__, kingsun->max_rx, urb->actual_length); 246 "%s(): Unexpected response length, expected %d got %d\n",
247 __func__, kingsun->max_rx, urb->actual_length);
243 } 248 }
244 /* This urb has already been filled in kingsun_net_open */ 249 /* This urb has already been filled in kingsun_net_open */
245 ret = usb_submit_urb(urb, GFP_ATOMIC); 250 ret = usb_submit_urb(urb, GFP_ATOMIC);
@@ -286,7 +291,7 @@ static int kingsun_net_open(struct net_device *netdev)
286 sprintf(hwname, "usb#%d", kingsun->usbdev->devnum); 291 sprintf(hwname, "usb#%d", kingsun->usbdev->devnum);
287 kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname); 292 kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname);
288 if (!kingsun->irlap) { 293 if (!kingsun->irlap) {
289 err("kingsun-sir: irlap_open failed"); 294 dev_err(&kingsun->usbdev->dev, "irlap_open failed\n");
290 goto free_mem; 295 goto free_mem;
291 } 296 }
292 297
@@ -298,7 +303,8 @@ static int kingsun_net_open(struct net_device *netdev)
298 kingsun->rx_urb->status = 0; 303 kingsun->rx_urb->status = 0;
299 err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL); 304 err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL);
300 if (err) { 305 if (err) {
301 err("kingsun-sir: first urb-submit failed: %d", err); 306 dev_err(&kingsun->usbdev->dev,
307 "first urb-submit failed: %d\n", err);
302 goto close_irlap; 308 goto close_irlap;
303 } 309 }
304 310
@@ -446,13 +452,15 @@ static int kingsun_probe(struct usb_interface *intf,
446 */ 452 */
447 interface = intf->cur_altsetting; 453 interface = intf->cur_altsetting;
448 if (interface->desc.bNumEndpoints != 2) { 454 if (interface->desc.bNumEndpoints != 2) {
449 err("kingsun-sir: expected 2 endpoints, found %d", 455 dev_err(&intf->dev,
450 interface->desc.bNumEndpoints); 456 "kingsun-sir: expected 2 endpoints, found %d\n",
457 interface->desc.bNumEndpoints);
451 return -ENODEV; 458 return -ENODEV;
452 } 459 }
453 endpoint = &interface->endpoint[KINGSUN_EP_IN].desc; 460 endpoint = &interface->endpoint[KINGSUN_EP_IN].desc;
454 if (!usb_endpoint_is_int_in(endpoint)) { 461 if (!usb_endpoint_is_int_in(endpoint)) {
455 err("kingsun-sir: endpoint 0 is not interrupt IN"); 462 dev_err(&intf->dev,
463 "kingsun-sir: endpoint 0 is not interrupt IN\n");
456 return -ENODEV; 464 return -ENODEV;
457 } 465 }
458 466
@@ -460,14 +468,16 @@ static int kingsun_probe(struct usb_interface *intf,
460 pipe = usb_rcvintpipe(dev, ep_in); 468 pipe = usb_rcvintpipe(dev, ep_in);
461 maxp_in = usb_maxpacket(dev, pipe, usb_pipeout(pipe)); 469 maxp_in = usb_maxpacket(dev, pipe, usb_pipeout(pipe));
462 if (maxp_in > 255 || maxp_in <= 1) { 470 if (maxp_in > 255 || maxp_in <= 1) {
463 err("%s: endpoint 0 has max packet size %d not in range", 471 dev_err(&intf->dev,
464 __FILE__, maxp_in); 472 "endpoint 0 has max packet size %d not in range\n",
473 maxp_in);
465 return -ENODEV; 474 return -ENODEV;
466 } 475 }
467 476
468 endpoint = &interface->endpoint[KINGSUN_EP_OUT].desc; 477 endpoint = &interface->endpoint[KINGSUN_EP_OUT].desc;
469 if (!usb_endpoint_is_int_out(endpoint)) { 478 if (!usb_endpoint_is_int_out(endpoint)) {
470 err("kingsun-sir: endpoint 1 is not interrupt OUT"); 479 dev_err(&intf->dev,
480 "kingsun-sir: endpoint 1 is not interrupt OUT\n");
471 return -ENODEV; 481 return -ENODEV;
472 } 482 }
473 483
diff --git a/drivers/net/irda/ks959-sir.c b/drivers/net/irda/ks959-sir.c
index abe689dffc72..824e2a93fe8a 100644
--- a/drivers/net/irda/ks959-sir.c
+++ b/drivers/net/irda/ks959-sir.c
@@ -247,8 +247,9 @@ static void ks959_speed_irq(struct urb *urb)
247{ 247{
248 /* unlink, shutdown, unplug, other nasties */ 248 /* unlink, shutdown, unplug, other nasties */
249 if (urb->status != 0) { 249 if (urb->status != 0) {
250 err("ks959_speed_irq: urb asynchronously failed - %d", 250 dev_err(&urb->dev->dev,
251 urb->status); 251 "ks959_speed_irq: urb asynchronously failed - %d\n",
252 urb->status);
252 } 253 }
253} 254}
254 255
@@ -332,14 +333,16 @@ static void ks959_send_irq(struct urb *urb)
332 333
333 /* in process of stopping, just drop data */ 334 /* in process of stopping, just drop data */
334 if (!netif_running(kingsun->netdev)) { 335 if (!netif_running(kingsun->netdev)) {
335 err("ks959_send_irq: Network not running!"); 336 dev_err(&kingsun->usbdev->dev,
337 "ks959_send_irq: Network not running!\n");
336 return; 338 return;
337 } 339 }
338 340
339 /* unlink, shutdown, unplug, other nasties */ 341 /* unlink, shutdown, unplug, other nasties */
340 if (urb->status != 0) { 342 if (urb->status != 0) {
341 err("ks959_send_irq: urb asynchronously failed - %d", 343 dev_err(&kingsun->usbdev->dev,
342 urb->status); 344 "ks959_send_irq: urb asynchronously failed - %d\n",
345 urb->status);
343 return; 346 return;
344 } 347 }
345 348
@@ -358,8 +361,9 @@ static void ks959_send_irq(struct urb *urb)
358 if (kingsun->tx_buf_clear_used > 0) { 361 if (kingsun->tx_buf_clear_used > 0) {
359 /* There is more data to be sent */ 362 /* There is more data to be sent */
360 if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) { 363 if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) {
361 err("ks959_send_irq: failed tx_urb submit: %d", 364 dev_err(&kingsun->usbdev->dev,
362 ret); 365 "ks959_send_irq: failed tx_urb submit: %d\n",
366 ret);
363 switch (ret) { 367 switch (ret) {
364 case -ENODEV: 368 case -ENODEV:
365 case -EPIPE: 369 case -EPIPE:
@@ -407,7 +411,8 @@ static netdev_tx_t ks959_hard_xmit(struct sk_buff *skb,
407 kingsun->tx_buf_clear_used = wraplen; 411 kingsun->tx_buf_clear_used = wraplen;
408 412
409 if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) { 413 if ((ret = ks959_submit_tx_fragment(kingsun)) != 0) {
410 err("ks959_hard_xmit: failed tx_urb submit: %d", ret); 414 dev_err(&kingsun->usbdev->dev,
415 "ks959_hard_xmit: failed tx_urb submit: %d\n", ret);
411 switch (ret) { 416 switch (ret) {
412 case -ENODEV: 417 case -ENODEV:
413 case -EPIPE: 418 case -EPIPE:
@@ -442,8 +447,9 @@ static void ks959_rcv_irq(struct urb *urb)
442 447
443 /* unlink, shutdown, unplug, other nasties */ 448 /* unlink, shutdown, unplug, other nasties */
444 if (urb->status != 0) { 449 if (urb->status != 0) {
445 err("kingsun_rcv_irq: urb asynchronously failed - %d", 450 dev_err(&kingsun->usbdev->dev,
446 urb->status); 451 "kingsun_rcv_irq: urb asynchronously failed - %d\n",
452 urb->status);
447 kingsun->receiving = 0; 453 kingsun->receiving = 0;
448 return; 454 return;
449 } 455 }
@@ -536,7 +542,7 @@ static int ks959_net_open(struct net_device *netdev)
536 sprintf(hwname, "usb#%d", kingsun->usbdev->devnum); 542 sprintf(hwname, "usb#%d", kingsun->usbdev->devnum);
537 kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname); 543 kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname);
538 if (!kingsun->irlap) { 544 if (!kingsun->irlap) {
539 err("ks959-sir: irlap_open failed"); 545 dev_err(&kingsun->usbdev->dev, "irlap_open failed\n");
540 goto free_mem; 546 goto free_mem;
541 } 547 }
542 548
@@ -549,7 +555,8 @@ static int ks959_net_open(struct net_device *netdev)
549 kingsun->rx_urb->status = 0; 555 kingsun->rx_urb->status = 0;
550 err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL); 556 err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL);
551 if (err) { 557 if (err) {
552 err("ks959-sir: first urb-submit failed: %d", err); 558 dev_err(&kingsun->usbdev->dev,
559 "first urb-submit failed: %d\n", err);
553 goto close_irlap; 560 goto close_irlap;
554 } 561 }
555 562
diff --git a/drivers/net/irda/ksdazzle-sir.c b/drivers/net/irda/ksdazzle-sir.c
index f8c01088eeb7..5a278ab83c2f 100644
--- a/drivers/net/irda/ksdazzle-sir.c
+++ b/drivers/net/irda/ksdazzle-sir.c
@@ -168,10 +168,10 @@ struct ksdazzle_cb {
168static void ksdazzle_speed_irq(struct urb *urb) 168static void ksdazzle_speed_irq(struct urb *urb)
169{ 169{
170 /* unlink, shutdown, unplug, other nasties */ 170 /* unlink, shutdown, unplug, other nasties */
171 if (urb->status != 0) { 171 if (urb->status != 0)
172 err("ksdazzle_speed_irq: urb asynchronously failed - %d", 172 dev_err(&urb->dev->dev,
173 urb->status); 173 "ksdazzle_speed_irq: urb asynchronously failed - %d\n",
174 } 174 urb->status);
175} 175}
176 176
177/* Send a control request to change speed of the dongle */ 177/* Send a control request to change speed of the dongle */
@@ -245,14 +245,16 @@ static void ksdazzle_send_irq(struct urb *urb)
245 245
246 /* in process of stopping, just drop data */ 246 /* in process of stopping, just drop data */
247 if (!netif_running(kingsun->netdev)) { 247 if (!netif_running(kingsun->netdev)) {
248 err("ksdazzle_send_irq: Network not running!"); 248 dev_err(&kingsun->usbdev->dev,
249 "ksdazzle_send_irq: Network not running!\n");
249 return; 250 return;
250 } 251 }
251 252
252 /* unlink, shutdown, unplug, other nasties */ 253 /* unlink, shutdown, unplug, other nasties */
253 if (urb->status != 0) { 254 if (urb->status != 0) {
254 err("ksdazzle_send_irq: urb asynchronously failed - %d", 255 dev_err(&kingsun->usbdev->dev,
255 urb->status); 256 "ksdazzle_send_irq: urb asynchronously failed - %d\n",
257 urb->status);
256 return; 258 return;
257 } 259 }
258 260
@@ -271,7 +273,9 @@ static void ksdazzle_send_irq(struct urb *urb)
271 if (kingsun->tx_buf_clear_used > 0) { 273 if (kingsun->tx_buf_clear_used > 0) {
272 /* There is more data to be sent */ 274 /* There is more data to be sent */
273 if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) { 275 if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) {
274 err("ksdazzle_send_irq: failed tx_urb submit: %d", ret); 276 dev_err(&kingsun->usbdev->dev,
277 "ksdazzle_send_irq: failed tx_urb submit: %d\n",
278 ret);
275 switch (ret) { 279 switch (ret) {
276 case -ENODEV: 280 case -ENODEV:
277 case -EPIPE: 281 case -EPIPE:
@@ -320,7 +324,8 @@ static netdev_tx_t ksdazzle_hard_xmit(struct sk_buff *skb,
320 kingsun->tx_buf_clear_used = wraplen; 324 kingsun->tx_buf_clear_used = wraplen;
321 325
322 if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) { 326 if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) {
323 err("ksdazzle_hard_xmit: failed tx_urb submit: %d", ret); 327 dev_err(&kingsun->usbdev->dev,
328 "ksdazzle_hard_xmit: failed tx_urb submit: %d\n", ret);
324 switch (ret) { 329 switch (ret) {
325 case -ENODEV: 330 case -ENODEV:
326 case -EPIPE: 331 case -EPIPE:
@@ -355,8 +360,9 @@ static void ksdazzle_rcv_irq(struct urb *urb)
355 360
356 /* unlink, shutdown, unplug, other nasties */ 361 /* unlink, shutdown, unplug, other nasties */
357 if (urb->status != 0) { 362 if (urb->status != 0) {
358 err("ksdazzle_rcv_irq: urb asynchronously failed - %d", 363 dev_err(&kingsun->usbdev->dev,
359 urb->status); 364 "ksdazzle_rcv_irq: urb asynchronously failed - %d\n",
365 urb->status);
360 kingsun->receiving = 0; 366 kingsun->receiving = 0;
361 return; 367 return;
362 } 368 }
@@ -430,7 +436,7 @@ static int ksdazzle_net_open(struct net_device *netdev)
430 sprintf(hwname, "usb#%d", kingsun->usbdev->devnum); 436 sprintf(hwname, "usb#%d", kingsun->usbdev->devnum);
431 kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname); 437 kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname);
432 if (!kingsun->irlap) { 438 if (!kingsun->irlap) {
433 err("ksdazzle-sir: irlap_open failed"); 439 dev_err(&kingsun->usbdev->dev, "irlap_open failed\n");
434 goto free_mem; 440 goto free_mem;
435 } 441 }
436 442
@@ -442,7 +448,7 @@ static int ksdazzle_net_open(struct net_device *netdev)
442 kingsun->rx_urb->status = 0; 448 kingsun->rx_urb->status = 0;
443 err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL); 449 err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL);
444 if (err) { 450 if (err) {
445 err("ksdazzle-sir: first urb-submit failed: %d", err); 451 dev_err(&kingsun->usbdev->dev, "first urb-submit failed: %d\n", err);
446 goto close_irlap; 452 goto close_irlap;
447 } 453 }
448 454
@@ -590,13 +596,14 @@ static int ksdazzle_probe(struct usb_interface *intf,
590 */ 596 */
591 interface = intf->cur_altsetting; 597 interface = intf->cur_altsetting;
592 if (interface->desc.bNumEndpoints != 2) { 598 if (interface->desc.bNumEndpoints != 2) {
593 err("ksdazzle: expected 2 endpoints, found %d", 599 dev_err(&intf->dev, "ksdazzle: expected 2 endpoints, found %d\n",
594 interface->desc.bNumEndpoints); 600 interface->desc.bNumEndpoints);
595 return -ENODEV; 601 return -ENODEV;
596 } 602 }
597 endpoint = &interface->endpoint[KINGSUN_EP_IN].desc; 603 endpoint = &interface->endpoint[KINGSUN_EP_IN].desc;
598 if (!usb_endpoint_is_int_in(endpoint)) { 604 if (!usb_endpoint_is_int_in(endpoint)) {
599 err("ksdazzle: endpoint 0 is not interrupt IN"); 605 dev_err(&intf->dev,
606 "ksdazzle: endpoint 0 is not interrupt IN\n");
600 return -ENODEV; 607 return -ENODEV;
601 } 608 }
602 609
@@ -604,13 +611,16 @@ static int ksdazzle_probe(struct usb_interface *intf,
604 pipe = usb_rcvintpipe(dev, ep_in); 611 pipe = usb_rcvintpipe(dev, ep_in);
605 maxp_in = usb_maxpacket(dev, pipe, usb_pipeout(pipe)); 612 maxp_in = usb_maxpacket(dev, pipe, usb_pipeout(pipe));
606 if (maxp_in > 255 || maxp_in <= 1) { 613 if (maxp_in > 255 || maxp_in <= 1) {
607 err("ksdazzle: endpoint 0 has max packet size %d not in range [2..255]", maxp_in); 614 dev_err(&intf->dev,
615 "ksdazzle: endpoint 0 has max packet size %d not in range [2..255]\n",
616 maxp_in);
608 return -ENODEV; 617 return -ENODEV;
609 } 618 }
610 619
611 endpoint = &interface->endpoint[KINGSUN_EP_OUT].desc; 620 endpoint = &interface->endpoint[KINGSUN_EP_OUT].desc;
612 if (!usb_endpoint_is_int_out(endpoint)) { 621 if (!usb_endpoint_is_int_out(endpoint)) {
613 err("ksdazzle: endpoint 1 is not interrupt OUT"); 622 dev_err(&intf->dev,
623 "ksdazzle: endpoint 1 is not interrupt OUT\n");
614 return -ENODEV; 624 return -ENODEV;
615 } 625 }
616 626
diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c
index e6e59a078ef4..876e709b65ba 100644
--- a/drivers/net/irda/stir4200.c
+++ b/drivers/net/irda/stir4200.c
@@ -904,7 +904,7 @@ static int stir_net_open(struct net_device *netdev)
904 sprintf(hwname, "usb#%d", stir->usbdev->devnum); 904 sprintf(hwname, "usb#%d", stir->usbdev->devnum);
905 stir->irlap = irlap_open(netdev, &stir->qos, hwname); 905 stir->irlap = irlap_open(netdev, &stir->qos, hwname);
906 if (!stir->irlap) { 906 if (!stir->irlap) {
907 err("stir4200: irlap_open failed"); 907 dev_err(&stir->usbdev->dev, "irlap_open failed\n");
908 goto err_out5; 908 goto err_out5;
909 } 909 }
910 910
@@ -913,7 +913,7 @@ static int stir_net_open(struct net_device *netdev)
913 "%s", stir->netdev->name); 913 "%s", stir->netdev->name);
914 if (IS_ERR(stir->thread)) { 914 if (IS_ERR(stir->thread)) {
915 err = PTR_ERR(stir->thread); 915 err = PTR_ERR(stir->thread);
916 err("stir4200: unable to start kernel thread"); 916 dev_err(&stir->usbdev->dev, "unable to start kernel thread\n");
917 goto err_out6; 917 goto err_out6;
918 } 918 }
919 919
@@ -1042,7 +1042,7 @@ static int stir_probe(struct usb_interface *intf,
1042 1042
1043 ret = usb_reset_configuration(dev); 1043 ret = usb_reset_configuration(dev);
1044 if (ret != 0) { 1044 if (ret != 0) {
1045 err("stir4200: usb reset configuration failed"); 1045 dev_err(&intf->dev, "usb reset configuration failed\n");
1046 goto err_out2; 1046 goto err_out2;
1047 } 1047 }
1048 1048